You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/18 10:14:00 UTC
[jira] [Commented] (ARTEMIS-1466) Upgrade Node.js version to comply
with GitBook 3.2.3
[ https://issues.apache.org/jira/browse/ARTEMIS-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209104#comment-16209104 ]
ASF GitHub Bot commented on ARTEMIS-1466:
-----------------------------------------
GitHub user pkralik opened a pull request:
https://github.com/apache/activemq-artemis/pull/1595
ARTEMIS-1466 Upgrade Node.js version to comply with GitBook 3.2.3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pkralik/activemq-artemis-1 ARTEMIS-1466
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1595
----
commit b3a3057c56fcb2961593b0e071626183e51effe0
Author: Pavel Kralik <pk...@redhat.com>
Date: 2017-10-18T09:19:21Z
Node.JS version upgrade to fix GitBook 3.2.3 crash
----
> Upgrade Node.js version to comply with GitBook 3.2.3
> ----------------------------------------------------
>
> Key: ARTEMIS-1466
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1466
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Pavel Kralik
>
> Building Artemis from fresh repository, purged NPM cache and removed previous version of GitBook with release profile. I am getting error: GitBook version 3.2.3 is corrupted.
> {code:java}
> mvn clean install -Prelease
> main:
> [mkdir] Created dir: /home/pkralik/git/activemq-artemis-1/artemis-website/target/classes/user-manual
> [echo] executing /home/pkralik/git/activemq-artemis-1/artemis-website/node_modules/.bin/gitbook
> [exec] Error loading version 3.2.3: SyntaxError: Use of const in strict mode.
> [exec] at Module._compile (module.js:439:25)
> [exec] at Object.Module._extensions..js (module.js:474:10)
> [exec] at Module.load (module.js:356:32)
> [exec] at Function.Module._load (module.js:312:12)
> [exec] at Module.require (module.js:364:17)
> [exec] at require (module.js:380:17)
> [exec] at Object.<anonymous> (/home/pkralik/.gitbook/versions/3.2.3/node_modules/read-installed/node_modules/read-package-json/read-json.js:12:16)
> [exec] at Module._compile (module.js:456:26)
> [exec] at Object.Module._extensions..js (module.js:474:10)
> [exec] at Module.load (module.js:356:32)
> [exec]
> [exec] GitBook Ver
> [exec] /home/pkralik/.gitbook/versions/3.2.3/node_modules/read-installed/node_modules/read-package-json/node_modules/json-parse-better-errors/index.js:9
> [exec] const syntaxErr = e.message.match(/^Unexpected token.*position\s+(\d+)/i)
> [exec] ^^^^^
> [exec] sion 3.2.3 is corrupted
> {code}
> GitBook 3.2.3 runs in strict mode and Node.js version (v0.10.32):
> https://github.com/apache/activemq-artemis/blob/master/artemis-website/pom.xml#L85
> must be upgraded according to this table:
> http://node.green/#ES2015-bindings-const-basic-support--strict-mode-
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)