You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by pmouawad <gi...@git.apache.org> on 2016/04/03 14:40:34 UTC
[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...
GitHub user pmouawad opened a pull request:
https://github.com/apache/jmeter/pull/179
Bug 59258 : GUI Mode : OOM Protection for View Results Tree or View Results in Table
This PR is a first try to base protection on memory estimation.
Memory estimation of SampleResult is too positive I think, it does only take into account the AssertionResult and SampleResult response data, not the properties size. This could be improved.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pmouawad/jmeter BUG_59258
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/179.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #179
----
commit 19da79cbf332a76757b22576b2b406722a66f3c8
Author: Philippe M <pm...@users.noreply.github.com>
Date: 2016-04-03T12:34:49Z
BUG_59258
commit 700eec86029530ba73b79bf792c0f6863b2305ee
Author: Philippe M <pm...@users.noreply.github.com>
Date: 2016-04-03T12:35:22Z
BUG_59258
commit cdc88957cebe76b76eaead7a13bf4f9f3d31e8f0
Author: Philippe M <pm...@users.noreply.github.com>
Date: 2016-04-03T12:36:02Z
BUG_59258
commit c7c87379c8e34522d81ec232c2234dc79f10be5d
Author: Philippe M <pm...@users.noreply.github.com>
Date: 2016-04-03T12:36:57Z
BUG_59258
commit 7e6a515b57621a9ff4ff5d89b3b1f0bcf025fbdb
Author: Philippe M <pm...@users.noreply.github.com>
Date: 2016-04-03T12:37:35Z
BUG_59258
commit 9d279583007cedf7cf1b8b8f77e9b607d91d3a4b
Author: Philippe M <pm...@users.noreply.github.com>
Date: 2016-04-03T12:38:03Z
BUG_59258
commit 298bbd72e59987d1eec07d5aea611399d62e3e35
Author: Philippe M <pm...@users.noreply.github.com>
Date: 2016-04-03T12:38:31Z
BUG_59258
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/179#issuecomment-204970518
> Memory estimation of SampleResult is too positive I think
Some heap dumps might help to get idea of the sampleresult.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/179#discussion_r58309855
--- Diff: src/components/org/apache/jmeter/visualizers/TableVisualizer.java ---
@@ -205,6 +226,26 @@ public void run() {
}
});
}
+
+ /**
+ * When the limit is reached, JMeter will not {@link SampleResult} anymore
+ * Setting to 0 disables the protection
+ */
+ private boolean applyOOMProtection() {
+ // Protection already in place
+ if(warningLabel.isVisible()) {
--- End diff --
What is the project style? `if (...)` or `if(...)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/179#discussion_r58309908
--- Diff: src/core/org/apache/jmeter/resources/messages.properties ---
@@ -1235,6 +1235,8 @@ view_results_in_table=View Results in Table
view_results_latency=Latency:
view_results_connect_time=Connect Time:
view_results_load_time=Load time:
+view_results_table_oom=To avoid OutOfMemory, component is not adding anymore sample results to the table anymore, use NON GUI mode for load testing
--- End diff --
> component is not adding anymore sample results to the table anymore
Is the first `anymore` excessive?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad closed the pull request at:
https://github.com/apache/jmeter/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 59258 : GUI Mode : OOM Protection for Vie...
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/179#discussion_r58309867
--- Diff: src/components/org/apache/jmeter/visualizers/TableVisualizer.java ---
@@ -205,6 +226,26 @@ public void run() {
}
});
}
+
+ /**
+ * When the limit is reached, JMeter will not {@link SampleResult} anymore
+ * Setting to 0 disables the protection
--- End diff --
Is "Setting to 0 disables the protection" relevant here?
`@return ...` would be good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---