[jira] [Commented] (SOLR-8794) Remove code usage of previously removed solr.xml tags

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183394#comment-15183394 ] 

David Smiley commented on SOLR-8794:
------------------------------------

Minor quibble: I thought we don't call the Solr Reference Guide "the wiki" because it's confusingly ambiguous with the so-called community wiki (MoinMoin based)?  That Confluence is a wiki is an implementation detail.

> Remove code usage of previously removed solr.xml tags
> -----------------------------------------------------
>
>                 Key: SOLR-8794
>                 URL: https://issues.apache.org/jira/browse/SOLR-8794
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Varun Thacker
>            Priority: Minor
>
> If my reading of the code is correct any usage of {{solr/sharedLib}} ,{{solr/coreLoadThreads}} , {{solr/persistent}} and {{solr/zkHost}} in the solr.xml file will throw an error currently.
> This is ensured using this code block in SolrXmlConfig.java
> {code}
>     failIfFound(config, "solr/@coreLoadThreads");
>     failIfFound(config, "solr/@persistent");
>     failIfFound(config, "solr/@sharedLib");
>     failIfFound(config, "solr/@zkHost");
> {code}
> In the same class however , these properties are read. For example,
> {code}
>         case "sharedLib":
>           builder.setSharedLibDirectory(value);
>           break;
> {code}
> This should be redundant and I think we can remove them. More importantly we should remove usage of it from the wiki page ( https://cwiki.apache.org/confluence/display/solr/Format+of+solr.xml )
> Also does anyone know if keeping {[managementPath}} is useful for the future? The wiki's description for it is "Currently non-operational."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org