[GitHub] [geode] pivotal-jbarrett commented on pull request #5532: GEODE-8513: Remove (de)serialization of local sessions.

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on pull request #5532:
URL: https://github.com/apache/geode/pull/5532#issuecomment-700840958


   Two interesting things were happing in there. First was the serialization of the session to disk, which really only made sense in peer mode since in client server the persistence is off JVM already. In peer mode it makes more sense, and is more tested, to use region persistence to achieve this hot deployment behavior. The second thing going on was the removal from the local region. This was to avoid class loader casting issues. This was just simplified to a local clear operation rather than iterating over all the sessions specific to this web context. The upside is that it takes a lot less time and doesn't invoke any queries. The downside is that other web contexts will have to refresh their local caches too but this scenario should be very small.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org