You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/07/19 02:38:04 UTC

Review Request 36596: Added jsonify() to stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36596/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

The jsonify() function converts a Protobuf/string/double/bool to
JSON::Value. Added some tests as well.


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 
  3rdparty/libprocess/3rdparty/stout/Makefile.am 89e7b1854bd7f449f4f0027d76c6430d259a24de 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 2394b95462182273464f0847f416ad83c3b64485 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36596/diff/


Testing
-------

make check with added tests.


Thanks,

Kapil Arya

Re: Review Request 36596: Added jsonify() to stout.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36596/#review92431
-----------------------------------------------------------


Bad patch!

Reviews applied: [36596]

Failed command: ./support/apply-review.sh -n -r 36596

Error:
 2015-07-21 17:07:43 URL:https://reviews.apache.org/r/36596/diff/raw/ [8815/8815] -> "36596.patch" [1]
Successfully applied: Added jsonify() to stout.

The jsonify() function converts a Protobuf/string/double/bool to
JSON::Value. Added some tests as well.


Review: https://reviews.apache.org/r/36596
Checking 2 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
stout:
  3rdparty/libprocess/3rdparty/stout/Makefile.am
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp
  3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp
libprocess:
  3rdparty/libprocess/3rdparty/Makefile.am
Failed to commit patch

- Mesos ReviewBot


On July 19, 2015, 12:43 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36596/
> -----------------------------------------------------------
> 
> (Updated July 19, 2015, 12:43 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The jsonify() function converts a Protobuf/string/double/bool to
> JSON::Value. Added some tests as well.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 89e7b1854bd7f449f4f0027d76c6430d259a24de 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 2394b95462182273464f0847f416ad83c3b64485 
>   3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36596/diff/
> 
> 
> Testing
> -------
> 
> make check with added tests.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 36596: Added jsonify() to stout.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36596/
-----------------------------------------------------------

(Updated July 18, 2015, 8:43 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

updated include files.


Repository: mesos


Description
-------

The jsonify() function converts a Protobuf/string/double/bool to
JSON::Value. Added some tests as well.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 
  3rdparty/libprocess/3rdparty/stout/Makefile.am 89e7b1854bd7f449f4f0027d76c6430d259a24de 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 2394b95462182273464f0847f416ad83c3b64485 
  3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36596/diff/


Testing
-------

make check with added tests.


Thanks,

Kapil Arya