You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Peter Hormanns (JIRA)" <ji...@apache.org> on 2008/09/27 18:47:44 UTC
[jira] Created: (JSPWIKI-386) LoginModule Configuration fails
LoginModule Configuration fails
-------------------------------
Key: JSPWIKI-386
URL: https://issues.apache.org/jira/browse/JSPWIKI-386
Project: JSPWiki
Issue Type: Bug
Components: Authentication&Authorization
Affects Versions: 2.8
Reporter: Peter Hormanns
Priority: Minor
I did some tests with JSPWiki and CAS authentication server from jsa-sig:http://www.ja-sig.org/products/cas/.
I wrote and configured a login module class, but UserDatabaseLoginModule is allways used.
I found an error in authenticationManager.java at line 374, see attached patch: variable "m_loginModuleClass" should be used, not constant class "UserDatabaseLoginModule.class"
Is that correct?
Best Regards,
Peter Hormanns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-386) LoginModule Configuration fails
Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635187#action_12635187 ]
Harry Metske commented on JSPWIKI-386:
--------------------------------------
Looks like a valid patch to me, Andrew what do you think ?
> LoginModule Configuration fails
> -------------------------------
>
> Key: JSPWIKI-386
> URL: https://issues.apache.org/jira/browse/JSPWIKI-386
> Project: JSPWiki
> Issue Type: Bug
> Components: Authentication&Authorization
> Affects Versions: 2.8
> Reporter: Peter Hormanns
> Priority: Minor
> Attachments: AuthenticationManager.java.patch
>
>
> I did some tests with JSPWiki and CAS authentication server from jsa-sig:http://www.ja-sig.org/products/cas/.
> I wrote and configured a login module class, but UserDatabaseLoginModule is allways used.
> I found an error in authenticationManager.java at line 374, see attached patch: variable "m_loginModuleClass" should be used, not constant class "UserDatabaseLoginModule.class"
> Is that correct?
> Best Regards,
> Peter Hormanns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-386) LoginModule Configuration fails
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen updated JSPWIKI-386:
-----------------------------------
Fix Version/s: 2.8
Assignee: Andrew Jaquith
I suggest 2.8, since it it seems that Dirk'll have lots of work with the JS updates anyway.
However, please refrain from large commits to the 2.8 :-)
> LoginModule Configuration fails
> -------------------------------
>
> Key: JSPWIKI-386
> URL: https://issues.apache.org/jira/browse/JSPWIKI-386
> Project: JSPWiki
> Issue Type: Bug
> Components: Authentication&Authorization
> Affects Versions: 2.8
> Reporter: Peter Hormanns
> Assignee: Andrew Jaquith
> Priority: Minor
> Fix For: 2.8
>
> Attachments: AuthenticationManager.java.patch
>
>
> I did some tests with JSPWiki and CAS authentication server from jsa-sig:http://www.ja-sig.org/products/cas/.
> I wrote and configured a login module class, but UserDatabaseLoginModule is allways used.
> I found an error in authenticationManager.java at line 374, see attached patch: variable "m_loginModuleClass" should be used, not constant class "UserDatabaseLoginModule.class"
> Is that correct?
> Best Regards,
> Peter Hormanns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JSPWIKI-386) LoginModule Configuration fails
Posted by "Peter Hormanns (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Hormanns updated JSPWIKI-386:
-----------------------------------
Attachment: AuthenticationManager.java.patch
> LoginModule Configuration fails
> -------------------------------
>
> Key: JSPWIKI-386
> URL: https://issues.apache.org/jira/browse/JSPWIKI-386
> Project: JSPWiki
> Issue Type: Bug
> Components: Authentication&Authorization
> Affects Versions: 2.8
> Reporter: Peter Hormanns
> Priority: Minor
> Attachments: AuthenticationManager.java.patch
>
>
> I did some tests with JSPWiki and CAS authentication server from jsa-sig:http://www.ja-sig.org/products/cas/.
> I wrote and configured a login module class, but UserDatabaseLoginModule is allways used.
> I found an error in authenticationManager.java at line 374, see attached patch: variable "m_loginModuleClass" should be used, not constant class "UserDatabaseLoginModule.class"
> Is that correct?
> Best Regards,
> Peter Hormanns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JSPWIKI-386) LoginModule Configuration fails
Posted by "Andrew Jaquith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635190#action_12635190 ]
Andrew Jaquith commented on JSPWIKI-386:
----------------------------------------
This patch looks valid. Peter, thanks for catching this. I'll add this in my next commit.
> LoginModule Configuration fails
> -------------------------------
>
> Key: JSPWIKI-386
> URL: https://issues.apache.org/jira/browse/JSPWIKI-386
> Project: JSPWiki
> Issue Type: Bug
> Components: Authentication&Authorization
> Affects Versions: 2.8
> Reporter: Peter Hormanns
> Priority: Minor
> Attachments: AuthenticationManager.java.patch
>
>
> I did some tests with JSPWiki and CAS authentication server from jsa-sig:http://www.ja-sig.org/products/cas/.
> I wrote and configured a login module class, but UserDatabaseLoginModule is allways used.
> I found an error in authenticationManager.java at line 374, see attached patch: variable "m_loginModuleClass" should be used, not constant class "UserDatabaseLoginModule.class"
> Is that correct?
> Best Regards,
> Peter Hormanns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JSPWIKI-386) LoginModule Configuration fails
Posted by "Andrew Jaquith (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Jaquith closed JSPWIKI-386.
----------------------------------
Resolution: Fixed
Fixed in 2.8.0-Beta-16. Patch applied as suggested.
> LoginModule Configuration fails
> -------------------------------
>
> Key: JSPWIKI-386
> URL: https://issues.apache.org/jira/browse/JSPWIKI-386
> Project: JSPWiki
> Issue Type: Bug
> Components: Authentication&Authorization
> Affects Versions: 2.8
> Reporter: Peter Hormanns
> Assignee: Andrew Jaquith
> Priority: Minor
> Fix For: 2.8
>
> Attachments: AuthenticationManager.java.patch
>
>
> I did some tests with JSPWiki and CAS authentication server from jsa-sig:http://www.ja-sig.org/products/cas/.
> I wrote and configured a login module class, but UserDatabaseLoginModule is allways used.
> I found an error in authenticationManager.java at line 374, see attached patch: variable "m_loginModuleClass" should be used, not constant class "UserDatabaseLoginModule.class"
> Is that correct?
> Best Regards,
> Peter Hormanns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.