[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4952: Enhance AWS Glue database does not exist error message on opening engine session

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4952:
URL: https://github.com/apache/kyuubi/pull/4952#discussion_r1227558583


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSessionImpl.scala:
##########
@@ -76,6 +76,11 @@ class SparkSessionImpl(
         case e
             if database == "default" &&
               StringUtils.containsAny(e.getMessage, "not found", "SCHEMA_NOT_FOUND") =>
+        case e
+            if database == "default" && StringUtils.containsAny(
+              e.getMessage,
+              "is not authorized to perform: glue:GetDatabase",
+              "database/default") =>

Review Comment:
   Maybe just
   ```suggestion
                 StringUtils.containsAny(
                   e.getMessage,
                   "not found",
                   "SCHEMA_NOT_FOUND",
                   "no identity-based policy allows the glue:GetDatabase action") =>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org