[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2564: Introduce Expr.variant_name() function

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #2564:
URL: https://github.com/apache/arrow-datafusion/pull/2564#discussion_r875270014


##########
datafusion/expr/src/expr.rs:
##########
@@ -294,6 +294,40 @@ impl Expr {
         create_name(self, input_schema)
     }
 
+    /// Return String representation of the variant represented by `self`
+    /// Useful for non-rust based bindings
+    pub fn variant_name(self) -> String {

Review Comment:
   It should be possible to return `&str` here instead of `String` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org