[GitHub] [camel] ppalaga commented on a diff in pull request #10441: init outputTimestamp

["ppalaga (via GitHub)" <gi...@apache.org>]

ppalaga commented on code in PR #10441:
URL: https://github.com/apache/camel/pull/10441#discussion_r1244343583


##########
pom.xml:
##########
@@ -117,7 +117,7 @@
         <minimalJavaBuildVersion>${jdk.version}</minimalJavaBuildVersion>
 
         <!-- reproduceable builds: https://maven.apache.org/guides/mini/guide-reproducible-builds.html -->
-        <project.build.outputTimestamp>1</project.build.outputTimestamp>
+        <project.build.outputTimestamp>1687211006</project.build.outputTimestamp>

Review Comment:
   @hboutemy thanks for coming around! I was struggling a bit with project.build.outputTimestamp last week, because some zip creating plugin (perhaps jar plugin) was complaining about a negative timestamp. That's why I changed it to the current value `1980-01-01T00:00:02Z` and that's why the current PR has conflicts. 
   
   Was that maybe also the reason why you have sent this PR?
   
   > Can you point to more details on this practice?
   
   I think https://maven.apache.org/guides/mini/guide-reproducible-builds.html is a nice quick resource about the topic of reproducible builds. (I guess it was written by you @hboutemy?) The part relevant for us is
   
   > Q. Can the project.build.outputTimestamp property in pom.xml be updated automatically at release time?
   > A. Yes.
   >
   > Details depend on your release process tooling:
   >
   > if you use [maven-release-plugin](https://maven.apache.org/plugins/maven-release-plugin/), you'll need version 3.0.0-M1 or later: it will automatically update the timestamp value in pom.xml during the release in the same commit that updates version,
   
   We happen to use an ancient version 2.4.2, there is a comment referring to https://issues.apache.org/jira/browse/MRELEASE-812 which is fixed since 9+ years, so we could perhaps upgrade, @gzurowski?
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org