You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/21 21:34:29 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #11808: [microTVM][RVM] Reuse QEMU installation config and fix bug in RVM testing
mehrdadh opened a new pull request, #11808:
URL: https://github.com/apache/tvm/pull/11808
cc @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11808: [microTVM][RVM] Reuse QEMU installation config and fix bug in RVM testing
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11808:
URL: https://github.com/apache/tvm/pull/11808#discussion_r903976386
##########
apps/microtvm/reference-vm/base-box-tool.py:
##########
@@ -360,6 +361,9 @@ def do_build_release_test_vm(
found_box_line = False
with open(release_test_vagrantfile, "w") as f:
for line in lines:
+ # Skip setting version
+ if "config.vm.box_version" in line:
Review Comment:
Why ignore the version here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #11808: [microTVM][RVM] Reuse QEMU installation config and fix bug in RVM testing
Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #11808:
URL: https://github.com/apache/tvm/pull/11808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11808: [microTVM][RVM] Reuse QEMU installation config and fix bug in RVM testing
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11808:
URL: https://github.com/apache/tvm/pull/11808#discussion_r904069314
##########
apps/microtvm/reference-vm/base-box-tool.py:
##########
@@ -360,6 +361,9 @@ def do_build_release_test_vm(
found_box_line = False
with open(release_test_vagrantfile, "w") as f:
for line in lines:
+ # Skip setting version
+ if "config.vm.box_version" in line:
Review Comment:
because version only used for released boxes, but we are testing this one locally
##########
apps/microtvm/reference-vm/base-box-tool.py:
##########
@@ -360,6 +361,9 @@ def do_build_release_test_vm(
found_box_line = False
with open(release_test_vagrantfile, "w") as f:
for line in lines:
+ # Skip setting version
+ if "config.vm.box_version" in line:
Review Comment:
because version only used for released boxes, but we are testing locally here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #11808: [microTVM][RVM] Reuse QEMU installation config and fix bug in RVM testing
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #11808:
URL: https://github.com/apache/tvm/pull/11808#issuecomment-1163430406
@driazati thanks for the review! Yeah I have tested it locally and we are also building the RVM nightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org