You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by da...@apache.org on 2006/10/12 16:39:46 UTC

svn commit: r463261 - /incubator/wicket/trunk/wicket/src/main/java/wicket/RequestCycle.java

Author: dashorst
Date: Thu Oct 12 07:39:45 2006
New Revision: 463261

URL: http://svn.apache.org/viewvc?view=rev&rev=463261
Log:
Fixed that exceptions during requestcycle detach cause uncomplete clean up by catching all exceptions

Modified:
    incubator/wicket/trunk/wicket/src/main/java/wicket/RequestCycle.java

Modified: incubator/wicket/trunk/wicket/src/main/java/wicket/RequestCycle.java
URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/RequestCycle.java?view=diff&rev=463261&r1=463260&r2=463261
==============================================================================
--- incubator/wicket/trunk/wicket/src/main/java/wicket/RequestCycle.java (original)
+++ incubator/wicket/trunk/wicket/src/main/java/wicket/RequestCycle.java Thu Oct 12 07:39:45 2006
@@ -842,9 +842,16 @@
 		}
 
 		// remove any rendered feedback messages from the session
-		session.cleanupFeedbackMessages();
-
-
+		try
+		{
+			session.cleanupFeedbackMessages();
+		}
+		catch (RuntimeException re)
+		{
+			log.error("there was an error cleaning up feedback messages for session " + session
+					+ ".", re);
+		}
+		
 		if (updateSession)
 		{
 			// At the end of our response, we need to set any session
@@ -862,8 +869,14 @@
 		// clear the used pagemap for this thread, 
 		// maybe we can move this a few lines above to have a but more
 		// concurrency (session.update)
-		session.requestDetached();
-		
+		try
+		{
+			session.requestDetached();
+		}
+		catch (RuntimeException re)
+		{
+			log.error("there was an error detaching request from session " + session + ".", re);
+		}
 
 		if (getResponse() instanceof BufferedWebResponse)
 		{