[jira] [Work logged] (HIVE-24827) Hive aggregation query returns incorrect results for non text files

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-24827?focusedWorklogId=559914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559914 ]

ASF GitHub Bot logged work on HIVE-24827:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Mar/21 12:14
            Start Date: 02/Mar/21 12:14
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #2018:
URL: https://github.com/apache/hive/pull/2018#discussion_r585508226



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -4028,6 +4030,8 @@ public static int getFooterCount(TableDesc table, JobConf job) throws IOExceptio
     int footerCount;
     try {
       footerCount = Integer.parseInt(table.getProperties().getProperty(serdeConstants.FOOTER_COUNT, "0"));
+      footerCount =
+          validateHeaderFooter(table, footerCount, "skip.footer.line.count");

Review comment:
       since `FOOTER_COUNT = "skip.footer.line.count"` ; I think you could also push in this `Integer.parseInt` into you method as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 559914)
    Time Spent: 40m  (was: 0.5h)

> Hive aggregation query returns incorrect results for non text files
> -------------------------------------------------------------------
>
>                 Key: HIVE-24827
>                 URL: https://issues.apache.org/jira/browse/HIVE-24827
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When header & footer are configured for non-text files, the aggregation query returns wrong result.
> Propose to ignore this property for non-text files



--
This message was sent by Atlassian Jira
(v8.3.4#803005)