You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2023/05/30 11:47:07 UTC
[PR] Avoid leaving partial archive in case of errors. (celix)
PengZheng opened a new pull request, #564:
URL: https://github.com/apache/celix/pull/564
This PR is another step towards solving #556:
* Residual archive directory is removed in case of errors.
* A minor logging error is fixed.
* More tests are added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid leaving partial archive in case of errors. (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #564:
URL: https://github.com/apache/celix/pull/564#issuecomment-1568336713
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/564?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#564](https://app.codecov.io/gh/apache/celix/pull/564?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3842b6e) into [master](https://app.codecov.io/gh/apache/celix/commit/cd5a44cfc082d8972e9fc00786f4a103a4cfd790?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cd5a44c) will **increase** coverage by `0.19%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
+ Coverage 77.83% 78.02% +0.19%
==========================================
Files 230 230
Lines 35031 35012 -19
==========================================
+ Hits 27267 27319 +52
+ Misses 7764 7693 -71
```
| [Impacted Files](https://app.codecov.io/gh/apache/celix/pull/564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libs/framework/src/bundle\_archive.c](https://app.codecov.io/gh/apache/celix/pull/564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9mcmFtZXdvcmsvc3JjL2J1bmRsZV9hcmNoaXZlLmM=) | `96.47% <100.00%> (+23.19%)` | :arrow_up: |
| [libs/framework/src/bundle\_revision.c](https://app.codecov.io/gh/apache/celix/pull/564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9mcmFtZXdvcmsvc3JjL2J1bmRsZV9yZXZpc2lvbi5j) | `72.91% <100.00%> (+11.21%)` | :arrow_up: |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/564/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Avoid leaving partial archive in case of errors. (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng merged PR #564:
URL: https://github.com/apache/celix/pull/564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org