You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/09/22 14:51:07 UTC
[04/43] hbase-site git commit: Published site at
7ab77518a2569e2416a50020393aa386e7734501.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/bbe517ae/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestRowPrefixBloomFilter.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestRowPrefixBloomFilter.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestRowPrefixBloomFilter.html
new file mode 100644
index 0000000..1888d75
--- /dev/null
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestRowPrefixBloomFilter.html
@@ -0,0 +1,471 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+<html lang="en">
+<head>
+<title>Source code</title>
+<link rel="stylesheet" type="text/css" href="../../../../../../stylesheet.css" title="Style">
+</head>
+<body>
+<div class="sourceContainer">
+<pre><span class="sourceLineNo">001</span>/**<a name="line.1"></a>
+<span class="sourceLineNo">002</span> * Licensed to the Apache Software Foundation (ASF) under one<a name="line.2"></a>
+<span class="sourceLineNo">003</span> * or more contributor license agreements. See the NOTICE file<a name="line.3"></a>
+<span class="sourceLineNo">004</span> * distributed with this work for additional information<a name="line.4"></a>
+<span class="sourceLineNo">005</span> * regarding copyright ownership. The ASF licenses this file<a name="line.5"></a>
+<span class="sourceLineNo">006</span> * to you under the Apache License, Version 2.0 (the<a name="line.6"></a>
+<span class="sourceLineNo">007</span> * "License"); you may not use this file except in compliance<a name="line.7"></a>
+<span class="sourceLineNo">008</span> * with the License. You may obtain a copy of the License at<a name="line.8"></a>
+<span class="sourceLineNo">009</span> *<a name="line.9"></a>
+<span class="sourceLineNo">010</span> * http://www.apache.org/licenses/LICENSE-2.0<a name="line.10"></a>
+<span class="sourceLineNo">011</span> *<a name="line.11"></a>
+<span class="sourceLineNo">012</span> * Unless required by applicable law or agreed to in writing, software<a name="line.12"></a>
+<span class="sourceLineNo">013</span> * distributed under the License is distributed on an "AS IS" BASIS,<a name="line.13"></a>
+<span class="sourceLineNo">014</span> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.<a name="line.14"></a>
+<span class="sourceLineNo">015</span> * See the License for the specific language governing permissions and<a name="line.15"></a>
+<span class="sourceLineNo">016</span> * limitations under the License.<a name="line.16"></a>
+<span class="sourceLineNo">017</span> */<a name="line.17"></a>
+<span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.regionserver;<a name="line.18"></a>
+<span class="sourceLineNo">019</span><a name="line.19"></a>
+<span class="sourceLineNo">020</span>import static org.junit.Assert.assertEquals;<a name="line.20"></a>
+<span class="sourceLineNo">021</span>import static org.junit.Assert.assertFalse;<a name="line.21"></a>
+<span class="sourceLineNo">022</span>import static org.junit.Assert.assertTrue;<a name="line.22"></a>
+<span class="sourceLineNo">023</span>import static org.mockito.Mockito.mock;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import static org.mockito.Mockito.when;<a name="line.24"></a>
+<span class="sourceLineNo">025</span><a name="line.25"></a>
+<span class="sourceLineNo">026</span>import java.io.IOException;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import java.util.concurrent.atomic.AtomicInteger;<a name="line.27"></a>
+<span class="sourceLineNo">028</span><a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.conf.Configuration;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.fs.FileSystem;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.fs.Path;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.KeyValue;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.client.Get;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.client.Scan;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.io.hfile.CacheConfig;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.io.hfile.HFileContext;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.io.hfile.HFileContextBuilder;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.log.HBaseMarkers;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.util.BloomFilterFactory;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.util.BloomFilterUtil;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.util.ChecksumType;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.util.FSUtils;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.junit.After;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.junit.Before;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.ClassRule;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.junit.Rule;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.junit.Test;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.junit.experimental.categories.Category;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.junit.rules.TestName;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.slf4j.Logger;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.slf4j.LoggerFactory;<a name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span>/**<a name="line.59"></a>
+<span class="sourceLineNo">060</span> * Test TestRowPrefixBloomFilter<a name="line.60"></a>
+<span class="sourceLineNo">061</span> */<a name="line.61"></a>
+<span class="sourceLineNo">062</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.62"></a>
+<span class="sourceLineNo">063</span>public class TestRowPrefixBloomFilter {<a name="line.63"></a>
+<span class="sourceLineNo">064</span><a name="line.64"></a>
+<span class="sourceLineNo">065</span> @ClassRule<a name="line.65"></a>
+<span class="sourceLineNo">066</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.66"></a>
+<span class="sourceLineNo">067</span> HBaseClassTestRule.forClass(TestRowPrefixBloomFilter.class);<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span> private static final Logger LOG = LoggerFactory.getLogger(TestRowPrefixBloomFilter.class);<a name="line.69"></a>
+<span class="sourceLineNo">070</span> private static final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.70"></a>
+<span class="sourceLineNo">071</span> private CacheConfig cacheConf = new CacheConfig(TEST_UTIL.getConfiguration());<a name="line.71"></a>
+<span class="sourceLineNo">072</span> private static final ChecksumType CKTYPE = ChecksumType.CRC32C;<a name="line.72"></a>
+<span class="sourceLineNo">073</span> private static final int CKBYTES = 512;<a name="line.73"></a>
+<span class="sourceLineNo">074</span> private boolean localfs = false;<a name="line.74"></a>
+<span class="sourceLineNo">075</span> private static Configuration conf;<a name="line.75"></a>
+<span class="sourceLineNo">076</span> private static FileSystem fs;<a name="line.76"></a>
+<span class="sourceLineNo">077</span> private static Path testDir;<a name="line.77"></a>
+<span class="sourceLineNo">078</span> private static final int BLOCKSIZE_SMALL = 8192;<a name="line.78"></a>
+<span class="sourceLineNo">079</span> private static final float err = (float) 0.01;<a name="line.79"></a>
+<span class="sourceLineNo">080</span> private static final int prefixLength = 10;<a name="line.80"></a>
+<span class="sourceLineNo">081</span> private static final String delimiter = "#";<a name="line.81"></a>
+<span class="sourceLineNo">082</span> private static final String invalidFormatter = "%08d";<a name="line.82"></a>
+<span class="sourceLineNo">083</span> private static final String prefixFormatter = "%010d";<a name="line.83"></a>
+<span class="sourceLineNo">084</span> private static final String suffixFormatter = "%010d";<a name="line.84"></a>
+<span class="sourceLineNo">085</span><a name="line.85"></a>
+<span class="sourceLineNo">086</span> @Rule<a name="line.86"></a>
+<span class="sourceLineNo">087</span> public TestName name = new TestName();<a name="line.87"></a>
+<span class="sourceLineNo">088</span><a name="line.88"></a>
+<span class="sourceLineNo">089</span> @Before<a name="line.89"></a>
+<span class="sourceLineNo">090</span> public void setUp() throws Exception {<a name="line.90"></a>
+<span class="sourceLineNo">091</span> conf = TEST_UTIL.getConfiguration();<a name="line.91"></a>
+<span class="sourceLineNo">092</span> conf.setFloat(BloomFilterFactory.IO_STOREFILE_BLOOM_ERROR_RATE, err);<a name="line.92"></a>
+<span class="sourceLineNo">093</span> conf.setBoolean(BloomFilterFactory.IO_STOREFILE_BLOOM_ENABLED, true);<a name="line.93"></a>
+<span class="sourceLineNo">094</span> conf.setInt(BloomFilterUtil.PREFIX_LENGTH_KEY, prefixLength);<a name="line.94"></a>
+<span class="sourceLineNo">095</span> conf.set(BloomFilterUtil.DELIMITER_KEY, delimiter);<a name="line.95"></a>
+<span class="sourceLineNo">096</span><a name="line.96"></a>
+<span class="sourceLineNo">097</span> localfs =<a name="line.97"></a>
+<span class="sourceLineNo">098</span> (conf.get("fs.defaultFS", "file:///").compareTo("file:///") == 0);<a name="line.98"></a>
+<span class="sourceLineNo">099</span><a name="line.99"></a>
+<span class="sourceLineNo">100</span> if (fs == null) {<a name="line.100"></a>
+<span class="sourceLineNo">101</span> fs = FileSystem.get(conf);<a name="line.101"></a>
+<span class="sourceLineNo">102</span> }<a name="line.102"></a>
+<span class="sourceLineNo">103</span> try {<a name="line.103"></a>
+<span class="sourceLineNo">104</span> if (localfs) {<a name="line.104"></a>
+<span class="sourceLineNo">105</span> testDir = TEST_UTIL.getDataTestDir("TestRowPrefixBloomFilter");<a name="line.105"></a>
+<span class="sourceLineNo">106</span> if (fs.exists(testDir)) {<a name="line.106"></a>
+<span class="sourceLineNo">107</span> fs.delete(testDir, true);<a name="line.107"></a>
+<span class="sourceLineNo">108</span> }<a name="line.108"></a>
+<span class="sourceLineNo">109</span> } else {<a name="line.109"></a>
+<span class="sourceLineNo">110</span> testDir = FSUtils.getRootDir(conf);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> }<a name="line.111"></a>
+<span class="sourceLineNo">112</span> } catch (Exception e) {<a name="line.112"></a>
+<span class="sourceLineNo">113</span> LOG.error(HBaseMarkers.FATAL, "error during setup", e);<a name="line.113"></a>
+<span class="sourceLineNo">114</span> throw e;<a name="line.114"></a>
+<span class="sourceLineNo">115</span> }<a name="line.115"></a>
+<span class="sourceLineNo">116</span> }<a name="line.116"></a>
+<span class="sourceLineNo">117</span><a name="line.117"></a>
+<span class="sourceLineNo">118</span> @After<a name="line.118"></a>
+<span class="sourceLineNo">119</span> public void tearDown() throws Exception {<a name="line.119"></a>
+<span class="sourceLineNo">120</span> try {<a name="line.120"></a>
+<span class="sourceLineNo">121</span> if (localfs) {<a name="line.121"></a>
+<span class="sourceLineNo">122</span> if (fs.exists(testDir)) {<a name="line.122"></a>
+<span class="sourceLineNo">123</span> fs.delete(testDir, true);<a name="line.123"></a>
+<span class="sourceLineNo">124</span> }<a name="line.124"></a>
+<span class="sourceLineNo">125</span> }<a name="line.125"></a>
+<span class="sourceLineNo">126</span> } catch (Exception e) {<a name="line.126"></a>
+<span class="sourceLineNo">127</span> LOG.error(HBaseMarkers.FATAL, "error during tear down", e);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> }<a name="line.128"></a>
+<span class="sourceLineNo">129</span> }<a name="line.129"></a>
+<span class="sourceLineNo">130</span><a name="line.130"></a>
+<span class="sourceLineNo">131</span> private static StoreFileScanner getStoreFileScanner(StoreFileReader reader) {<a name="line.131"></a>
+<span class="sourceLineNo">132</span> return reader.getStoreFileScanner(false, false, false, 0, 0, false);<a name="line.132"></a>
+<span class="sourceLineNo">133</span> }<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span> private void writeStoreFile(final Path f, BloomType bt, int expKeys, int prefixRowCount,<a name="line.135"></a>
+<span class="sourceLineNo">136</span> int suffixRowCount) throws IOException {<a name="line.136"></a>
+<span class="sourceLineNo">137</span> HFileContext meta = new HFileContextBuilder()<a name="line.137"></a>
+<span class="sourceLineNo">138</span> .withBlockSize(BLOCKSIZE_SMALL)<a name="line.138"></a>
+<span class="sourceLineNo">139</span> .withChecksumType(CKTYPE)<a name="line.139"></a>
+<span class="sourceLineNo">140</span> .withBytesPerCheckSum(CKBYTES)<a name="line.140"></a>
+<span class="sourceLineNo">141</span> .build();<a name="line.141"></a>
+<span class="sourceLineNo">142</span> // Make a store file and write data to it.<a name="line.142"></a>
+<span class="sourceLineNo">143</span> StoreFileWriter writer = new StoreFileWriter.Builder(conf, cacheConf, fs)<a name="line.143"></a>
+<span class="sourceLineNo">144</span> .withFilePath(f)<a name="line.144"></a>
+<span class="sourceLineNo">145</span> .withBloomType(bt)<a name="line.145"></a>
+<span class="sourceLineNo">146</span> .withMaxKeyCount(expKeys)<a name="line.146"></a>
+<span class="sourceLineNo">147</span> .withFileContext(meta)<a name="line.147"></a>
+<span class="sourceLineNo">148</span> .build();<a name="line.148"></a>
+<span class="sourceLineNo">149</span> long now = System.currentTimeMillis();<a name="line.149"></a>
+<span class="sourceLineNo">150</span> try {<a name="line.150"></a>
+<span class="sourceLineNo">151</span> //Put with valid row style<a name="line.151"></a>
+<span class="sourceLineNo">152</span> for (int i = 0; i < prefixRowCount; i += 2) { // prefix rows<a name="line.152"></a>
+<span class="sourceLineNo">153</span> String prefixRow = String.format(prefixFormatter, i);<a name="line.153"></a>
+<span class="sourceLineNo">154</span> for (int j = 0; j < suffixRowCount; j++) { // suffix rows<a name="line.154"></a>
+<span class="sourceLineNo">155</span> String row = prefixRow + "#" + String.format(suffixFormatter, j);<a name="line.155"></a>
+<span class="sourceLineNo">156</span> KeyValue kv = new KeyValue(Bytes.toBytes(row), Bytes.toBytes("family"),<a name="line.156"></a>
+<span class="sourceLineNo">157</span> Bytes.toBytes("col"), now, Bytes.toBytes("value"));<a name="line.157"></a>
+<span class="sourceLineNo">158</span> writer.append(kv);<a name="line.158"></a>
+<span class="sourceLineNo">159</span> }<a name="line.159"></a>
+<span class="sourceLineNo">160</span> }<a name="line.160"></a>
+<span class="sourceLineNo">161</span><a name="line.161"></a>
+<span class="sourceLineNo">162</span> //Put with invalid row style<a name="line.162"></a>
+<span class="sourceLineNo">163</span> for (int i = prefixRowCount; i < prefixRowCount*2; i += 2) { // prefix rows<a name="line.163"></a>
+<span class="sourceLineNo">164</span> String row = String.format(invalidFormatter, i);<a name="line.164"></a>
+<span class="sourceLineNo">165</span> KeyValue kv = new KeyValue(Bytes.toBytes(row), Bytes.toBytes("family"),<a name="line.165"></a>
+<span class="sourceLineNo">166</span> Bytes.toBytes("col"), now, Bytes.toBytes("value"));<a name="line.166"></a>
+<span class="sourceLineNo">167</span> writer.append(kv);<a name="line.167"></a>
+<span class="sourceLineNo">168</span> }<a name="line.168"></a>
+<span class="sourceLineNo">169</span> } finally {<a name="line.169"></a>
+<span class="sourceLineNo">170</span> writer.close();<a name="line.170"></a>
+<span class="sourceLineNo">171</span> }<a name="line.171"></a>
+<span class="sourceLineNo">172</span> }<a name="line.172"></a>
+<span class="sourceLineNo">173</span><a name="line.173"></a>
+<span class="sourceLineNo">174</span> @Test<a name="line.174"></a>
+<span class="sourceLineNo">175</span> public void testRowPrefixBloomFilter() throws Exception {<a name="line.175"></a>
+<span class="sourceLineNo">176</span> FileSystem fs = FileSystem.getLocal(conf);<a name="line.176"></a>
+<span class="sourceLineNo">177</span> BloomType[] bt = {BloomType.ROWPREFIX_FIXED_LENGTH, BloomType.ROWPREFIX_DELIMITED};<a name="line.177"></a>
+<span class="sourceLineNo">178</span> int prefixRowCount = 50;<a name="line.178"></a>
+<span class="sourceLineNo">179</span> int suffixRowCount = 10;<a name="line.179"></a>
+<span class="sourceLineNo">180</span> int expKeys = 50;<a name="line.180"></a>
+<span class="sourceLineNo">181</span> float expErr = 2*prefixRowCount*suffixRowCount*err;<a name="line.181"></a>
+<span class="sourceLineNo">182</span> for (int x : new int[]{0,1}) {<a name="line.182"></a>
+<span class="sourceLineNo">183</span> // write the file<a name="line.183"></a>
+<span class="sourceLineNo">184</span> Path f = new Path(testDir, name.getMethodName());<a name="line.184"></a>
+<span class="sourceLineNo">185</span> writeStoreFile(f, bt[x], expKeys, prefixRowCount, suffixRowCount);<a name="line.185"></a>
+<span class="sourceLineNo">186</span><a name="line.186"></a>
+<span class="sourceLineNo">187</span> // read the file<a name="line.187"></a>
+<span class="sourceLineNo">188</span> StoreFileReader reader = new StoreFileReader(fs, f, cacheConf, true,<a name="line.188"></a>
+<span class="sourceLineNo">189</span> new AtomicInteger(0), true, conf);<a name="line.189"></a>
+<span class="sourceLineNo">190</span> reader.loadFileInfo();<a name="line.190"></a>
+<span class="sourceLineNo">191</span> reader.loadBloomfilter();<a name="line.191"></a>
+<span class="sourceLineNo">192</span><a name="line.192"></a>
+<span class="sourceLineNo">193</span> //check basic param<a name="line.193"></a>
+<span class="sourceLineNo">194</span> assertEquals(bt[x], reader.getBloomFilterType());<a name="line.194"></a>
+<span class="sourceLineNo">195</span> if (bt[x] == BloomType.ROWPREFIX_FIXED_LENGTH) {<a name="line.195"></a>
+<span class="sourceLineNo">196</span> assertEquals(prefixLength, reader.getPrefixLength());<a name="line.196"></a>
+<span class="sourceLineNo">197</span> assertEquals("null", Bytes.toStringBinary(reader.getDelimiter()));<a name="line.197"></a>
+<span class="sourceLineNo">198</span> } else if (bt[x] == BloomType.ROWPREFIX_DELIMITED){<a name="line.198"></a>
+<span class="sourceLineNo">199</span> assertEquals(-1, reader.getPrefixLength());<a name="line.199"></a>
+<span class="sourceLineNo">200</span> assertEquals(delimiter, Bytes.toStringBinary(reader.getDelimiter()));<a name="line.200"></a>
+<span class="sourceLineNo">201</span> }<a name="line.201"></a>
+<span class="sourceLineNo">202</span> assertEquals(expKeys, reader.getGeneralBloomFilter().getKeyCount());<a name="line.202"></a>
+<span class="sourceLineNo">203</span> StoreFileScanner scanner = getStoreFileScanner(reader);<a name="line.203"></a>
+<span class="sourceLineNo">204</span> HStore store = mock(HStore.class);<a name="line.204"></a>
+<span class="sourceLineNo">205</span> when(store.getColumnFamilyDescriptor())<a name="line.205"></a>
+<span class="sourceLineNo">206</span> .thenReturn(ColumnFamilyDescriptorBuilder.of("family"));<a name="line.206"></a>
+<span class="sourceLineNo">207</span> // check false positives rate<a name="line.207"></a>
+<span class="sourceLineNo">208</span> int falsePos = 0;<a name="line.208"></a>
+<span class="sourceLineNo">209</span> int falseNeg = 0;<a name="line.209"></a>
+<span class="sourceLineNo">210</span> for (int i = 0; i < prefixRowCount; i++) { // prefix rows<a name="line.210"></a>
+<span class="sourceLineNo">211</span> String prefixRow = String.format(prefixFormatter, i);<a name="line.211"></a>
+<span class="sourceLineNo">212</span> for (int j = 0; j < suffixRowCount; j++) { // suffix rows<a name="line.212"></a>
+<span class="sourceLineNo">213</span> String startRow = prefixRow + "#" + String.format(suffixFormatter, j);<a name="line.213"></a>
+<span class="sourceLineNo">214</span> String stopRow = prefixRow + "#" + String.format(suffixFormatter, j+1);<a name="line.214"></a>
+<span class="sourceLineNo">215</span> Scan scan = new Scan().withStartRow(Bytes.toBytes(startRow))<a name="line.215"></a>
+<span class="sourceLineNo">216</span> .withStopRow(Bytes.toBytes(stopRow));<a name="line.216"></a>
+<span class="sourceLineNo">217</span> boolean exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.217"></a>
+<span class="sourceLineNo">218</span> boolean shouldPrefixRowExist = i % 2 == 0;<a name="line.218"></a>
+<span class="sourceLineNo">219</span> if (shouldPrefixRowExist) {<a name="line.219"></a>
+<span class="sourceLineNo">220</span> if (!exists) {<a name="line.220"></a>
+<span class="sourceLineNo">221</span> falseNeg++;<a name="line.221"></a>
+<span class="sourceLineNo">222</span> }<a name="line.222"></a>
+<span class="sourceLineNo">223</span> } else {<a name="line.223"></a>
+<span class="sourceLineNo">224</span> if (exists) {<a name="line.224"></a>
+<span class="sourceLineNo">225</span> falsePos++;<a name="line.225"></a>
+<span class="sourceLineNo">226</span> }<a name="line.226"></a>
+<span class="sourceLineNo">227</span> }<a name="line.227"></a>
+<span class="sourceLineNo">228</span> }<a name="line.228"></a>
+<span class="sourceLineNo">229</span> }<a name="line.229"></a>
+<span class="sourceLineNo">230</span><a name="line.230"></a>
+<span class="sourceLineNo">231</span> for (int i = prefixRowCount; i < prefixRowCount * 2; i++) { // prefix rows<a name="line.231"></a>
+<span class="sourceLineNo">232</span> String row = String.format(invalidFormatter, i);<a name="line.232"></a>
+<span class="sourceLineNo">233</span> Scan scan = new Scan(new Get(Bytes.toBytes(row)));<a name="line.233"></a>
+<span class="sourceLineNo">234</span> boolean exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.234"></a>
+<span class="sourceLineNo">235</span> boolean shouldPrefixRowExist = i % 2 == 0;<a name="line.235"></a>
+<span class="sourceLineNo">236</span> if (shouldPrefixRowExist) {<a name="line.236"></a>
+<span class="sourceLineNo">237</span> if (!exists) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span> falseNeg++;<a name="line.238"></a>
+<span class="sourceLineNo">239</span> }<a name="line.239"></a>
+<span class="sourceLineNo">240</span> } else {<a name="line.240"></a>
+<span class="sourceLineNo">241</span> if (exists) {<a name="line.241"></a>
+<span class="sourceLineNo">242</span> falsePos++;<a name="line.242"></a>
+<span class="sourceLineNo">243</span> }<a name="line.243"></a>
+<span class="sourceLineNo">244</span> }<a name="line.244"></a>
+<span class="sourceLineNo">245</span> }<a name="line.245"></a>
+<span class="sourceLineNo">246</span> reader.close(true); // evict because we are about to delete the file<a name="line.246"></a>
+<span class="sourceLineNo">247</span> fs.delete(f, true);<a name="line.247"></a>
+<span class="sourceLineNo">248</span> assertEquals("False negatives: " + falseNeg, 0, falseNeg);<a name="line.248"></a>
+<span class="sourceLineNo">249</span> int maxFalsePos = (int) (2 * expErr);<a name="line.249"></a>
+<span class="sourceLineNo">250</span> assertTrue("Too many false positives: " + falsePos<a name="line.250"></a>
+<span class="sourceLineNo">251</span> + " (err=" + err + ", expected no more than " + maxFalsePos + ")",<a name="line.251"></a>
+<span class="sourceLineNo">252</span> falsePos <= maxFalsePos);<a name="line.252"></a>
+<span class="sourceLineNo">253</span> }<a name="line.253"></a>
+<span class="sourceLineNo">254</span> }<a name="line.254"></a>
+<span class="sourceLineNo">255</span><a name="line.255"></a>
+<span class="sourceLineNo">256</span> @Test<a name="line.256"></a>
+<span class="sourceLineNo">257</span> public void testRowPrefixBloomFilterWithGet() throws Exception {<a name="line.257"></a>
+<span class="sourceLineNo">258</span> FileSystem fs = FileSystem.getLocal(conf);<a name="line.258"></a>
+<span class="sourceLineNo">259</span> BloomType[] bt = {BloomType.ROWPREFIX_FIXED_LENGTH, BloomType.ROWPREFIX_DELIMITED};<a name="line.259"></a>
+<span class="sourceLineNo">260</span> int prefixRowCount = 50;<a name="line.260"></a>
+<span class="sourceLineNo">261</span> int suffixRowCount = 10;<a name="line.261"></a>
+<span class="sourceLineNo">262</span> int expKeys = 50;<a name="line.262"></a>
+<span class="sourceLineNo">263</span> for (int x : new int[]{0,1}) {<a name="line.263"></a>
+<span class="sourceLineNo">264</span> // write the file<a name="line.264"></a>
+<span class="sourceLineNo">265</span> Path f = new Path(testDir, name.getMethodName());<a name="line.265"></a>
+<span class="sourceLineNo">266</span> writeStoreFile(f, bt[x], expKeys, prefixRowCount, suffixRowCount);<a name="line.266"></a>
+<span class="sourceLineNo">267</span><a name="line.267"></a>
+<span class="sourceLineNo">268</span> StoreFileReader reader = new StoreFileReader(fs, f, cacheConf, true,<a name="line.268"></a>
+<span class="sourceLineNo">269</span> new AtomicInteger(0), true, conf);<a name="line.269"></a>
+<span class="sourceLineNo">270</span> reader.loadFileInfo();<a name="line.270"></a>
+<span class="sourceLineNo">271</span> reader.loadBloomfilter();<a name="line.271"></a>
+<span class="sourceLineNo">272</span><a name="line.272"></a>
+<span class="sourceLineNo">273</span> StoreFileScanner scanner = getStoreFileScanner(reader);<a name="line.273"></a>
+<span class="sourceLineNo">274</span> HStore store = mock(HStore.class);<a name="line.274"></a>
+<span class="sourceLineNo">275</span> when(store.getColumnFamilyDescriptor())<a name="line.275"></a>
+<span class="sourceLineNo">276</span> .thenReturn(ColumnFamilyDescriptorBuilder.of("family"));<a name="line.276"></a>
+<span class="sourceLineNo">277</span><a name="line.277"></a>
+<span class="sourceLineNo">278</span> //Get with valid row style<a name="line.278"></a>
+<span class="sourceLineNo">279</span> //prefix row in bloom<a name="line.279"></a>
+<span class="sourceLineNo">280</span> String prefixRow = String.format(prefixFormatter, prefixRowCount-2);<a name="line.280"></a>
+<span class="sourceLineNo">281</span> String row = prefixRow + "#" + String.format(suffixFormatter, 0);<a name="line.281"></a>
+<span class="sourceLineNo">282</span> Scan scan = new Scan(new Get(Bytes.toBytes(row)));<a name="line.282"></a>
+<span class="sourceLineNo">283</span> boolean exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> assertTrue(exists);<a name="line.284"></a>
+<span class="sourceLineNo">285</span><a name="line.285"></a>
+<span class="sourceLineNo">286</span> // prefix row not in bloom<a name="line.286"></a>
+<span class="sourceLineNo">287</span> prefixRow = String.format(prefixFormatter, prefixRowCount-1);<a name="line.287"></a>
+<span class="sourceLineNo">288</span> row = prefixRow + "#" + String.format(suffixFormatter, 0);<a name="line.288"></a>
+<span class="sourceLineNo">289</span> scan = new Scan(new Get(Bytes.toBytes(row)));<a name="line.289"></a>
+<span class="sourceLineNo">290</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.290"></a>
+<span class="sourceLineNo">291</span> assertFalse(exists);<a name="line.291"></a>
+<span class="sourceLineNo">292</span><a name="line.292"></a>
+<span class="sourceLineNo">293</span> // Get with invalid row style<a name="line.293"></a>
+<span class="sourceLineNo">294</span> // ROWPREFIX: the length of row is less than prefixLength<a name="line.294"></a>
+<span class="sourceLineNo">295</span> // ROWPREFIX_DELIMITED: Row does not contain delimiter<a name="line.295"></a>
+<span class="sourceLineNo">296</span> // row in bloom<a name="line.296"></a>
+<span class="sourceLineNo">297</span> row = String.format(invalidFormatter, prefixRowCount+2);<a name="line.297"></a>
+<span class="sourceLineNo">298</span> scan = new Scan(new Get(Bytes.toBytes(row)));<a name="line.298"></a>
+<span class="sourceLineNo">299</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.299"></a>
+<span class="sourceLineNo">300</span> assertTrue(exists);<a name="line.300"></a>
+<span class="sourceLineNo">301</span><a name="line.301"></a>
+<span class="sourceLineNo">302</span> // row not in bloom<a name="line.302"></a>
+<span class="sourceLineNo">303</span> row = String.format(invalidFormatter, prefixRowCount+1);<a name="line.303"></a>
+<span class="sourceLineNo">304</span> scan = new Scan(new Get(Bytes.toBytes(row)));<a name="line.304"></a>
+<span class="sourceLineNo">305</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.305"></a>
+<span class="sourceLineNo">306</span> assertFalse(exists);<a name="line.306"></a>
+<span class="sourceLineNo">307</span><a name="line.307"></a>
+<span class="sourceLineNo">308</span> reader.close(true); // evict because we are about to delete the file<a name="line.308"></a>
+<span class="sourceLineNo">309</span> fs.delete(f, true);<a name="line.309"></a>
+<span class="sourceLineNo">310</span> }<a name="line.310"></a>
+<span class="sourceLineNo">311</span> }<a name="line.311"></a>
+<span class="sourceLineNo">312</span><a name="line.312"></a>
+<span class="sourceLineNo">313</span> @Test<a name="line.313"></a>
+<span class="sourceLineNo">314</span> public void testRowPrefixBloomFilterWithScan() throws Exception {<a name="line.314"></a>
+<span class="sourceLineNo">315</span> FileSystem fs = FileSystem.getLocal(conf);<a name="line.315"></a>
+<span class="sourceLineNo">316</span> BloomType[] bt = {BloomType.ROWPREFIX_FIXED_LENGTH, BloomType.ROWPREFIX_DELIMITED};<a name="line.316"></a>
+<span class="sourceLineNo">317</span> int prefixRowCount = 50;<a name="line.317"></a>
+<span class="sourceLineNo">318</span> int suffixRowCount = 10;<a name="line.318"></a>
+<span class="sourceLineNo">319</span> int expKeys = 50;<a name="line.319"></a>
+<span class="sourceLineNo">320</span> for (int x : new int[]{0,1}) {<a name="line.320"></a>
+<span class="sourceLineNo">321</span> // write the file<a name="line.321"></a>
+<span class="sourceLineNo">322</span> Path f = new Path(testDir, name.getMethodName());<a name="line.322"></a>
+<span class="sourceLineNo">323</span> writeStoreFile(f, bt[x], expKeys, prefixRowCount, suffixRowCount);<a name="line.323"></a>
+<span class="sourceLineNo">324</span><a name="line.324"></a>
+<span class="sourceLineNo">325</span> StoreFileReader reader = new StoreFileReader(fs, f, cacheConf, true,<a name="line.325"></a>
+<span class="sourceLineNo">326</span> new AtomicInteger(0), true, conf);<a name="line.326"></a>
+<span class="sourceLineNo">327</span> reader.loadFileInfo();<a name="line.327"></a>
+<span class="sourceLineNo">328</span> reader.loadBloomfilter();<a name="line.328"></a>
+<span class="sourceLineNo">329</span><a name="line.329"></a>
+<span class="sourceLineNo">330</span> StoreFileScanner scanner = getStoreFileScanner(reader);<a name="line.330"></a>
+<span class="sourceLineNo">331</span> HStore store = mock(HStore.class);<a name="line.331"></a>
+<span class="sourceLineNo">332</span> when(store.getColumnFamilyDescriptor())<a name="line.332"></a>
+<span class="sourceLineNo">333</span> .thenReturn(ColumnFamilyDescriptorBuilder.of("family"));<a name="line.333"></a>
+<span class="sourceLineNo">334</span><a name="line.334"></a>
+<span class="sourceLineNo">335</span> //Scan with valid row style. startRow and stopRow have a common prefix.<a name="line.335"></a>
+<span class="sourceLineNo">336</span> //And the length of the common prefix is no less than prefixLength.<a name="line.336"></a>
+<span class="sourceLineNo">337</span> //prefix row in bloom<a name="line.337"></a>
+<span class="sourceLineNo">338</span> String prefixRow = String.format(prefixFormatter, prefixRowCount-2);<a name="line.338"></a>
+<span class="sourceLineNo">339</span> String startRow = prefixRow + "#" + String.format(suffixFormatter, 0);<a name="line.339"></a>
+<span class="sourceLineNo">340</span> String stopRow = prefixRow + "#" + String.format(suffixFormatter, 1);<a name="line.340"></a>
+<span class="sourceLineNo">341</span> Scan scan = new Scan().withStartRow(Bytes.toBytes(startRow))<a name="line.341"></a>
+<span class="sourceLineNo">342</span> .withStopRow(Bytes.toBytes(stopRow));<a name="line.342"></a>
+<span class="sourceLineNo">343</span> boolean exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.343"></a>
+<span class="sourceLineNo">344</span> assertTrue(exists);<a name="line.344"></a>
+<span class="sourceLineNo">345</span><a name="line.345"></a>
+<span class="sourceLineNo">346</span> // prefix row not in bloom<a name="line.346"></a>
+<span class="sourceLineNo">347</span> prefixRow = String.format(prefixFormatter, prefixRowCount-1);<a name="line.347"></a>
+<span class="sourceLineNo">348</span> startRow = prefixRow + "#" + String.format(suffixFormatter, 0);<a name="line.348"></a>
+<span class="sourceLineNo">349</span> stopRow = prefixRow + "#" + String.format(suffixFormatter, 1);<a name="line.349"></a>
+<span class="sourceLineNo">350</span> scan = new Scan().withStartRow(Bytes.toBytes(startRow))<a name="line.350"></a>
+<span class="sourceLineNo">351</span> .withStopRow(Bytes.toBytes(stopRow));<a name="line.351"></a>
+<span class="sourceLineNo">352</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.352"></a>
+<span class="sourceLineNo">353</span> assertFalse(exists);<a name="line.353"></a>
+<span class="sourceLineNo">354</span><a name="line.354"></a>
+<span class="sourceLineNo">355</span> // There is no common prefix between startRow and stopRow.<a name="line.355"></a>
+<span class="sourceLineNo">356</span> prefixRow = String.format(prefixFormatter, prefixRowCount-2);<a name="line.356"></a>
+<span class="sourceLineNo">357</span> startRow = prefixRow + "#" + String.format(suffixFormatter, 0);<a name="line.357"></a>
+<span class="sourceLineNo">358</span> scan = new Scan().withStartRow(Bytes.toBytes(startRow));<a name="line.358"></a>
+<span class="sourceLineNo">359</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.359"></a>
+<span class="sourceLineNo">360</span> assertTrue(exists);<a name="line.360"></a>
+<span class="sourceLineNo">361</span><a name="line.361"></a>
+<span class="sourceLineNo">362</span> if (bt[x] == BloomType.ROWPREFIX_FIXED_LENGTH) {<a name="line.362"></a>
+<span class="sourceLineNo">363</span> // startRow and stopRow have a common prefix.<a name="line.363"></a>
+<span class="sourceLineNo">364</span> // But the length of the common prefix is less than prefixLength.<a name="line.364"></a>
+<span class="sourceLineNo">365</span> String prefixStartRow = String.format(prefixFormatter, prefixRowCount-2);<a name="line.365"></a>
+<span class="sourceLineNo">366</span> String prefixStopRow = String.format(prefixFormatter, prefixRowCount-1);<a name="line.366"></a>
+<span class="sourceLineNo">367</span> startRow = prefixStartRow + "#" + String.format(suffixFormatter, 0);<a name="line.367"></a>
+<span class="sourceLineNo">368</span> stopRow = prefixStopRow + "#" + String.format(suffixFormatter, 0);<a name="line.368"></a>
+<span class="sourceLineNo">369</span> scan = new Scan().withStartRow(Bytes.toBytes(startRow))<a name="line.369"></a>
+<span class="sourceLineNo">370</span> .withStopRow(Bytes.toBytes(stopRow));<a name="line.370"></a>
+<span class="sourceLineNo">371</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.371"></a>
+<span class="sourceLineNo">372</span> assertTrue(exists);<a name="line.372"></a>
+<span class="sourceLineNo">373</span> }else if (bt[x] == BloomType.ROWPREFIX_DELIMITED) {<a name="line.373"></a>
+<span class="sourceLineNo">374</span> // startRow does not contain delimiter<a name="line.374"></a>
+<span class="sourceLineNo">375</span> String prefixStartRow = String.format(prefixFormatter, prefixRowCount-2);<a name="line.375"></a>
+<span class="sourceLineNo">376</span> String prefixStopRow = String.format(prefixFormatter, prefixRowCount-2);<a name="line.376"></a>
+<span class="sourceLineNo">377</span> startRow = prefixStartRow + String.format(suffixFormatter, 0);<a name="line.377"></a>
+<span class="sourceLineNo">378</span> stopRow = prefixStopRow + "#" + String.format(suffixFormatter, 0);<a name="line.378"></a>
+<span class="sourceLineNo">379</span> scan = new Scan().withStartRow(Bytes.toBytes(startRow))<a name="line.379"></a>
+<span class="sourceLineNo">380</span> .withStopRow(Bytes.toBytes(stopRow));<a name="line.380"></a>
+<span class="sourceLineNo">381</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.381"></a>
+<span class="sourceLineNo">382</span> assertTrue(exists);<a name="line.382"></a>
+<span class="sourceLineNo">383</span><a name="line.383"></a>
+<span class="sourceLineNo">384</span> // startRow contains delimiter, but stopRow does not have the same prefix as startRow.<a name="line.384"></a>
+<span class="sourceLineNo">385</span> prefixStartRow = String.format(prefixFormatter, prefixRowCount-2);<a name="line.385"></a>
+<span class="sourceLineNo">386</span> prefixStopRow = String.format(prefixFormatter, prefixRowCount-1);<a name="line.386"></a>
+<span class="sourceLineNo">387</span> startRow = prefixStartRow + "#" + String.format(suffixFormatter, 0);<a name="line.387"></a>
+<span class="sourceLineNo">388</span> stopRow = prefixStopRow + "#" + String.format(suffixFormatter, 0);<a name="line.388"></a>
+<span class="sourceLineNo">389</span> scan = new Scan().withStartRow(Bytes.toBytes(startRow))<a name="line.389"></a>
+<span class="sourceLineNo">390</span> .withStopRow(Bytes.toBytes(stopRow));<a name="line.390"></a>
+<span class="sourceLineNo">391</span> exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);<a name="line.391"></a>
+<span class="sourceLineNo">392</span> assertTrue(exists);<a name="line.392"></a>
+<span class="sourceLineNo">393</span> }<a name="line.393"></a>
+<span class="sourceLineNo">394</span><a name="line.394"></a>
+<span class="sourceLineNo">395</span> reader.close(true); // evict because we are about to delete the file<a name="line.395"></a>
+<span class="sourceLineNo">396</span> fs.delete(f, true);<a name="line.396"></a>
+<span class="sourceLineNo">397</span> }<a name="line.397"></a>
+<span class="sourceLineNo">398</span> }<a name="line.398"></a>
+<span class="sourceLineNo">399</span>}<a name="line.399"></a>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+</pre>
+</div>
+</body>
+</html>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/bbe517ae/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.html
index b14243a..ec8272d 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.html
@@ -54,179 +54,182 @@
<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.regionserver.HRegion.RegionScannerImpl;<a name="line.46"></a>
<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.testclassification.RegionServerTests;<a name="line.47"></a>
<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.testclassification.SmallTests;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.junit.Before;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.junit.ClassRule;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.junit.Test;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.junit.experimental.categories.Category;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.junit.runner.RunWith;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.junit.runners.Parameterized;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.junit.runners.Parameterized.Parameters;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import org.slf4j.Logger;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import org.slf4j.LoggerFactory;<a name="line.58"></a>
-<span class="sourceLineNo">059</span><a name="line.59"></a>
-<span class="sourceLineNo">060</span>/**<a name="line.60"></a>
-<span class="sourceLineNo">061</span> * Test a multi-column scanner when there is a Bloom filter false-positive.<a name="line.61"></a>
-<span class="sourceLineNo">062</span> * This is needed for the multi-column Bloom filter optimization.<a name="line.62"></a>
-<span class="sourceLineNo">063</span> */<a name="line.63"></a>
-<span class="sourceLineNo">064</span>@RunWith(Parameterized.class)<a name="line.64"></a>
-<span class="sourceLineNo">065</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.65"></a>
-<span class="sourceLineNo">066</span>public class TestScanWithBloomError {<a name="line.66"></a>
-<span class="sourceLineNo">067</span><a name="line.67"></a>
-<span class="sourceLineNo">068</span> @ClassRule<a name="line.68"></a>
-<span class="sourceLineNo">069</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.69"></a>
-<span class="sourceLineNo">070</span> HBaseClassTestRule.forClass(TestScanWithBloomError.class);<a name="line.70"></a>
-<span class="sourceLineNo">071</span><a name="line.71"></a>
-<span class="sourceLineNo">072</span> private static final Logger LOG =<a name="line.72"></a>
-<span class="sourceLineNo">073</span> LoggerFactory.getLogger(TestScanWithBloomError.class);<a name="line.73"></a>
-<span class="sourceLineNo">074</span><a name="line.74"></a>
-<span class="sourceLineNo">075</span> private static final String TABLE_NAME = "ScanWithBloomError";<a name="line.75"></a>
-<span class="sourceLineNo">076</span> private static final String FAMILY = "myCF";<a name="line.76"></a>
-<span class="sourceLineNo">077</span> private static final byte[] FAMILY_BYTES = Bytes.toBytes(FAMILY);<a name="line.77"></a>
-<span class="sourceLineNo">078</span> private static final String ROW = "theRow";<a name="line.78"></a>
-<span class="sourceLineNo">079</span> private static final String QUALIFIER_PREFIX = "qual";<a name="line.79"></a>
-<span class="sourceLineNo">080</span> private static final byte[] ROW_BYTES = Bytes.toBytes(ROW);<a name="line.80"></a>
-<span class="sourceLineNo">081</span> private static NavigableSet<Integer> allColIds = new TreeSet<>();<a name="line.81"></a>
-<span class="sourceLineNo">082</span> private HRegion region;<a name="line.82"></a>
-<span class="sourceLineNo">083</span> private BloomType bloomType;<a name="line.83"></a>
-<span class="sourceLineNo">084</span> private FileSystem fs;<a name="line.84"></a>
-<span class="sourceLineNo">085</span> private Configuration conf;<a name="line.85"></a>
-<span class="sourceLineNo">086</span><a name="line.86"></a>
-<span class="sourceLineNo">087</span> private final static HBaseTestingUtility TEST_UTIL = HBaseTestingUtility.createLocalHTU();<a name="line.87"></a>
-<span class="sourceLineNo">088</span><a name="line.88"></a>
-<span class="sourceLineNo">089</span> @Parameters<a name="line.89"></a>
-<span class="sourceLineNo">090</span> public static final Collection<Object[]> parameters() {<a name="line.90"></a>
-<span class="sourceLineNo">091</span> List<Object[]> configurations = new ArrayList<>();<a name="line.91"></a>
-<span class="sourceLineNo">092</span> for (BloomType bloomType : BloomType.values()) {<a name="line.92"></a>
-<span class="sourceLineNo">093</span> configurations.add(new Object[] { bloomType });<a name="line.93"></a>
-<span class="sourceLineNo">094</span> }<a name="line.94"></a>
-<span class="sourceLineNo">095</span> return configurations;<a name="line.95"></a>
-<span class="sourceLineNo">096</span> }<a name="line.96"></a>
-<span class="sourceLineNo">097</span><a name="line.97"></a>
-<span class="sourceLineNo">098</span> public TestScanWithBloomError(BloomType bloomType) {<a name="line.98"></a>
-<span class="sourceLineNo">099</span> this.bloomType = bloomType;<a name="line.99"></a>
-<span class="sourceLineNo">100</span> }<a name="line.100"></a>
-<span class="sourceLineNo">101</span><a name="line.101"></a>
-<span class="sourceLineNo">102</span> @Before<a name="line.102"></a>
-<span class="sourceLineNo">103</span> public void setUp() throws IOException{<a name="line.103"></a>
-<span class="sourceLineNo">104</span> conf = TEST_UTIL.getConfiguration();<a name="line.104"></a>
-<span class="sourceLineNo">105</span> fs = FileSystem.get(conf);<a name="line.105"></a>
-<span class="sourceLineNo">106</span> }<a name="line.106"></a>
-<span class="sourceLineNo">107</span><a name="line.107"></a>
-<span class="sourceLineNo">108</span> @Test<a name="line.108"></a>
-<span class="sourceLineNo">109</span> public void testThreeStoreFiles() throws IOException {<a name="line.109"></a>
-<span class="sourceLineNo">110</span> region = TEST_UTIL.createTestRegion(TABLE_NAME,<a name="line.110"></a>
-<span class="sourceLineNo">111</span> new HColumnDescriptor(FAMILY)<a name="line.111"></a>
-<span class="sourceLineNo">112</span> .setCompressionType(Compression.Algorithm.GZ)<a name="line.112"></a>
-<span class="sourceLineNo">113</span> .setBloomFilterType(bloomType)<a name="line.113"></a>
-<span class="sourceLineNo">114</span> .setMaxVersions(TestMultiColumnScanner.MAX_VERSIONS));<a name="line.114"></a>
-<span class="sourceLineNo">115</span> createStoreFile(new int[] {1, 2, 6});<a name="line.115"></a>
-<span class="sourceLineNo">116</span> createStoreFile(new int[] {1, 2, 3, 7});<a name="line.116"></a>
-<span class="sourceLineNo">117</span> createStoreFile(new int[] {1, 9});<a name="line.117"></a>
-<span class="sourceLineNo">118</span> scanColSet(new int[]{1, 4, 6, 7}, new int[]{1, 6, 7});<a name="line.118"></a>
-<span class="sourceLineNo">119</span><a name="line.119"></a>
-<span class="sourceLineNo">120</span> HBaseTestingUtility.closeRegionAndWAL(region);<a name="line.120"></a>
-<span class="sourceLineNo">121</span> }<a name="line.121"></a>
+<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.util.BloomFilterUtil;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.Before;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.junit.ClassRule;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.junit.Test;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.junit.experimental.categories.Category;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.junit.runner.RunWith;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.junit.runners.Parameterized;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.junit.runners.Parameterized.Parameters;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.slf4j.Logger;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import org.slf4j.LoggerFactory;<a name="line.59"></a>
+<span class="sourceLineNo">060</span><a name="line.60"></a>
+<span class="sourceLineNo">061</span>/**<a name="line.61"></a>
+<span class="sourceLineNo">062</span> * Test a multi-column scanner when there is a Bloom filter false-positive.<a name="line.62"></a>
+<span class="sourceLineNo">063</span> * This is needed for the multi-column Bloom filter optimization.<a name="line.63"></a>
+<span class="sourceLineNo">064</span> */<a name="line.64"></a>
+<span class="sourceLineNo">065</span>@RunWith(Parameterized.class)<a name="line.65"></a>
+<span class="sourceLineNo">066</span>@Category({RegionServerTests.class, SmallTests.class})<a name="line.66"></a>
+<span class="sourceLineNo">067</span>public class TestScanWithBloomError {<a name="line.67"></a>
+<span class="sourceLineNo">068</span><a name="line.68"></a>
+<span class="sourceLineNo">069</span> @ClassRule<a name="line.69"></a>
+<span class="sourceLineNo">070</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.70"></a>
+<span class="sourceLineNo">071</span> HBaseClassTestRule.forClass(TestScanWithBloomError.class);<a name="line.71"></a>
+<span class="sourceLineNo">072</span><a name="line.72"></a>
+<span class="sourceLineNo">073</span> private static final Logger LOG =<a name="line.73"></a>
+<span class="sourceLineNo">074</span> LoggerFactory.getLogger(TestScanWithBloomError.class);<a name="line.74"></a>
+<span class="sourceLineNo">075</span><a name="line.75"></a>
+<span class="sourceLineNo">076</span> private static final String TABLE_NAME = "ScanWithBloomError";<a name="line.76"></a>
+<span class="sourceLineNo">077</span> private static final String FAMILY = "myCF";<a name="line.77"></a>
+<span class="sourceLineNo">078</span> private static final byte[] FAMILY_BYTES = Bytes.toBytes(FAMILY);<a name="line.78"></a>
+<span class="sourceLineNo">079</span> private static final String ROW = "theRow";<a name="line.79"></a>
+<span class="sourceLineNo">080</span> private static final String QUALIFIER_PREFIX = "qual";<a name="line.80"></a>
+<span class="sourceLineNo">081</span> private static final byte[] ROW_BYTES = Bytes.toBytes(ROW);<a name="line.81"></a>
+<span class="sourceLineNo">082</span> private static NavigableSet<Integer> allColIds = new TreeSet<>();<a name="line.82"></a>
+<span class="sourceLineNo">083</span> private HRegion region;<a name="line.83"></a>
+<span class="sourceLineNo">084</span> private BloomType bloomType;<a name="line.84"></a>
+<span class="sourceLineNo">085</span> private FileSystem fs;<a name="line.85"></a>
+<span class="sourceLineNo">086</span> private Configuration conf;<a name="line.86"></a>
+<span class="sourceLineNo">087</span><a name="line.87"></a>
+<span class="sourceLineNo">088</span> private final static HBaseTestingUtility TEST_UTIL = HBaseTestingUtility.createLocalHTU();<a name="line.88"></a>
+<span class="sourceLineNo">089</span><a name="line.89"></a>
+<span class="sourceLineNo">090</span> @Parameters<a name="line.90"></a>
+<span class="sourceLineNo">091</span> public static final Collection<Object[]> parameters() {<a name="line.91"></a>
+<span class="sourceLineNo">092</span> List<Object[]> configurations = new ArrayList<>();<a name="line.92"></a>
+<span class="sourceLineNo">093</span> for (BloomType bloomType : BloomType.values()) {<a name="line.93"></a>
+<span class="sourceLineNo">094</span> configurations.add(new Object[] { bloomType });<a name="line.94"></a>
+<span class="sourceLineNo">095</span> }<a name="line.95"></a>
+<span class="sourceLineNo">096</span> return configurations;<a name="line.96"></a>
+<span class="sourceLineNo">097</span> }<a name="line.97"></a>
+<span class="sourceLineNo">098</span><a name="line.98"></a>
+<span class="sourceLineNo">099</span> public TestScanWithBloomError(BloomType bloomType) {<a name="line.99"></a>
+<span class="sourceLineNo">100</span> this.bloomType = bloomType;<a name="line.100"></a>
+<span class="sourceLineNo">101</span> }<a name="line.101"></a>
+<span class="sourceLineNo">102</span><a name="line.102"></a>
+<span class="sourceLineNo">103</span> @Before<a name="line.103"></a>
+<span class="sourceLineNo">104</span> public void setUp() throws IOException{<a name="line.104"></a>
+<span class="sourceLineNo">105</span> conf = TEST_UTIL.getConfiguration();<a name="line.105"></a>
+<span class="sourceLineNo">106</span> fs = FileSystem.get(conf);<a name="line.106"></a>
+<span class="sourceLineNo">107</span> conf.setInt(BloomFilterUtil.PREFIX_LENGTH_KEY, 10);<a name="line.107"></a>
+<span class="sourceLineNo">108</span> conf.set(BloomFilterUtil.DELIMITER_KEY, "#");<a name="line.108"></a>
+<span class="sourceLineNo">109</span> }<a name="line.109"></a>
+<span class="sourceLineNo">110</span><a name="line.110"></a>
+<span class="sourceLineNo">111</span> @Test<a name="line.111"></a>
+<span class="sourceLineNo">112</span> public void testThreeStoreFiles() throws IOException {<a name="line.112"></a>
+<span class="sourceLineNo">113</span> region = TEST_UTIL.createTestRegion(TABLE_NAME,<a name="line.113"></a>
+<span class="sourceLineNo">114</span> new HColumnDescriptor(FAMILY)<a name="line.114"></a>
+<span class="sourceLineNo">115</span> .setCompressionType(Compression.Algorithm.GZ)<a name="line.115"></a>
+<span class="sourceLineNo">116</span> .setBloomFilterType(bloomType)<a name="line.116"></a>
+<span class="sourceLineNo">117</span> .setMaxVersions(TestMultiColumnScanner.MAX_VERSIONS));<a name="line.117"></a>
+<span class="sourceLineNo">118</span> createStoreFile(new int[] {1, 2, 6});<a name="line.118"></a>
+<span class="sourceLineNo">119</span> createStoreFile(new int[] {1, 2, 3, 7});<a name="line.119"></a>
+<span class="sourceLineNo">120</span> createStoreFile(new int[] {1, 9});<a name="line.120"></a>
+<span class="sourceLineNo">121</span> scanColSet(new int[]{1, 4, 6, 7}, new int[]{1, 6, 7});<a name="line.121"></a>
<span class="sourceLineNo">122</span><a name="line.122"></a>
-<span class="sourceLineNo">123</span> private void scanColSet(int[] colSet, int[] expectedResultCols)<a name="line.123"></a>
-<span class="sourceLineNo">124</span> throws IOException {<a name="line.124"></a>
-<span class="sourceLineNo">125</span> LOG.info("Scanning column set: " + Arrays.toString(colSet));<a name="line.125"></a>
-<span class="sourceLineNo">126</span> Scan scan = new Scan(ROW_BYTES, ROW_BYTES);<a name="line.126"></a>
-<span class="sourceLineNo">127</span> addColumnSetToScan(scan, colSet);<a name="line.127"></a>
-<span class="sourceLineNo">128</span> RegionScannerImpl scanner = region.getScanner(scan);<a name="line.128"></a>
-<span class="sourceLineNo">129</span> KeyValueHeap storeHeap = scanner.getStoreHeapForTesting();<a name="line.129"></a>
-<span class="sourceLineNo">130</span> assertEquals(0, storeHeap.getHeap().size());<a name="line.130"></a>
-<span class="sourceLineNo">131</span> StoreScanner storeScanner =<a name="line.131"></a>
-<span class="sourceLineNo">132</span> (StoreScanner) storeHeap.getCurrentForTesting();<a name="line.132"></a>
-<span class="sourceLineNo">133</span> @SuppressWarnings({ "unchecked", "rawtypes" })<a name="line.133"></a>
-<span class="sourceLineNo">134</span> List<StoreFileScanner> scanners = (List<StoreFileScanner>)<a name="line.134"></a>
-<span class="sourceLineNo">135</span> (List) storeScanner.getAllScannersForTesting();<a name="line.135"></a>
-<span class="sourceLineNo">136</span><a name="line.136"></a>
-<span class="sourceLineNo">137</span> // Sort scanners by their HFile's modification time.<a name="line.137"></a>
-<span class="sourceLineNo">138</span> Collections.sort(scanners, new Comparator<StoreFileScanner>() {<a name="line.138"></a>
-<span class="sourceLineNo">139</span> @Override<a name="line.139"></a>
-<span class="sourceLineNo">140</span> public int compare(StoreFileScanner s1, StoreFileScanner s2) {<a name="line.140"></a>
-<span class="sourceLineNo">141</span> Path p1 = s1.getReader().getHFileReader().getPath();<a name="line.141"></a>
-<span class="sourceLineNo">142</span> Path p2 = s2.getReader().getHFileReader().getPath();<a name="line.142"></a>
-<span class="sourceLineNo">143</span> long t1, t2;<a name="line.143"></a>
-<span class="sourceLineNo">144</span> try {<a name="line.144"></a>
-<span class="sourceLineNo">145</span> t1 = fs.getFileStatus(p1).getModificationTime();<a name="line.145"></a>
-<span class="sourceLineNo">146</span> t2 = fs.getFileStatus(p2).getModificationTime();<a name="line.146"></a>
-<span class="sourceLineNo">147</span> } catch (IOException ex) {<a name="line.147"></a>
-<span class="sourceLineNo">148</span> throw new RuntimeException(ex);<a name="line.148"></a>
-<span class="sourceLineNo">149</span> }<a name="line.149"></a>
-<span class="sourceLineNo">150</span> return t1 < t2 ? -1 : t1 == t2 ? 1 : 0;<a name="line.150"></a>
-<span class="sourceLineNo">151</span> }<a name="line.151"></a>
-<span class="sourceLineNo">152</span> });<a name="line.152"></a>
-<span class="sourceLineNo">153</span><a name="line.153"></a>
-<span class="sourceLineNo">154</span> StoreFileReader lastStoreFileReader = null;<a name="line.154"></a>
-<span class="sourceLineNo">155</span> for (StoreFileScanner sfScanner : scanners)<a name="line.155"></a>
-<span class="sourceLineNo">156</span> lastStoreFileReader = sfScanner.getReader();<a name="line.156"></a>
-<span class="sourceLineNo">157</span><a name="line.157"></a>
-<span class="sourceLineNo">158</span> new HFilePrettyPrinter(conf).run(new String[]{ "-m", "-p", "-f",<a name="line.158"></a>
-<span class="sourceLineNo">159</span> lastStoreFileReader.getHFileReader().getPath().toString()});<a name="line.159"></a>
+<span class="sourceLineNo">123</span> HBaseTestingUtility.closeRegionAndWAL(region);<a name="line.123"></a>
+<span class="sourceLineNo">124</span> }<a name="line.124"></a>
+<span class="sourceLineNo">125</span><a name="line.125"></a>
+<span class="sourceLineNo">126</span> private void scanColSet(int[] colSet, int[] expectedResultCols)<a name="line.126"></a>
+<span class="sourceLineNo">127</span> throws IOException {<a name="line.127"></a>
+<span class="sourceLineNo">128</span> LOG.info("Scanning column set: " + Arrays.toString(colSet));<a name="line.128"></a>
+<span class="sourceLineNo">129</span> Scan scan = new Scan(ROW_BYTES, ROW_BYTES);<a name="line.129"></a>
+<span class="sourceLineNo">130</span> addColumnSetToScan(scan, colSet);<a name="line.130"></a>
+<span class="sourceLineNo">131</span> RegionScannerImpl scanner = region.getScanner(scan);<a name="line.131"></a>
+<span class="sourceLineNo">132</span> KeyValueHeap storeHeap = scanner.getStoreHeapForTesting();<a name="line.132"></a>
+<span class="sourceLineNo">133</span> assertEquals(0, storeHeap.getHeap().size());<a name="line.133"></a>
+<span class="sourceLineNo">134</span> StoreScanner storeScanner =<a name="line.134"></a>
+<span class="sourceLineNo">135</span> (StoreScanner) storeHeap.getCurrentForTesting();<a name="line.135"></a>
+<span class="sourceLineNo">136</span> @SuppressWarnings({ "unchecked", "rawtypes" })<a name="line.136"></a>
+<span class="sourceLineNo">137</span> List<StoreFileScanner> scanners = (List<StoreFileScanner>)<a name="line.137"></a>
+<span class="sourceLineNo">138</span> (List) storeScanner.getAllScannersForTesting();<a name="line.138"></a>
+<span class="sourceLineNo">139</span><a name="line.139"></a>
+<span class="sourceLineNo">140</span> // Sort scanners by their HFile's modification time.<a name="line.140"></a>
+<span class="sourceLineNo">141</span> Collections.sort(scanners, new Comparator<StoreFileScanner>() {<a name="line.141"></a>
+<span class="sourceLineNo">142</span> @Override<a name="line.142"></a>
+<span class="sourceLineNo">143</span> public int compare(StoreFileScanner s1, StoreFileScanner s2) {<a name="line.143"></a>
+<span class="sourceLineNo">144</span> Path p1 = s1.getReader().getHFileReader().getPath();<a name="line.144"></a>
+<span class="sourceLineNo">145</span> Path p2 = s2.getReader().getHFileReader().getPath();<a name="line.145"></a>
+<span class="sourceLineNo">146</span> long t1, t2;<a name="line.146"></a>
+<span class="sourceLineNo">147</span> try {<a name="line.147"></a>
+<span class="sourceLineNo">148</span> t1 = fs.getFileStatus(p1).getModificationTime();<a name="line.148"></a>
+<span class="sourceLineNo">149</span> t2 = fs.getFileStatus(p2).getModificationTime();<a name="line.149"></a>
+<span class="sourceLineNo">150</span> } catch (IOException ex) {<a name="line.150"></a>
+<span class="sourceLineNo">151</span> throw new RuntimeException(ex);<a name="line.151"></a>
+<span class="sourceLineNo">152</span> }<a name="line.152"></a>
+<span class="sourceLineNo">153</span> return t1 < t2 ? -1 : t1 == t2 ? 1 : 0;<a name="line.153"></a>
+<span class="sourceLineNo">154</span> }<a name="line.154"></a>
+<span class="sourceLineNo">155</span> });<a name="line.155"></a>
+<span class="sourceLineNo">156</span><a name="line.156"></a>
+<span class="sourceLineNo">157</span> StoreFileReader lastStoreFileReader = null;<a name="line.157"></a>
+<span class="sourceLineNo">158</span> for (StoreFileScanner sfScanner : scanners)<a name="line.158"></a>
+<span class="sourceLineNo">159</span> lastStoreFileReader = sfScanner.getReader();<a name="line.159"></a>
<span class="sourceLineNo">160</span><a name="line.160"></a>
-<span class="sourceLineNo">161</span> // Disable Bloom filter for the last store file. The disabled Bloom filter<a name="line.161"></a>
-<span class="sourceLineNo">162</span> // will always return "true".<a name="line.162"></a>
-<span class="sourceLineNo">163</span> LOG.info("Disabling Bloom filter for: "<a name="line.163"></a>
-<span class="sourceLineNo">164</span> + lastStoreFileReader.getHFileReader().getName());<a name="line.164"></a>
-<span class="sourceLineNo">165</span> lastStoreFileReader.disableBloomFilterForTesting();<a name="line.165"></a>
-<span class="sourceLineNo">166</span><a name="line.166"></a>
-<span class="sourceLineNo">167</span> List<Cell> allResults = new ArrayList<>();<a name="line.167"></a>
-<span class="sourceLineNo">168</span><a name="line.168"></a>
-<span class="sourceLineNo">169</span> { // Limit the scope of results.<a name="line.169"></a>
-<span class="sourceLineNo">170</span> List<Cell> results = new ArrayList<>();<a name="line.170"></a>
-<span class="sourceLineNo">171</span> while (scanner.next(results) || results.size() > 0) {<a name="line.171"></a>
-<span class="sourceLineNo">172</span> allResults.addAll(results);<a name="line.172"></a>
-<span class="sourceLineNo">173</span> results.clear();<a name="line.173"></a>
-<span class="sourceLineNo">174</span> }<a name="line.174"></a>
-<span class="sourceLineNo">175</span> }<a name="line.175"></a>
-<span class="sourceLineNo">176</span><a name="line.176"></a>
-<span class="sourceLineNo">177</span> List<Integer> actualIds = new ArrayList<>();<a name="line.177"></a>
-<span class="sourceLineNo">178</span> for (Cell kv : allResults) {<a name="line.178"></a>
-<span class="sourceLineNo">179</span> String qual = Bytes.toString(CellUtil.cloneQualifier(kv));<a name="line.179"></a>
-<span class="sourceLineNo">180</span> assertTrue(qual.startsWith(QUALIFIER_PREFIX));<a name="line.180"></a>
-<span class="sourceLineNo">181</span> actualIds.add(Integer.valueOf(qual.substring(<a name="line.181"></a>
-<span class="sourceLineNo">182</span> QUALIFIER_PREFIX.length())));<a name="line.182"></a>
-<span class="sourceLineNo">183</span> }<a name="line.183"></a>
-<span class="sourceLineNo">184</span> List<Integer> expectedIds = new ArrayList<>();<a name="line.184"></a>
-<span class="sourceLineNo">185</span> for (int expectedId : expectedResultCols)<a name="line.185"></a>
-<span class="sourceLineNo">186</span> expectedIds.add(expectedId);<a name="line.186"></a>
-<span class="sourceLineNo">187</span><a name="line.187"></a>
-<span class="sourceLineNo">188</span> LOG.info("Column ids returned: " + actualIds + ", expected: "<a name="line.188"></a>
-<span class="sourceLineNo">189</span> + expectedIds);<a name="line.189"></a>
-<span class="sourceLineNo">190</span> assertEquals(expectedIds.toString(), actualIds.toString());<a name="line.190"></a>
-<span class="sourceLineNo">191</span> }<a name="line.191"></a>
-<span class="sourceLineNo">192</span><a name="line.192"></a>
-<span class="sourceLineNo">193</span> private void addColumnSetToScan(Scan scan, int[] colIds) {<a name="line.193"></a>
-<span class="sourceLineNo">194</span> for (int colId : colIds) {<a name="line.194"></a>
-<span class="sourceLineNo">195</span> scan.addColumn(FAMILY_BYTES,<a name="line.195"></a>
-<span class="sourceLineNo">196</span> Bytes.toBytes(qualFromId(colId)));<a name="line.196"></a>
-<span class="sourceLineNo">197</span> }<a name="line.197"></a>
-<span class="sourceLineNo">198</span> }<a name="line.198"></a>
-<span class="sourceLineNo">199</span><a name="line.199"></a>
-<span class="sourceLineNo">200</span> private String qualFromId(int colId) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span> return QUALIFIER_PREFIX + colId;<a name="line.201"></a>
-<span class="sourceLineNo">202</span> }<a name="line.202"></a>
-<span class="sourceLineNo">203</span><a name="line.203"></a>
-<span class="sourceLineNo">204</span> private void createStoreFile(int[] colIds)<a name="line.204"></a>
-<span class="sourceLineNo">205</span> throws IOException {<a name="line.205"></a>
-<span class="sourceLineNo">206</span> Put p = new Put(ROW_BYTES);<a name="line.206"></a>
-<span class="sourceLineNo">207</span> for (int colId : colIds) {<a name="line.207"></a>
-<span class="sourceLineNo">208</span> long ts = Long.MAX_VALUE;<a name="line.208"></a>
-<span class="sourceLineNo">209</span> String qual = qualFromId(colId);<a name="line.209"></a>
-<span class="sourceLineNo">210</span> allColIds.add(colId);<a name="line.210"></a>
-<span class="sourceLineNo">211</span> KeyValue kv = KeyValueTestUtil.create(ROW, FAMILY,<a name="line.211"></a>
-<span class="sourceLineNo">212</span> qual, ts, TestMultiColumnScanner.createValue(ROW, qual, ts));<a name="line.212"></a>
-<span class="sourceLineNo">213</span> p.add(kv);<a name="line.213"></a>
-<span class="sourceLineNo">214</span> }<a name="line.214"></a>
-<span class="sourceLineNo">215</span> region.put(p);<a name="line.215"></a>
-<span class="sourceLineNo">216</span> region.flush(true);<a name="line.216"></a>
-<span class="sourceLineNo">217</span> }<a name="line.217"></a>
-<span class="sourceLineNo">218</span><a name="line.218"></a>
-<span class="sourceLineNo">219</span><a name="line.219"></a>
-<span class="sourceLineNo">220</span>}<a name="line.220"></a>
+<span class="sourceLineNo">161</span> new HFilePrettyPrinter(conf).run(new String[]{ "-m", "-p", "-f",<a name="line.161"></a>
+<span class="sourceLineNo">162</span> lastStoreFileReader.getHFileReader().getPath().toString()});<a name="line.162"></a>
+<span class="sourceLineNo">163</span><a name="line.163"></a>
+<span class="sourceLineNo">164</span> // Disable Bloom filter for the last store file. The disabled Bloom filter<a name="line.164"></a>
+<span class="sourceLineNo">165</span> // will always return "true".<a name="line.165"></a>
+<span class="sourceLineNo">166</span> LOG.info("Disabling Bloom filter for: "<a name="line.166"></a>
+<span class="sourceLineNo">167</span> + lastStoreFileReader.getHFileReader().getName());<a name="line.167"></a>
+<span class="sourceLineNo">168</span> lastStoreFileReader.disableBloomFilterForTesting();<a name="line.168"></a>
+<span class="sourceLineNo">169</span><a name="line.169"></a>
+<span class="sourceLineNo">170</span> List<Cell> allResults = new ArrayList<>();<a name="line.170"></a>
+<span class="sourceLineNo">171</span><a name="line.171"></a>
+<span class="sourceLineNo">172</span> { // Limit the scope of results.<a name="line.172"></a>
+<span class="sourceLineNo">173</span> List<Cell> results = new ArrayList<>();<a name="line.173"></a>
+<span class="sourceLineNo">174</span> while (scanner.next(results) || results.size() > 0) {<a name="line.174"></a>
+<span class="sourceLineNo">175</span> allResults.addAll(results);<a name="line.175"></a>
+<span class="sourceLineNo">176</span> results.clear();<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span> }<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> List<Integer> actualIds = new ArrayList<>();<a name="line.180"></a>
+<span class="sourceLineNo">181</span> for (Cell kv : allResults) {<a name="line.181"></a>
+<span class="sourceLineNo">182</span> String qual = Bytes.toString(CellUtil.cloneQualifier(kv));<a name="line.182"></a>
+<span class="sourceLineNo">183</span> assertTrue(qual.startsWith(QUALIFIER_PREFIX));<a name="line.183"></a>
+<span class="sourceLineNo">184</span> actualIds.add(Integer.valueOf(qual.substring(<a name="line.184"></a>
+<span class="sourceLineNo">185</span> QUALIFIER_PREFIX.length())));<a name="line.185"></a>
+<span class="sourceLineNo">186</span> }<a name="line.186"></a>
+<span class="sourceLineNo">187</span> List<Integer> expectedIds = new ArrayList<>();<a name="line.187"></a>
+<span class="sourceLineNo">188</span> for (int expectedId : expectedResultCols)<a name="line.188"></a>
+<span class="sourceLineNo">189</span> expectedIds.add(expectedId);<a name="line.189"></a>
+<span class="sourceLineNo">190</span><a name="line.190"></a>
+<span class="sourceLineNo">191</span> LOG.info("Column ids returned: " + actualIds + ", expected: "<a name="line.191"></a>
+<span class="sourceLineNo">192</span> + expectedIds);<a name="line.192"></a>
+<span class="sourceLineNo">193</span> assertEquals(expectedIds.toString(), actualIds.toString());<a name="line.193"></a>
+<span class="sourceLineNo">194</span> }<a name="line.194"></a>
+<span class="sourceLineNo">195</span><a name="line.195"></a>
+<span class="sourceLineNo">196</span> private void addColumnSetToScan(Scan scan, int[] colIds) {<a name="line.196"></a>
+<span class="sourceLineNo">197</span> for (int colId : colIds) {<a name="line.197"></a>
+<span class="sourceLineNo">198</span> scan.addColumn(FAMILY_BYTES,<a name="line.198"></a>
+<span class="sourceLineNo">199</span> Bytes.toBytes(qualFromId(colId)));<a name="line.199"></a>
+<span class="sourceLineNo">200</span> }<a name="line.200"></a>
+<span class="sourceLineNo">201</span> }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span> private String qualFromId(int colId) {<a name="line.203"></a>
+<span class="sourceLineNo">204</span> return QUALIFIER_PREFIX + colId;<a name="line.204"></a>
+<span class="sourceLineNo">205</span> }<a name="line.205"></a>
+<span class="sourceLineNo">206</span><a name="line.206"></a>
+<span class="sourceLineNo">207</span> private void createStoreFile(int[] colIds)<a name="line.207"></a>
+<span class="sourceLineNo">208</span> throws IOException {<a name="line.208"></a>
+<span class="sourceLineNo">209</span> Put p = new Put(ROW_BYTES);<a name="line.209"></a>
+<span class="sourceLineNo">210</span> for (int colId : colIds) {<a name="line.210"></a>
+<span class="sourceLineNo">211</span> long ts = Long.MAX_VALUE;<a name="line.211"></a>
+<span class="sourceLineNo">212</span> String qual = qualFromId(colId);<a name="line.212"></a>
+<span class="sourceLineNo">213</span> allColIds.add(colId);<a name="line.213"></a>
+<span class="sourceLineNo">214</span> KeyValue kv = KeyValueTestUtil.create(ROW, FAMILY,<a name="line.214"></a>
+<span class="sourceLineNo">215</span> qual, ts, TestMultiColumnScanner.createValue(ROW, qual, ts));<a name="line.215"></a>
+<span class="sourceLineNo">216</span> p.add(kv);<a name="line.216"></a>
+<span class="sourceLineNo">217</span> }<a name="line.217"></a>
+<span class="sourceLineNo">218</span> region.put(p);<a name="line.218"></a>
+<span class="sourceLineNo">219</span> region.flush(true);<a name="line.219"></a>
+<span class="sourceLineNo">220</span> }<a name="line.220"></a>
<span class="sourceLineNo">221</span><a name="line.221"></a>
+<span class="sourceLineNo">222</span><a name="line.222"></a>
+<span class="sourceLineNo">223</span>}<a name="line.223"></a>
+<span class="sourceLineNo">224</span><a name="line.224"></a>