You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "rubenada (via GitHub)" <gi...@apache.org> on 2023/08/23 12:55:38 UTC

[GitHub] [calcite] rubenada commented on pull request #3390: [CALCITE-5949] Correct handling of invalid constant expressions in reduction

rubenada commented on PR #3390:
URL: https://github.com/apache/calcite/pull/3390#issuecomment-1689913769

   Patch looks good.
   Please note that there are some comments in Jira (that I subscribe) that request to change the Jira title (and hence the PR title and the commit message). I'd propose "RexExecutable returns incorrect result if invalid expression is processed after valid ones" or something a long the lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org