[jira] [Commented] (EMPIREDB-106) createDatabase should not try to create schemas in the DDL script if database name has not been set

["Francis De Brabandere (JIRA)" <em...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/EMPIREDB-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017365#comment-13017365 ] 

Francis De Brabandere commented on EMPIREDB-106:
------------------------------------------------

Makes sense, somehow related to EMPIREDB-101 and EMPIREDB-104

> createDatabase should not try to create schemas in the DDL script if database name has not been set
> ---------------------------------------------------------------------------------------------------
>
>                 Key: EMPIREDB-106
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-106
>             Project: Empire-DB
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: empire-db-2.1.0-incubating
>            Reporter: Eric Cournarie
>            Assignee: Francis De Brabandere
>
> Some drivers (MySQL and MSSQL) are trying to create the schema in the DDL. I think this is useless, as most of the time, the schema needs to be created to be able to access the database. 
> If the databaseName has not been set, the DDL should not contain create schema statement but just the create tables, relations and views. Other Empire drivers (Oracle for instance) are not doing schema creation in the DDL, not sure to 
> understand why this is done for MySQL and MS SQL Server.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira