[GitHub] [shiro] bmarwell commented on a change in pull request #273: [SHIRO-290] Implement BCrypt (and possibly other unix crypt formats like scrypt)

[GitBox <gi...@apache.org>]

bmarwell commented on a change in pull request #273:
URL: https://github.com/apache/shiro/pull/273#discussion_r554342422



##########
File path: crypto/hash/src/main/java/org/apache/shiro/crypto/hash/ConfigurableHashService.java
##########
@@ -18,44 +18,20 @@
  */
 package org.apache.shiro.crypto.hash;
 
-import org.apache.shiro.crypto.RandomNumberGenerator;
-import org.apache.shiro.lang.util.ByteSource;
-
 /**
  * A {@code HashService} that allows configuration of its strategy via JavaBeans-compatible setter methods.
  *
  * @since 1.2
  */
 public interface ConfigurableHashService extends HashService {
 
-    /**
-     * Sets the 'private' (internal) salt to be paired with a 'public' (random or supplied) salt during hash computation.
-     *
-     * @param privateSalt the 'private' internal salt to be paired with a 'public' (random or supplied) salt during
-     *                    hash computation.
-     */
-    void setPrivateSalt(ByteSource privateSalt);
-
-    /**
-     * Sets the number of hash iterations that will be performed during hash computation.
-     *
-     * @param iterations the number of hash iterations that will be performed during hash computation.
-     */
-    void setHashIterations(int iterations);
-
     /**
      * Sets the name of the {@link java.security.MessageDigest MessageDigest} algorithm that will be used to compute
      * hashes.
      *
      * @param name the name of the {@link java.security.MessageDigest MessageDigest} algorithm that will be used to
      *             compute hashes.
      */
-    void setHashAlgorithmName(String name);
+    void setDefaultAlgorithmName(String name);

Review comment:
       Yes, the javadocs are the unchecked checkbox ;) Next commit is on the way.
   
   The default is being used when a `HashRequest` does not carry an algorithm name. Its old behaviour/semantics was at least similar, but I was not looking into making it a 100% compatible here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org