[jira] [Commented] (MESOS-3915) Upgrade vendored Boost

["Benjamin Bannier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336296#comment-16336296 ] 

Benjamin Bannier commented on MESOS-3915:
-----------------------------------------

{noformat}
commit ce0905fcb31a10ade0962a89235fa90b01edf01a
Author: Benjamin Bannier <be...@mesosphere.io>
Date:   Tue Jan 23 14:47:37 2018 +0100

    Updated mesos-tidy setup for upgraded Boost version.
    
    In a previous commit we updated the bundled Boost version. This patch
    updates the mesos-tidy setup to make sure we build the correct bundled
    Boost version when creating analysis prerequisites.
    
    Review: https://reviews.apache.org/r/65215/

commit a01b4c272848702d5bd3dd899e610a5459c4e57c
Author: Benno Evers <be...@mesosphere.com>
Date:   Tue Jan 23 14:47:32 2018 +0100

    Removed duplicate block in configure.ac.
    
    This blocks seems to have been copy/pasted from another place.
    
    Review: https://reviews.apache.org/r/62445/

commit 469363d4322c7acda7fd10acbe8822f610af5a43
Author: Benno Evers <be...@mesosphere.com>
Date:   Tue Jan 23 14:47:31 2018 +0100

    Updated boost version.
    
    Review: https://reviews.apache.org/r/62161/

commit cd2774efde5e55cc027721086af14fbc78688849
Author: Benno Evers <be...@mesosphere.com>
Date:   Tue Jan 23 14:47:28 2018 +0100

    Added UNREACHABLE() macro to __cxa_pure_virtual.
    
    The function __cxa_pure_virtual must not return,
    but newer versions of clang detect that the expansion
    of the RAW_LOG() macro contains returning code paths
    for arguments other than FATAL.
    
    Review: https://reviews.apache.org/r/62444/

commit a892a2e80255291e6cd5cb3b0e90b9a029989c99
Author: Benno Evers <be...@mesosphere.com>
Date:   Tue Jan 23 14:47:24 2018 +0100

    Fixed stout build with newer boost versions.
    
    Starting from Boost 1.62, Boost.Variant added additional
    compile-time checks to its constructors to fix this
    issue: https://svn.boost.org/trac10/ticket/11602
    
    However, this breaks some places in stout which try
    to access a derived class from a variant holding the
    base class.
    
    Review: https://reviews.apache.org/r/62160/
{noformat}

> Upgrade vendored Boost
> ----------------------
>
>                 Key: MESOS-3915
>                 URL: https://issues.apache.org/jira/browse/MESOS-3915
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Neil Conway
>            Assignee: Benno Evers
>            Priority: Minor
>              Labels: boost, mesosphere, tech-debt
>             Fix For: 1.6.0
>
>
> We should upgrade the vendored version of Boost to a newer version. Benefits:
> * -Should properly fix MESOS-688-
> * -Should fix MESOS-3799-
> * Generally speaking, using a more modern version of Boost means we can take advantage of bug fixes, optimizations, and new features.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)