You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2015/12/02 12:05:27 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1150
CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance
Added a new Icon in Instance page to launch the VM from the snapshot.
A new icon over VM snapshot object, which upon invoked will open a deploy user instance wizard, where there is no choice to choose zone and ISO or template to deploy the user instance from.
1) A new icon to indicate deploy user instance from VM snapshot
2) The new icon is placed as an operation over each VM snapshot object.
3) Clicking this icon will show the wizard to deploy user instance, which is same as wizard for normal user instance except that zone selection page and ISO/template selection page would not be present in this wizard.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maharana/CloudStack CloudStack-Nitin12
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1150
----
commit 0fddcc663e201edaff7ed80eb09cf2e1197ae08c
Author: Nitin Kumar Maharana <ni...@citrix.com>
Date: 2015-10-19T19:07:56Z
CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance
Added a new Icon in Instance page to launch the VM from the snapshot.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164178250
@nitin-maharana @bhaisaab both I and @remibergsma don't work with vmware as part of our cloudstack installs, can you do testing and preferably write tests for proving the continued funtioning of the change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-168136764
Sorry I have no vmware setup to test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-168075565
@nitin-maharana sorry don't have the infra to setup vmware and test right now, so cannot help test it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-167931844
cc @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162485224
Hmm.. this isn't supported on KVM, is it? That may be why I can't find it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-168115562
@remibergsma : Any updates on this? Can you please look at the change if you have a setup. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164477318
@DaanHoogland sorry missed your message, I did not test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-169931078
Closing this PR as made a new PR #1320 (Against 4.7 which will be merged in master later).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162484701
@nitin-maharana @bhaisaab I looked around but just don't find what's changed. Please post screenshots of what is changed or instruct exactly how it should work. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162612180
@bhaisaab @DaanHoogland I updated the change with current 4.6 branch and removed the commented codes. @remibergsma This only supports in VMware. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162416679
@nitin-maharana if you can address what Daan has commented today, along with fix tabs with spaces (if any) I can help review this and merge this; before 4.7.0/master freeze is announced today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164279018
@bhaisaab did you test this? should we merge before the RC tonight?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1150#discussion_r46775285
--- Diff: ui/scripts/instanceWizard.js ---
@@ -731,25 +746,33 @@
//step 1 : select zone
$.extend(deployVmData, {
- zoneid : args.data.zoneid
+ zoneid : selectedZoneObj.id
});
//step 2: select template
- $.extend(deployVmData, {
- templateid : args.data.templateid
- });
+ if (snapshotObjs) {
+ $.extend(deployVmData, {
+ vmsnapshotid : selectedSnapshotObj.id
+ });
+ }
+ else {
+ $.extend(deployVmData, {
+ templateid : args.data.templateid
+ });
+ }
$.extend(deployVmData, {
hypervisor : selectedHypervisor
});
- if (args.$wizard.find('input[name=rootDiskSize]').parent().css('display') != 'none') {
- if (args.$wizard.find('input[name=rootDiskSize]').val().length > 0) {
- $.extend(deployVmData, {
- rootdisksize : args.$wizard.find('input[name=rootDiskSize]').val()
- });
- }
- }
+// Currently it is not supporting in backend
+// if (args.$wizard.find('input[name=rootDiskSize]').parent().css('display') != 'none') {
--- End diff --
please do not leave code commented in. this block should be deleted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8968: UI icon over VM snapshot...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-164514502
Step-1:
=====
Step-2:
=====
Skipped 1st and 2nd steps
Step-3:
=====
Last step
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---