You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Vincent Massol (JIRA)" <de...@geronimo.apache.org> on 2005/12/18 11:24:34 UTC
[jira] Created: (GERONIMO-1381) [Daytrader] Removed unused code
[Daytrader] Removed unused code
-------------------------------
Key: GERONIMO-1381
URL: http://issues.apache.org/jira/browse/GERONIMO-1381
Project: Geronimo
Type: Improvement
Components: sample apps
Versions: 1.0-M5
Reporter: Vincent Massol
Attachments: remove-unused-code-vmassol-20051218.patch
- The core/ subproject is just doing nothing and should be removed
- All the tests in the different modules are also doing nothing (my guess is that they were generated using the genapp plugin at some point in the past)
Attaching patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
RE: [jira] Updated: (GERONIMO-1381) [Daytrader] Removed unused code
Posted by Vincent Massol <vm...@pivolis.com>.
Hi Matt,
> -----Original Message-----
> From: Matt Hogstrom [mailto:matt@hogstrom.org]
> Sent: dimanche 18 décembre 2005 18:19
> To: dev@geronimo.apache.org
> Subject: Re: [jira] Updated: (GERONIMO-1381) [Daytrader] Removed unused
> code
>
> Vincent,
>
> Something must have gotten moved when DayTrader was moved around.
> Originally
> there was a circular dependency and the code causing this was moved to
> Core.
AFAIK there's nothing in the core... Also core doesn't sound like a very
good name to me. I think it should be possible to get away with it without
creating a new module.
Here's one idea for example:
- the ejb module could create an ejb client jar
- the wsappclient code required by the ejb module be moved to the ejb client
jar
> I'll look into this later today to see what happened.
Thanks
-Vincent
> Vincent Massol (JIRA) wrote:
> > [ http://issues.apache.org/jira/browse/GERONIMO-1381?page=all ]
> >
> > Vincent Massol updated GERONIMO-1381:
> > -------------------------------------
> >
> > Attachment: remove-unused-code-vmassol-20051218.patch
> >
> >
> >>[Daytrader] Removed unused code
> >>-------------------------------
> >>
> >> Key: GERONIMO-1381
> >> URL: http://issues.apache.org/jira/browse/GERONIMO-1381
> >> Project: Geronimo
> >> Type: Improvement
> >> Components: sample apps
> >> Versions: 1.0-M5
> >> Reporter: Vincent Massol
> >> Attachments: remove-unused-code-vmassol-20051218.patch
> >>
> >>- The core/ subproject is just doing nothing and should be removed
> >>- All the tests in the different modules are also doing nothing (my
> guess is that they were generated using the genapp plugin at some point in
> the past)
> >>Attaching patch.
> >
> >
Re: [jira] Updated: (GERONIMO-1381) [Daytrader] Removed unused code
Posted by Matt Hogstrom <ma...@hogstrom.org>.
Vincent,
Something must have gotten moved when DayTrader was moved around. Originally
there was a circular dependency and the code causing this was moved to Core.
I'll look into this later today to see what happened.
Thanks for pointing this out.
Vincent Massol (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/GERONIMO-1381?page=all ]
>
> Vincent Massol updated GERONIMO-1381:
> -------------------------------------
>
> Attachment: remove-unused-code-vmassol-20051218.patch
>
>
>>[Daytrader] Removed unused code
>>-------------------------------
>>
>> Key: GERONIMO-1381
>> URL: http://issues.apache.org/jira/browse/GERONIMO-1381
>> Project: Geronimo
>> Type: Improvement
>> Components: sample apps
>> Versions: 1.0-M5
>> Reporter: Vincent Massol
>> Attachments: remove-unused-code-vmassol-20051218.patch
>>
>>- The core/ subproject is just doing nothing and should be removed
>>- All the tests in the different modules are also doing nothing (my guess is that they were generated using the genapp plugin at some point in the past)
>>Attaching patch.
>
>
[jira] Updated: (GERONIMO-1381) [Daytrader] Removed unused code
Posted by "Vincent Massol (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1381?page=all ]
Vincent Massol updated GERONIMO-1381:
-------------------------------------
Attachment: remove-unused-code-vmassol-20051218.patch
> [Daytrader] Removed unused code
> -------------------------------
>
> Key: GERONIMO-1381
> URL: http://issues.apache.org/jira/browse/GERONIMO-1381
> Project: Geronimo
> Type: Improvement
> Components: sample apps
> Versions: 1.0-M5
> Reporter: Vincent Massol
> Attachments: remove-unused-code-vmassol-20051218.patch
>
> - The core/ subproject is just doing nothing and should be removed
> - All the tests in the different modules are also doing nothing (my guess is that they were generated using the genapp plugin at some point in the past)
> Attaching patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira