[GitHub] [daffodil] tuxji commented on a change in pull request #773: Cleanup solarcloud warning. Remove do-while(false) local block workar…

[GitBox <gi...@apache.org>]

tuxji commented on a change in pull request #773:
URL: https://github.com/apache/daffodil/pull/773#discussion_r826459513



##########
File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
##########
@@ -694,15 +694,6 @@ abstract class TestCase(testCaseXML: NodeSeq, val parent: DFDLTestSuite) {
     roundTrip: RoundTrip,
     implString: Option[String]): Unit
 
-  // Provide ability to override existing (default) tunables
-  private def retrieveTunablesCombined(existingTunables: Map[String, String], cfg: DefinedConfig) = {
-    // Note, ++ on Maps replaces any key/value pair from the left with that on the
-    // right, so key/value pairs defined in tunables overrule those defiend in
-    // the config file
-    val combined = existingTunables ++ cfg.tunablesMap
-    combined
-  }
-

Review comment:
       Your PR & commit message doesn't mention this change - is it another cleanup (removing a function that's not used anymore)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org