You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by Igor Dvorzhak <id...@google.com.INVALID> on 2018/06/26 15:49:24 UTC
HADOOP-15124 review
Hello,
I have a patch <https://issues.apache.org/jira/browse/HADOOP-15124> that
improves FileSystem.Statistics implementation and I would like to commit it.
May somebody review it?
Best regards,
Igor Dvorzhak
Re: HADOOP-15124 review
Posted by Arpit Agarwal <aa...@hortonworks.com>.
Hi Igor, it is perfectly fine to request a code review on the dev mailing list.
From: Igor Dvorzhak <id...@google.com.INVALID>
Date: Tuesday, June 26, 2018 at 9:27 PM
To: <yi...@vipshop.com>
Cc: <hd...@hadoop.apache.org>, <co...@hadoop.apache.org>
Subject: Re: HADOOP-15124 review
Hi Yiqun,
Thank you for the explanation. I didn't know that this is not appropriate and will not do so in future.
Thanks,
Igor
On Tue, Jun 26, 2018 at 7:18 PM Lin,Yiqun(vip.com<http://vip.com>) <yi...@vipshop.com>> wrote:
Hi Igor,
It’s not appropriate to ask for a review request in dev mailing list. Dev mailing list is mainly used for discussing and answering user’s questions. You can ask for the review under specific JIRA, that will be seen by committers or others. If they have time, they will help take the review.
Yiqun
Thanks
发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID<ma...@google.com.INVALID>]
发送时间: 2018年6月26日 23:52
收件人: hdfs-dev@hadoop.apache.org<ma...@hadoop.apache.org>; common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
主题: Re: HADOOP-15124 review
+common-dev@hadoop.apache.org<ma...@hadoop.apache.org>>
On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <id...@google.com>>> wrote:
Hello,
I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that improves FileSystem.Statistics implementation and I would like to commit it.
May somebody review it?
Best regards,
Igor Dvorzhak
本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！ This communication is intended only for the addressee(s) and may contain information that is privileged and confidential. You are hereby notified that, if you are not an intended recipient listed above, or an authorized employee or agent of an addressee of this communication responsible for delivering e-mail messages to an intended recipient, any dissemination, distribution or reproduction of this communication (including any attachments hereto) is strictly prohibited. If you have received this communication in error, please notify us immediately by a reply e-mail addressed to the sender and permanently delete the original e-mail communication and any attachments from all storage devices without making or otherwise retaining a copy.
Re: HADOOP-15124 review
Posted by Andrew Wang <an...@cloudera.com.INVALID>.
I think it's fine to ask for review help on the dev list, sometimes JIRAs
are missed or get stuck. It also helps sometimes to git blame the files
you're touching and see who is a likely reviewer, and then pinging them on
JIRA to ask for a review.
Igor, hopefully a committer takes interest in your JIRA and helps you get
it integrated.
Best,
Andrew
On Tue, Jun 26, 2018 at 9:27 PM Igor Dvorzhak <id...@google.com.invalid>
wrote:
> Hi Yiqun,
>
> Thank you for the explanation. I didn't know that this is not appropriate
> and will not do so in future.
>
> Thanks,
> Igor
>
>
> On Tue, Jun 26, 2018 at 7:18 PM Lin,Yiqun(vip.com) <
> yiqun01.lin@vipshop.com> wrote:
>
>> Hi Igor,
>>
>> It’s not appropriate to ask for a review request in dev mailing list. Dev
>> mailing list is mainly used for discussing and answering user’s questions.
>> You can ask for the review under specific JIRA, that will be seen by
>> committers or others. If they have time, they will help take the review.
>>
>> Yiqun
>> Thanks
>>
>> 发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID]
>> 发送时间: 2018年6月26日 23:52
>> 收件人: hdfs-dev@hadoop.apache.org; common-dev@hadoop.apache.org
>> 主题: Re: HADOOP-15124 review
>>
>> +common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
>>
>> On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <idv@google.com<mailto:
>> idv@google.com>> wrote:
>> Hello,
>>
>> I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that
>> improves FileSystem.Statistics implementation and I would like to commit it.
>>
>> May somebody review it?
>>
>> Best regards,
>> Igor Dvorzhak
>> 本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！
>> This communication is intended only for the addressee(s) and may contain
>> information that is privileged and confidential. You are hereby notified
>> that, if you are not an intended recipient listed above, or an authorized
>> employee or agent of an addressee of this communication responsible for
>> delivering e-mail messages to an intended recipient, any dissemination,
>> distribution or reproduction of this communication (including any
>> attachments hereto) is strictly prohibited. If you have received this
>> communication in error, please notify us immediately by a reply e-mail
>> addressed to the sender and permanently delete the original e-mail
>> communication and any attachments from all storage devices without making
>> or otherwise retaining a copy.
>>
>
Re: HADOOP-15124 review
Posted by Andrew Wang <an...@cloudera.com.INVALID>.
I think it's fine to ask for review help on the dev list, sometimes JIRAs
are missed or get stuck. It also helps sometimes to git blame the files
you're touching and see who is a likely reviewer, and then pinging them on
JIRA to ask for a review.
Igor, hopefully a committer takes interest in your JIRA and helps you get
it integrated.
Best,
Andrew
On Tue, Jun 26, 2018 at 9:27 PM Igor Dvorzhak <id...@google.com.invalid>
wrote:
> Hi Yiqun,
>
> Thank you for the explanation. I didn't know that this is not appropriate
> and will not do so in future.
>
> Thanks,
> Igor
>
>
> On Tue, Jun 26, 2018 at 7:18 PM Lin,Yiqun(vip.com) <
> yiqun01.lin@vipshop.com> wrote:
>
>> Hi Igor,
>>
>> It’s not appropriate to ask for a review request in dev mailing list. Dev
>> mailing list is mainly used for discussing and answering user’s questions.
>> You can ask for the review under specific JIRA, that will be seen by
>> committers or others. If they have time, they will help take the review.
>>
>> Yiqun
>> Thanks
>>
>> 发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID]
>> 发送时间: 2018年6月26日 23:52
>> 收件人: hdfs-dev@hadoop.apache.org; common-dev@hadoop.apache.org
>> 主题: Re: HADOOP-15124 review
>>
>> +common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
>>
>> On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <idv@google.com<mailto:
>> idv@google.com>> wrote:
>> Hello,
>>
>> I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that
>> improves FileSystem.Statistics implementation and I would like to commit it.
>>
>> May somebody review it?
>>
>> Best regards,
>> Igor Dvorzhak
>> 本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！
>> This communication is intended only for the addressee(s) and may contain
>> information that is privileged and confidential. You are hereby notified
>> that, if you are not an intended recipient listed above, or an authorized
>> employee or agent of an addressee of this communication responsible for
>> delivering e-mail messages to an intended recipient, any dissemination,
>> distribution or reproduction of this communication (including any
>> attachments hereto) is strictly prohibited. If you have received this
>> communication in error, please notify us immediately by a reply e-mail
>> addressed to the sender and permanently delete the original e-mail
>> communication and any attachments from all storage devices without making
>> or otherwise retaining a copy.
>>
>
Re: HADOOP-15124 review
Posted by Arpit Agarwal <aa...@hortonworks.com>.
Hi Igor, it is perfectly fine to request a code review on the dev mailing list.
From: Igor Dvorzhak <id...@google.com.INVALID>
Date: Tuesday, June 26, 2018 at 9:27 PM
To: <yi...@vipshop.com>
Cc: <hd...@hadoop.apache.org>, <co...@hadoop.apache.org>
Subject: Re: HADOOP-15124 review
Hi Yiqun,
Thank you for the explanation. I didn't know that this is not appropriate and will not do so in future.
Thanks,
Igor
On Tue, Jun 26, 2018 at 7:18 PM Lin,Yiqun(vip.com<http://vip.com>) <yi...@vipshop.com>> wrote:
Hi Igor,
It’s not appropriate to ask for a review request in dev mailing list. Dev mailing list is mainly used for discussing and answering user’s questions. You can ask for the review under specific JIRA, that will be seen by committers or others. If they have time, they will help take the review.
Yiqun
Thanks
发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID<ma...@google.com.INVALID>]
发送时间: 2018年6月26日 23:52
收件人: hdfs-dev@hadoop.apache.org<ma...@hadoop.apache.org>; common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
主题: Re: HADOOP-15124 review
+common-dev@hadoop.apache.org<ma...@hadoop.apache.org>>
On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <id...@google.com>>> wrote:
Hello,
I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that improves FileSystem.Statistics implementation and I would like to commit it.
May somebody review it?
Best regards,
Igor Dvorzhak
本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！ This communication is intended only for the addressee(s) and may contain information that is privileged and confidential. You are hereby notified that, if you are not an intended recipient listed above, or an authorized employee or agent of an addressee of this communication responsible for delivering e-mail messages to an intended recipient, any dissemination, distribution or reproduction of this communication (including any attachments hereto) is strictly prohibited. If you have received this communication in error, please notify us immediately by a reply e-mail addressed to the sender and permanently delete the original e-mail communication and any attachments from all storage devices without making or otherwise retaining a copy.
Re: HADOOP-15124 review
Posted by Igor Dvorzhak <id...@google.com.INVALID>.
Hi Yiqun,
Thank you for the explanation. I didn't know that this is not appropriate
and will not do so in future.
Thanks,
Igor
On Tue, Jun 26, 2018 at 7:18 PM Lin,Yiqun(vip.com) <yi...@vipshop.com>
wrote:
> Hi Igor,
>
> It’s not appropriate to ask for a review request in dev mailing list. Dev
> mailing list is mainly used for discussing and answering user’s questions.
> You can ask for the review under specific JIRA, that will be seen by
> committers or others. If they have time, they will help take the review.
>
> Yiqun
> Thanks
>
> 发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID]
> 发送时间: 2018年6月26日 23:52
> 收件人: hdfs-dev@hadoop.apache.org; common-dev@hadoop.apache.org
> 主题: Re: HADOOP-15124 review
>
> +common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
>
> On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <idv@google.com<mailto:
> idv@google.com>> wrote:
> Hello,
>
> I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that
> improves FileSystem.Statistics implementation and I would like to commit it.
>
> May somebody review it?
>
> Best regards,
> Igor Dvorzhak
> 本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！
> This communication is intended only for the addressee(s) and may contain
> information that is privileged and confidential. You are hereby notified
> that, if you are not an intended recipient listed above, or an authorized
> employee or agent of an addressee of this communication responsible for
> delivering e-mail messages to an intended recipient, any dissemination,
> distribution or reproduction of this communication (including any
> attachments hereto) is strictly prohibited. If you have received this
> communication in error, please notify us immediately by a reply e-mail
> addressed to the sender and permanently delete the original e-mail
> communication and any attachments from all storage devices without making
> or otherwise retaining a copy.
>
Re: HADOOP-15124 review
Posted by Igor Dvorzhak <id...@google.com.INVALID>.
Hi Yiqun,
Thank you for the explanation. I didn't know that this is not appropriate
and will not do so in future.
Thanks,
Igor
On Tue, Jun 26, 2018 at 7:18 PM Lin,Yiqun(vip.com) <yi...@vipshop.com>
wrote:
> Hi Igor,
>
> It’s not appropriate to ask for a review request in dev mailing list. Dev
> mailing list is mainly used for discussing and answering user’s questions.
> You can ask for the review under specific JIRA, that will be seen by
> committers or others. If they have time, they will help take the review.
>
> Yiqun
> Thanks
>
> 发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID]
> 发送时间: 2018年6月26日 23:52
> 收件人: hdfs-dev@hadoop.apache.org; common-dev@hadoop.apache.org
> 主题: Re: HADOOP-15124 review
>
> +common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
>
> On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <idv@google.com<mailto:
> idv@google.com>> wrote:
> Hello,
>
> I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that
> improves FileSystem.Statistics implementation and I would like to commit it.
>
> May somebody review it?
>
> Best regards,
> Igor Dvorzhak
> 本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！
> This communication is intended only for the addressee(s) and may contain
> information that is privileged and confidential. You are hereby notified
> that, if you are not an intended recipient listed above, or an authorized
> employee or agent of an addressee of this communication responsible for
> delivering e-mail messages to an intended recipient, any dissemination,
> distribution or reproduction of this communication (including any
> attachments hereto) is strictly prohibited. If you have received this
> communication in error, please notify us immediately by a reply e-mail
> addressed to the sender and permanently delete the original e-mail
> communication and any attachments from all storage devices without making
> or otherwise retaining a copy.
>
答复: HADOOP-15124 review
Posted by "Lin,Yiqun(vip.com)" <yi...@vipshop.com>.
Hi Igor,
It’s not appropriate to ask for a review request in dev mailing list. Dev mailing list is mainly used for discussing and answering user’s questions. You can ask for the review under specific JIRA, that will be seen by committers or others. If they have time, they will help take the review.
Yiqun
Thanks
发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID]
发送时间: 2018年6月26日 23:52
收件人: hdfs-dev@hadoop.apache.org; common-dev@hadoop.apache.org
主题: Re: HADOOP-15124 review
+common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <id...@google.com>> wrote:
Hello,
I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that improves FileSystem.Statistics implementation and I would like to commit it.
May somebody review it?
Best regards,
Igor Dvorzhak
本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！ This communication is intended only for the addressee(s) and may contain information that is privileged and confidential. You are hereby notified that, if you are not an intended recipient listed above, or an authorized employee or agent of an addressee of this communication responsible for delivering e-mail messages to an intended recipient, any dissemination, distribution or reproduction of this communication (including any attachments hereto) is strictly prohibited. If you have received this communication in error, please notify us immediately by a reply e-mail addressed to the sender and permanently delete the original e-mail communication and any attachments from all storage devices without making or otherwise retaining a copy.
答复: HADOOP-15124 review
Posted by "Lin,Yiqun(vip.com)" <yi...@vipshop.com>.
Hi Igor,
It’s not appropriate to ask for a review request in dev mailing list. Dev mailing list is mainly used for discussing and answering user’s questions. You can ask for the review under specific JIRA, that will be seen by committers or others. If they have time, they will help take the review.
Yiqun
Thanks
发件人: Igor Dvorzhak [mailto:idv@google.com.INVALID]
发送时间: 2018年6月26日 23:52
收件人: hdfs-dev@hadoop.apache.org; common-dev@hadoop.apache.org
主题: Re: HADOOP-15124 review
+common-dev@hadoop.apache.org<ma...@hadoop.apache.org>
On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <id...@google.com>> wrote:
Hello,
I have a patch<https://issues.apache.org/jira/browse/HADOOP-15124> that improves FileSystem.Statistics implementation and I would like to commit it.
May somebody review it?
Best regards,
Igor Dvorzhak
本电子邮件可能为保密文件。如果阁下非电子邮件所指定之收件人，谨请立即通知本人。敬请阁下不要使用、保存、复印、打印、散布本电子邮件及其内容，或将其用于其他任何目的或向任何人披露。谢谢您的合作！ This communication is intended only for the addressee(s) and may contain information that is privileged and confidential. You are hereby notified that, if you are not an intended recipient listed above, or an authorized employee or agent of an addressee of this communication responsible for delivering e-mail messages to an intended recipient, any dissemination, distribution or reproduction of this communication (including any attachments hereto) is strictly prohibited. If you have received this communication in error, please notify us immediately by a reply e-mail addressed to the sender and permanently delete the original e-mail communication and any attachments from all storage devices without making or otherwise retaining a copy.
Re: HADOOP-15124 review
Posted by Igor Dvorzhak <id...@google.com.INVALID>.
+common-dev@hadoop.apache.org
On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <id...@google.com> wrote:
> Hello,
>
> I have a patch <https://issues.apache.org/jira/browse/HADOOP-15124> that
> improves FileSystem.Statistics implementation and I would like to commit it.
>
> May somebody review it?
>
> Best regards,
> Igor Dvorzhak
>
Re: HADOOP-15124 review
Posted by Igor Dvorzhak <id...@google.com.INVALID>.
+common-dev@hadoop.apache.org
On Tue, Jun 26, 2018 at 8:49 AM Igor Dvorzhak <id...@google.com> wrote:
> Hello,
>
> I have a patch <https://issues.apache.org/jira/browse/HADOOP-15124> that
> improves FileSystem.Statistics implementation and I would like to commit it.
>
> May somebody review it?
>
> Best regards,
> Igor Dvorzhak
>