[GitHub] [apisix-ingress-controller] afzal442 commented on a diff in pull request #1809: fix: Some CRDs missing status sub-resource

["afzal442 (via GitHub)" <gi...@apache.org>]

afzal442 commented on code in PR #1809:
URL: https://github.com/apache/apisix-ingress-controller/pull/1809#discussion_r1184846849


##########
test/e2e/suite-ingress/suite-ingress-features/status.go:
##########
@@ -275,6 +275,20 @@ wrw7im4TNSAdwVX4Y1F4svJ2as5SJn5QYGAzXDixNuwzXYrpP9rzA2s=
 		assert.Contains(ginkgo.GinkgoT(), output, `status: "False"`, "status.conditions.status  is recorded")
 	})
 
+	ginkgo.It("check ApisixClusterConfig status is recorded", func() {
+		// create ApisixClusterConfig resource
+		clusterConfigName := "cluster-config-name"
+		assert.Nil(ginkgo.GinkgoT(), s.NewApisixClusterConfig(clusterConfigName, true, true), "create cluster config error")

Review Comment:
   Hey @Chever-John did you check the function definition of NewApisixClus...
   https://github.com/apache/apisix-ingress-controller/blob/2b31690fc1c4a72c211557f05dbc569bebc60246/pkg/kube/apisix_cluster_config.go#L147
   
   This takes in only obj type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org