You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Kalle Korhonen (JIRA)" <ji...@apache.org> on 2010/07/05 22:56:50 UTC
[jira] Created: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
-----------------------------------------------------------------------------------------------
Key: TAP5-1201
URL: https://issues.apache.org/jira/browse/TAP5-1201
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.0
Reporter: Kalle Korhonen
Priority: Minor
Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
"I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899779#action_12899779 ]
Hudson commented on TAP5-1201:
------------------------------
Integrated in tapestry-5.2-freestyle #173 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/173/])
TAP5-1201: PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.1
>
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen updated TAP5-1201:
---------------------------------
Attachment: TAP5-1201.patch
Apply patch to the root of tapestry-core. There's no unit test for now as I was unsure which one of these would be the best option:
1) Add a unit test to ComponentSourceImplTest
2) Create a new unit test class PageResponseRendererImplTest and implement a unit test similar to ComponentSourceImplTest.get_active_page()
3) A functional test, where?
4) This functionality shouldn't be added in, instead you should do X
It's an easy addition and I really would like to resolve this one way or another. If you think this is incorrect, I don't mind as long as you point me towards a proper solution.
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TAP5-1201)
PageResponseRenderer.render() should call
RequestGlobabls.storeActivePageName(String pageName)
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894366#action_12894366 ]
Christophe Cordenier edited comment on TAP5-1201 at 8/1/10 6:41 AM:
--------------------------------------------------------------------
Active page name is used to pre-allocates control names in Form component, but also to append loopback marker in link generated by LinkSource.
Two decent workarounds :
- Redirect instead of direct rendering
- Insert your security component request filter after the one that initializes active page ("InitializeActivePageName")
At last, the active page state should be reseted in case of exception (can be done in developer code with onException) and current active page should be changed in DefaultRequestExceptionHandler to avoid consistency problem in loopback URL.
was (Author: ccordenier):
Active page name is used to pre-allocates control names in Form component, but also to append loopback marker in LinkSource.
Two decent workarounds :
- Redirect instead of direct rendering
- Insert your security component request filter after the one that initializes active page ("InitializeActivePageName")
At last, the active page state should be reseted in case of exception (can be done in developer code with onException) and current active page should be changed in DefaultRequestExceptionHandler to avoid consistency problem in loopback URL.
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Christophe Cordenier
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1201.
--------------------------------------
Fix Version/s: 5.2.1
Resolution: Fixed
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.1
>
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899779#action_12899779 ]
Hudson commented on TAP5-1201:
------------------------------
Integrated in tapestry-5.2-freestyle #173 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/173/])
TAP5-1201: PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.1
>
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1201:
------------------------------------------
Assignee: Howard M. Lewis Ship (was: Christophe Cordenier)
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894366#action_12894366 ]
Christophe Cordenier commented on TAP5-1201:
--------------------------------------------
Active page name is used to pre-allocates control names in Form component, but also to append loopback marker in LinkSource.
Two decent workarounds :
- Redirect instead of direct rendering
- Insert your security component request filter after the one that initializes active page ("InitializeActivePageName")
At last, the active page state should be reseted in case of exception (can be done in developer code with onException) and current active page should be changed in DefaultRequestExceptionHandler to avoid consistency problem in loopback URL.
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Christophe Cordenier
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TAP5-1201)
PageResponseRenderer.render() should call
RequestGlobabls.storeActivePageName(String pageName)
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894366#action_12894366 ]
Christophe Cordenier edited comment on TAP5-1201 at 8/1/10 6:41 AM:
--------------------------------------------------------------------
Active page name is used to pre-allocates control names in Form component, but also to append loopback marker in link generated by LinkSource.
Two decent workarounds :
- Redirect instead of direct rendering
- Insert your security component request filter after the one that initializes active page ("InitializeActivePageName")
At last, the active page state should be reseted in case of exception (can be done in developer code with onException) and current active page should be changed in DefaultRequestExceptionHandler to avoid consistency problem in loopback URL.
was (Author: ccordenier):
Active page name is used to pre-allocates control names in Form component, but also to append loopback marker in LinkSource.
Two decent workarounds :
- Redirect instead of direct rendering
- Insert your security component request filter after the one that initializes active page ("InitializeActivePageName")
At last, the active page state should be reseted in case of exception (can be done in developer code with onException) and current active page should be changed in DefaultRequestExceptionHandler to avoid consistency problem in loopback URL.
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Christophe Cordenier
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAP5-1201:
------------------------------------------
Assignee: Howard M. Lewis Ship (was: Christophe Cordenier)
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Cordenier reassigned TAP5-1201:
------------------------------------------
Assignee: Christophe Cordenier
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Christophe Cordenier
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1201.
--------------------------------------
Fix Version/s: 5.2.1
Resolution: Fixed
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 5.2.1
>
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen updated TAP5-1201:
---------------------------------
Attachment: TAP5-1201.patch
Apply patch to the root of tapestry-core. There's no unit test for now as I was unsure which one of these would be the best option:
1) Add a unit test to ComponentSourceImplTest
2) Create a new unit test class PageResponseRendererImplTest and implement a unit test similar to ComponentSourceImplTest.get_active_page()
3) A functional test, where?
4) This functionality shouldn't be added in, instead you should do X
It's an easy addition and I really would like to resolve this one way or another. If you think this is incorrect, I don't mind as long as you point me towards a proper solution.
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894366#action_12894366 ]
Christophe Cordenier commented on TAP5-1201:
--------------------------------------------
Active page name is used to pre-allocates control names in Form component, but also to append loopback marker in LinkSource.
Two decent workarounds :
- Redirect instead of direct rendering
- Insert your security component request filter after the one that initializes active page ("InitializeActivePageName")
At last, the active page state should be reseted in case of exception (can be done in developer code with onException) and current active page should be changed in DefaultRequestExceptionHandler to avoid consistency problem in loopback URL.
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Christophe Cordenier
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TAP5-1201) PageResponseRenderer.render() should
call RequestGlobabls.storeActivePageName(String pageName)
Posted by "Christophe Cordenier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Cordenier reassigned TAP5-1201:
------------------------------------------
Assignee: Christophe Cordenier
> PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)
> -----------------------------------------------------------------------------------------------
>
> Key: TAP5-1201
> URL: https://issues.apache.org/jira/browse/TAP5-1201
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Kalle Korhonen
> Assignee: Christophe Cordenier
> Priority: Minor
> Attachments: TAP5-1201.patch
>
>
> Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
> "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.