You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/05 17:36:33 UTC

[GitHub] [flink] zentol commented on a change in pull request #8630: [FLINK-12667][runtime] Add JobID to TaskExecutorGateway#releasePartitions

zentol commented on a change in pull request #8630: [FLINK-12667][runtime] Add JobID to TaskExecutorGateway#releasePartitions
URL: https://github.com/apache/flink/pull/8630#discussion_r290854544
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ##########
 @@ -687,7 +687,7 @@ else if (current == RUNNING || current == DEPLOYING) {
 			}
 
 			else if (current == FINISHED || current == FAILED) {
-				// nothing to do any more. finished failed before it could be cancelled.
+				// nothing to do any more. finished/failed before it could be cancelled.
 
 Review comment:
   thats why it is in a separate hotfix commit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services