You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/01 20:40:16 UTC

[GitHub] [incubator-tvm] wpan11nv opened a new pull request #5207: [IR][Debug] Add dump and print for debugging (NFC)

wpan11nv opened a new pull request #5207: [IR][Debug] Add dump and print for debugging (NFC)
URL: https://github.com/apache/incubator-tvm/pull/5207
 
 
   - Add two utility functions for debugging. With this change,
     developers could use
   
     `print op->dump()` or 'print op->print()`
   
     inside a debugger (lldb or gdb). Object op could be either
     of type Object or ObjectRef.
   
     Note that the existing tvm::Dump(ref) does not work on
     objects of type tvm::Object. Sometimes lldb cannot locate
     this Dump function inside a visitor context.
   
   Signed-off-by: Wei Pan <we...@nvidia.com>
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)
URL: https://github.com/apache/incubator-tvm/pull/5207#issuecomment-607486299
 
 
   Ideally we want to minimize the number of member functions being provide. Given that this is an utility function, it would be better to make it as a public function rather than a member function. Perhaps we should simply fix `tvm::Dump`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)
URL: https://github.com/apache/incubator-tvm/pull/5207#issuecomment-607590309
 
 
   Thanks @wpan11nv 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)
URL: https://github.com/apache/incubator-tvm/pull/5207#issuecomment-607486299
 
 
   Ideally we want to minimize the number of member functions being provide. Given that this is an utility function, it would be better to make it as a public global function rather than a member function. Perhaps we should simply fix `tvm::Dump`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] wpan11nv commented on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)

Posted by GitBox <gi...@apache.org>.
wpan11nv commented on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)
URL: https://github.com/apache/incubator-tvm/pull/5207#issuecomment-607504429
 
 
   > Ideally we want to minimize the number of member functions being provide. Given that this is an utility function, it would be better to make it as a public global function rather than a member function. Perhaps we should simply fix `tvm::Dump`.
   
   That is ok to me.  Minor addition to Dump works fine too.  FYI, vscode watch cannot find tvm::Dump, but lldb command line works.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5207: [IR][Debug] Add dump and print for debugging (NFC)
URL: https://github.com/apache/incubator-tvm/pull/5207#issuecomment-607486299
 
 
   Given that this is an utility function, it would be better to make it as a public function rather than a member function. Perhaps we should simply fix tvm::Dump

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #5207: [IR][Debug] Add dump and print for debugging (NFC)

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5207: [IR][Debug] Add dump and print for debugging (NFC)
URL: https://github.com/apache/incubator-tvm/pull/5207
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services