[GitHub] [arrow] joosthooz commented on a diff in pull request #14414: ARROW-17991: [Python] [C++] Adding support for IpcWriteOptions to the dataset ipc file writer

[GitBox <gi...@apache.org>]

joosthooz commented on code in PR #14414:
URL: https://github.com/apache/arrow/pull/14414#discussion_r996980474


##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -3241,6 +3241,40 @@ def test_feather_format(tempdir, dataset_reader):
         dataset_reader.to_table(ds.dataset(basedir, format="feather"))
 
 
+@pytest.mark.pandas
+@pytest.mark.parametrize("compression", [
+    "lz4",
+    "zstd",
+    "brotli"  # not supported
+])
+def test_feather_format_compressed(tempdir, compression, dataset_reader):
+    table = pa.table({'a': pa.array([1, 2, 3], type="int8"),
+                      'b': pa.array([.1, .2, .3], type="float64")})
+
+    basedir = tempdir / "feather_dataset"
+    basedir.mkdir()
+    file_format = ds.IpcFileFormat()
+    if compression == "brotli":
+        with pytest.raises(ValueError, match="Compression type"):
+            write_options = file_format.make_write_options(compression=compression)
+        with pytest.raises(ValueError, match="Compression type"):
+            codec = pa.Codec(compression)
+            write_options = file_format.make_write_options(compression=codec)
+        return
+
+    write_options = file_format.make_write_options(compression=compression)
+    ds.write_dataset(
+        table,
+        str(basedir / "data.arrow"),
+        format=file_format,
+        file_options=write_options
+    )

Review Comment:
   Yes, I noticed that too. But as a proxy test I could create a bit larger table with lots of zeroes and check if the filesize is smaller!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org