You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/07 13:47:53 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #10468:
[FLINK-14649][table sql / api] Flatten all the connector properties keys to
make it easy to configure in DDL
JingsongLi commented on a change in pull request #10468: [FLINK-14649][table sql / api] Flatten all the connector properties keys to make it easy to configure in DDL
URL: https://github.com/apache/flink/pull/10468#discussion_r355120288
##########
File path: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryTestBase.java
##########
@@ -227,6 +296,74 @@ public void testTableSink() {
assertTrue(getExpectedFlinkKafkaProducer().isAssignableFrom(streamMock.sinkFunction.getClass()));
}
+ @Test
+ public void testTableSinkWithLegacyProperties() {
+ // prepare parameters for Kafka table sink
+
Review comment:
Remove empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services