You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by eraffenne <gi...@git.apache.org> on 2015/05/26 14:58:33 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
GitHub user eraffenne opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/83
ZEPPELIN-87: Data order altered in bar chart
Fix data order for x axis.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keedio/incubator-zeppelin feature/x-axis-orderby
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit c8973d4d35227d824d5ba00dbc6b3085e6781368
Author: Emmanuelle Raffenne <er...@keedio.com>
Date: 2015-05-08T11:04:46Z
Add row index to the rows of pivot(data)
commit e49883af2b11dcb4b27694a9111469c1e517c705
Author: Emmanuelle Raffenne <er...@keedio.com>
Date: 2015-05-08T12:58:34Z
Modify pivotDataToD3ChartFormat() to process data.rows as an array
commit 4ae0541534045603d14ec24990618382c9502017
Author: Emmanuelle Raffenne <er...@keedio.com>
Date: 2015-05-21T14:25:42Z
Reduce verbosity
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-108202157
@galleon It's early stage for GSOC so no direct PR to Zeppelin repository yet.
In a couple of weeks there should be somewhere I could point you to.
You could also check the angular interpreter which allow you to include any type of view, the documentation was not made yet, but it was merged and you can find examples in the PR itself: https://github.com/apache/incubator-zeppelin/pull/27
Otherwise #56 is changing the code structure and optimizing the code for Zeppelin-web hopefully it will be done soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by galleon <gi...@git.apache.org>.
Github user galleon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-108199434
Hi,
You mentioned changes in the pivot through GSOC, is there any PR presenting that work? My interest is looking into new visualization (maps especially) so there is obviously a link ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by eraffenne <gi...@git.apache.org>.
Github user eraffenne commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-107423081
Yes, the data is ordered accordingly to the query.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-107391978
Hi,
After trying this branch, my understanding is that the data is now ordered accordingly to the query, is that right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-108160293
Hi,
I'm not really for merging this PR for multiple reasons:
* Auto ordering can sometimes be helpful at the moment (even if being able to order we want is the goal)
* There is no replacement for ordering outside of the query order
* We are working as part of the Spring Cleaning PR and GSOC into replacing the pivot and ultimately integrating ordering inside of it. (Pivot refactoring coming soon at least), so it would add more cleaning/possible conflicts for us
If however others were inclined to merge:
* Need to remove the commented console.log
This could be eventually merged, and it would be squashed in 3-4weeks maybe. The decision is more about, if people are okay with losing the auto ordering during that time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by galleon <gi...@git.apache.org>.
Github user galleon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-108619407
@corneadoug I have noticed #56 and I will wait for it to be pushed before contributing.
#27 is impressive and I played a bit with the concept today. Would that allow me to create maps based on D3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-137082056
@lucarosellini #56 scope was shortened because of all the changes it was bringing to the project.
So in the end, there was no clear separation of paragraph.js or modification of the pivot, which means the issue still exist.
So far, my feeling was that it was just moving the ordering problem to other cases. (post pivot)
I can run a few test on this PR again, to double check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-87: Data order altered i...
Posted by lucarosellini <gi...@git.apache.org>.
Github user lucarosellini commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/83#issuecomment-137075097
@corneadoug now that #56 has finally been merged we're still experiencing the data order issue fixed by this PR. Is there a chance this will be merged into master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---