You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2009/02/19 00:45:02 UTC

[jira] Updated: (SOLR-952) duplicated code in (Default)SolrHighlighter and HighlightingUtils

     [ https://issues.apache.org/jira/browse/SOLR-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-952:
--------------------------

    Description: 

A large quantity of code is duplicated between the deprecated HighlightingUtils class and the newer SolrHighlighter and DefaultSolrHighlighter (which have been getting bug fixes and enhancements). The Utils class is no longer used anywhere in Solr, but people writing plugins may be taking advantage of it, so it should be cleaned up.

  was:
The class TokenOrderingFilter is defined, with identical text, both in org/apache/solr/highlight/DefaultSolrHighlighter.java and org/apache/solr/util/HighlightingUtils.java. I assume this is not good, from a code maintenance perspective.

Verified this in Solr trunk r733155.

        Summary: duplicated code in (Default)SolrHighlighter and HighlightingUtils  (was: TokenOrderingFilter class is defined in more than one java file)

updated summary and description to point out that TokenOrderingFilter is just a small part of the code duplication that seems to have been left behind from an incomplete refactoring of HighlightingUtils.  

> duplicated code in (Default)SolrHighlighter and HighlightingUtils
> -----------------------------------------------------------------
>
>                 Key: SOLR-952
>                 URL: https://issues.apache.org/jira/browse/SOLR-952
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>    Affects Versions: 1.4
>            Reporter: Chris Harris
>            Priority: Minor
>
> A large quantity of code is duplicated between the deprecated HighlightingUtils class and the newer SolrHighlighter and DefaultSolrHighlighter (which have been getting bug fixes and enhancements). The Utils class is no longer used anywhere in Solr, but people writing plugins may be taking advantage of it, so it should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.