[GitHub] [hbase] Apache9 commented on pull request #1601: [DRAFT] Make HedgedRpcChannel real async

[GitBox <gi...@apache.org>]

Apache9 commented on pull request #1601:
URL: https://github.com/apache/hbase/pull/1601#issuecomment-622940693


   In general, for the implementation for HedgedRpcChannel, I think a better solution is to wrap several RpcChannels as the callMethod method is asynchronous.
   
   >  // ** WARN ** This is a blocking call if the underlying connection for the rpc client is
           // a blocking implementation (ex: BlockingRpcConnection). That essentially serializes all
           // the write calls. Handling blocking connection means that this should be run in a separate
           // thread and hence more code complexity. Is it ok to handle only non-blocking connections?
   
   The comment in code is incorrect, even for BlockingRpcConnection, the callMethod is still asynchronous...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org