You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@marmotta.apache.org by Sergio Fernández <wi...@apache.org> on 2015/04/08 11:58:51 UTC

Re: [1/4] marmotta git commit: [MARMOTTA-607] empty method with no effect, resolves startup issue with custom launcher.

I guess such change in a core class needs further discussion...

On Wed, Apr 8, 2015 at 11:45 AM, <rp...@apache.org> wrote:

> Repository: marmotta
> Updated Branches:
>   refs/heads/develop 3653f4bb6 -> e5eb3a1c1
>
>
> [MARMOTTA-607] empty method with no effect, resolves startup issue with
> custom launcher.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/marmotta/repo
> Commit: http://git-wip-us.apache.org/repos/asf/marmotta/commit/31360d44
> Tree: http://git-wip-us.apache.org/repos/asf/marmotta/tree/31360d44
> Diff: http://git-wip-us.apache.org/repos/asf/marmotta/diff/31360d44
>
> Branch: refs/heads/develop
> Commit: 31360d444ee0a59371a12b2a792d7f1ba88e42f2
> Parents: 055e9ec
> Author: Raffaele Palmieri <rp...@apache.org>
> Authored: Tue Apr 7 18:37:31 2015 +0200
> Committer: Raffaele Palmieri <rp...@apache.org>
> Committed: Tue Apr 7 18:37:31 2015 +0200
>
> ----------------------------------------------------------------------
>  .../platform/core/services/jaxrs/InterceptorServiceImpl.java     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/marmotta/blob/31360d44/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> ----------------------------------------------------------------------
> diff --git
> a/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> b/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> index a9f71bf..d05b5d0 100644
> ---
> a/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> +++
> b/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> @@ -65,9 +65,9 @@ public class InterceptorServiceImpl implements
> InterceptorService {
>          }
>      }
>
> -    // trigger startup once configuration service is finished with
> initialisation
> +    /*// trigger startup once configuration service is finished with
> initialisation
>      protected void initEvent(@Observes SystemStartupEvent e) {
>
> -    }
> +    }*/
>
>  }
>
>


-- 
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: sergio.fernandez@redlink.co
w: http://redlink.co

Re: [1/4] marmotta git commit: [MARMOTTA-607] empty method with no effect, resolves startup issue with custom launcher.

Posted by Raffaele Palmieri <ra...@gmail.com>.
Hi, it should be a classpath problem, so I am going to revert commit, but
the complexity of core module remains and some errors can be verified only
at runtime.
I think that some refactoring needs, specially for core modules,
cheers,
Raffaele.

2015-04-08 11:58 GMT+02:00 Sergio Fernández <wi...@apache.org>:

> I guess such change in a core class needs further discussion...
>
> On Wed, Apr 8, 2015 at 11:45 AM, <rp...@apache.org> wrote:
>
> > Repository: marmotta
> > Updated Branches:
> >   refs/heads/develop 3653f4bb6 -> e5eb3a1c1
> >
> >
> > [MARMOTTA-607] empty method with no effect, resolves startup issue with
> > custom launcher.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/marmotta/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/marmotta/commit/31360d44
> > Tree: http://git-wip-us.apache.org/repos/asf/marmotta/tree/31360d44
> > Diff: http://git-wip-us.apache.org/repos/asf/marmotta/diff/31360d44
> >
> > Branch: refs/heads/develop
> > Commit: 31360d444ee0a59371a12b2a792d7f1ba88e42f2
> > Parents: 055e9ec
> > Author: Raffaele Palmieri <rp...@apache.org>
> > Authored: Tue Apr 7 18:37:31 2015 +0200
> > Committer: Raffaele Palmieri <rp...@apache.org>
> > Committed: Tue Apr 7 18:37:31 2015 +0200
> >
> > ----------------------------------------------------------------------
> >  .../platform/core/services/jaxrs/InterceptorServiceImpl.java     | 4
> ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/marmotta/blob/31360d44/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> > ----------------------------------------------------------------------
> > diff --git
> >
> a/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> >
> b/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> > index a9f71bf..d05b5d0 100644
> > ---
> >
> a/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> > +++
> >
> b/platform/marmotta-core/src/main/java/org/apache/marmotta/platform/core/services/jaxrs/InterceptorServiceImpl.java
> > @@ -65,9 +65,9 @@ public class InterceptorServiceImpl implements
> > InterceptorService {
> >          }
> >      }
> >
> > -    // trigger startup once configuration service is finished with
> > initialisation
> > +    /*// trigger startup once configuration service is finished with
> > initialisation
> >      protected void initEvent(@Observes SystemStartupEvent e) {
> >
> > -    }
> > +    }*/
> >
> >  }
> >
> >
>
>
> --
> Sergio Fernández
> Partner Technology Manager
> Redlink GmbH
> m: +43 6602747925
> e: sergio.fernandez@redlink.co
> w: http://redlink.co
>