You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/31 03:54:54 UTC
[GitHub] [dubbo-go] wenxuwan opened a new pull request #1118: fix provider init fail
wenxuwan opened a new pull request #1118:
URL: https://github.com/apache/dubbo-go/pull/1118
**What this PR does**:
fix provider init failed and add ut for setDefaultValue function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1118: fix provider init fail
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1118:
URL: https://github.com/apache/dubbo-go/pull/1118#discussion_r604596052
##########
File path: config/config_loader.go
##########
@@ -117,7 +117,7 @@ func setDefaultValue(target interface{}) {
Address: "127.0.0.1:2181",
}
switch target.(type) {
- case ProviderConfig:
+ case *ProviderConfig:
Review comment:
case ProviderConfig, *ProviderConfig:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #1118: fix provider init fail
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on a change in pull request #1118:
URL: https://github.com/apache/dubbo-go/pull/1118#discussion_r604649386
##########
File path: config/config_loader.go
##########
@@ -117,7 +117,7 @@ func setDefaultValue(target interface{}) {
Address: "127.0.0.1:2181",
}
switch target.(type) {
- case ProviderConfig:
Review comment:
The function will change the value in ProviderConfig, so should be *ProviderConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1118: add ut for config_loader file
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1118:
URL: https://github.com/apache/dubbo-go/pull/1118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1118: fix provider init fail
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1118:
URL: https://github.com/apache/dubbo-go/pull/1118#discussion_r604596276
##########
File path: config/config_loader.go
##########
@@ -117,7 +117,7 @@ func setDefaultValue(target interface{}) {
Address: "127.0.0.1:2181",
}
switch target.(type) {
- case ProviderConfig:
Review comment:
case *ProviderConfig, ProviderConfig:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org