You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/13 09:06:24 UTC
[GitHub] [superset] NishantSinghChandel opened a new issue, #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
NishantSinghChandel opened a new issue, #21799:
URL: https://github.com/apache/superset/issues/21799
A clear and concise description of what the bug is.
I am getting module not found error, when running without docker, setting up backend and frontend as mentioned in contributing.md.
#### How to reproduce the bug
1. Local setup using contibuting.md, Running superset using proxy server followed instructions on contibuting.md. ,
2. After setting up reverse proxy server, i tried to run npm run dev-server
3. I got the above error with black screen. After closing this the project is working as expected, but on refresh the error shows up again.
4. See error
<img width="1776" alt="Screenshot 2022-10-13 at 12 48 59 PM" src="https://user-images.githubusercontent.com/17858766/195529763-fe8ef2c2-01ae-4422-b768-94b3999bfcdc.png">
### Expected results
what you expected to happen.
It must run without showing black screen full of error.
### Actual results
what actually happens.
It shows black screen.
#### Screenshots
If applicable, add screenshots to help explain your problem.
Added above
### Environment
(please complete the following information):
- browser type and version: Chrome Version 106.0.5249.119
- superset version: `superset version` Superset 0.0.0-dev
- python version: `python --version` Python 3.9.7
- node.js version: `node -v` v16.17.0 (npm v8.15.0)
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ yes] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ yes] I have reproduced the issue with at least the latest released version of superset.
- [yes ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] abhiramvad commented on issue #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
Posted by "abhiramvad (via GitHub)" <gi...@apache.org>.
abhiramvad commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-1556180900
> npm install currencyformatter.js --save
This works for me. Why is this not added to package.json if it's a required dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] SamarinDV commented on issue #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
Posted by GitBox <gi...@apache.org>.
SamarinDV commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-1317561661
Hi! try to install currencyformatter.js into plugin\plugin-chart-handlebars
npm install currencyformatter.js --save
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Module not found: Error: Can't resolve 'currencyformatter.js' [superset]
Posted by "lscheibel (via GitHub)" <gi...@apache.org>.
lscheibel commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-2058399822
Hi, no this is not resolved yet.
- plugin-chart-handlebars is missing dependency "currencyformatter.js" which is listed as a peer-dependency of "just-handlebars-helpers" here https://github.com/leapfrogtechnology/just-handlebars-helpers/blob/main/package.json
- plugin-chart-word-cloud is missing dependency "global-box" as stated here https://www.npmjs.com/package/encodable
I can submit a PR later this week, but I would also like to discuss pinning the dependency versions in the package.json file as this is largely a symptom of inconsistent dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NishantSinghChandel commented on issue #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
Posted by "NishantSinghChandel (via GitHub)" <gi...@apache.org>.
NishantSinghChandel commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-1420630844
> Hi! try to install currencyformatter.js into plugin\plugin-chart-handlebars npm install currencyformatter.js --save
It worked. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NishantSinghChandel commented on issue #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
Posted by "NishantSinghChandel (via GitHub)" <gi...@apache.org>.
NishantSinghChandel commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-1420646305
It still happen after installing currencyformatter.js @SamarinDV. Reopening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Module not found: Error: Can't resolve 'currencyformatter.js' [superset]
Posted by "lscheibel (via GitHub)" <gi...@apache.org>.
lscheibel commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-2067684509
Actually nevermind, @NishantSinghChandel can you check if you ran `npm install` with the legacy-peer-deps flag enabled? It might be in your global NPM config (you can check with `npm config ls`). This would cause NPM to skip installing the peer-dependencies, resulting in the runtime errors above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NishantSinghChandel commented on issue #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
Posted by "NishantSinghChandel (via GitHub)" <gi...@apache.org>.
NishantSinghChandel commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-1420649111
<img width="1602" alt="Screenshot 2023-02-07 at 4 50 55 PM" src="https://user-images.githubusercontent.com/17858766/217232321-01c39e2e-0664-48b7-b58b-c80e95f2f198.png">
To Fix the issue I goto the same path as error and change currencyFormatter.js to currency-formatter.js. And the error popup vanish.
PATH - ./plugins/plugin-chart-handlebars/node_modules/just-handlebars-helpers/lib/helpers/formatters.js
step1: cd superset-frontend/plugins/plugin-chart-handlebars/node_modules/just-handlebars-helpers/lib/helpers/
step2: nano formatter.js
step3: change currencyFormatter.js to currency-formatter.js as shown in ss.
<img width="777" alt="Screenshot 2023-02-07 at 4 58 11 PM" src="https://user-images.githubusercontent.com/17858766/217233139-9be39642-a3c9-443c-b4c6-c0e86548a6ef.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] NishantSinghChandel closed issue #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
Posted by "NishantSinghChandel (via GitHub)" <gi...@apache.org>.
NishantSinghChandel closed issue #21799: Module not found: Error: Can't resolve 'currencyformatter.js'
URL: https://github.com/apache/superset/issues/21799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Module not found: Error: Can't resolve 'currencyformatter.js' [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #21799:
URL: https://github.com/apache/superset/issues/21799#issuecomment-1974866341
Is anyone still facing this? Seems like a trivial problem to open a PR for this, but assuming it's long resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org