You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/10/14 14:44:13 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #3943: [ZEPPELIN-5096] Error message for K8s launcher and Pending Status Improvement

Reamer opened a new pull request #3943:
URL: https://github.com/apache/zeppelin/pull/3943


   ### What is this PR for?
   This PR includes:
    - an error message from K8s launcher to help users understand why the Pod won't start
    - give the option to disable the timeout handling during the initial pod lifecycle phase `pending`
   
   ### What type of PR is it?
    - Improvement
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5096
   
   ### How should this be tested?
   * Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/735737408
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3943: [ZEPPELIN-5096] Error message for K8s launcher and Pending Status Improvement

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3943:
URL: https://github.com/apache/zeppelin/pull/3943#issuecomment-711788549


   If there are no further comments, I will merge this PR into Master and Branch-0.9 on Wednesday (21.10.2020)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on a change in pull request #3943: [ZEPPELIN-5096] Error message for K8s launcher and Pending Status Improvement

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #3943:
URL: https://github.com/apache/zeppelin/pull/3943#discussion_r506094531



##########
File path: zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java
##########
@@ -223,6 +245,13 @@ public boolean isRunning() {
     return false;
   }
 
+  public String getPodPhase() {
+    Pod pod = client.pods().inNamespace(namespace).withName(podName).get();
+    if (pod != null) {
+      return pod.getStatus().getPhase();
+    }
+    return "Unkown";

Review comment:
       Thanks for the hint, I have corrected that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3943: [ZEPPELIN-5096] Error message for K8s launcher and Pending Status Improvement

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #3943:
URL: https://github.com/apache/zeppelin/pull/3943#discussion_r505977931



##########
File path: zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java
##########
@@ -223,6 +245,13 @@ public boolean isRunning() {
     return false;
   }
 
+  public String getPodPhase() {
+    Pod pod = client.pods().inNamespace(namespace).withName(podName).get();
+    if (pod != null) {
+      return pod.getStatus().getPhase();
+    }
+    return "Unkown";

Review comment:
       typo




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3943: [ZEPPELIN-5096] Error message for K8s launcher and Pending Status Improvement

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3943:
URL: https://github.com/apache/zeppelin/pull/3943


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org