You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Gonzalo Aguilar Delgado <ga...@aguilardelgado.com> on 2015/10/08 12:23:30 UTC
Bugs and SSL/TLS implementation
Hi all,
I just opened two issues to track down a little bit of the c_glib
development.
https://issues.apache.org/jira/browse/THRIFT-3370 Tracks a problem on
the android ndk compilation.
https://issues.apache.org/jira/browse/THRIFT-3369 Tries to manage
TLS/SSL development.
I don't know if this (the second one mainly) can be reviewed for the
next version of thrift. As it's a good feature to have
around.
I will implement meanwhile what's missing on that patch. Is it possible
to have access to the repo for writing? So I can
create a new branch to work on.
Best regards,
Re: Bugs and SSL/TLS implementation
Posted by Randy Abernethy <ra...@gmail.com>.
Hey Gonzalo,
There was a time not too long ago when only Jira attached patches were
accepted but we now also take Jira attached pull requests. More here:
https://thrift.apache.org/docs/HowToContribute
Best,
Randy
On Thu, Oct 8, 2015 at 8:48 AM, Gonzalo Aguilar Delgado <
gaguilar@aguilardelgado.com> wrote:
> Hi Randy,
>
> But the apache rules specify to upload a patch done with git and upload to
> thrift. That's what I did.
>
> I will try the pull request.
>
> Best regards,
>
> El 08/10/15 a las 14:53, Randy Abernethy escribió:
>
> Hello Gonzalo,
>>
>> You can head over to https://github.com/apache/thrift and fork a copy of
>> the Thrift repo to work on. When you have your patch ready you can submit
>> a
>> pull request to have it merged.
>>
>> Info:
>> https://help.github.com/articles/fork-a-repo/
>> https://help.github.com/articles/creating-a-pull-request/
>> https://help.github.com/articles/using-pull-requests/
>>
>>
>> Best,
>> Randy
>>
>> On Thu, Oct 8, 2015 at 3:23 AM, Gonzalo Aguilar Delgado <
>> gaguilar@aguilardelgado.com> wrote:
>>
>> Hi all,
>>>
>>> I just opened two issues to track down a little bit of the c_glib
>>> development.
>>>
>>>
>>> https://issues.apache.org/jira/browse/THRIFT-3370 Tracks a problem on
>>> the
>>> android ndk compilation.
>>> https://issues.apache.org/jira/browse/THRIFT-3369 Tries to manage
>>> TLS/SSL
>>> development.
>>>
>>> I don't know if this (the second one mainly) can be reviewed for the next
>>> version of thrift. As it's a good feature to have
>>> around.
>>>
>>> I will implement meanwhile what's missing on that patch. Is it possible
>>> to
>>> have access to the repo for writing? So I can
>>> create a new branch to work on.
>>>
>>>
>>> Best regards,
>>>
>>>
>
Re: Bugs and SSL/TLS implementation
Posted by Gonzalo Aguilar Delgado <ga...@aguilardelgado.com>.
Hi Randy,
But the apache rules specify to upload a patch done with git and upload
to thrift. That's what I did.
I will try the pull request.
Best regards,
El 08/10/15 a las 14:53, Randy Abernethy escribió:
> Hello Gonzalo,
>
> You can head over to https://github.com/apache/thrift and fork a copy of
> the Thrift repo to work on. When you have your patch ready you can submit a
> pull request to have it merged.
>
> Info:
> https://help.github.com/articles/fork-a-repo/
> https://help.github.com/articles/creating-a-pull-request/
> https://help.github.com/articles/using-pull-requests/
>
>
> Best,
> Randy
>
> On Thu, Oct 8, 2015 at 3:23 AM, Gonzalo Aguilar Delgado <
> gaguilar@aguilardelgado.com> wrote:
>
>> Hi all,
>>
>> I just opened two issues to track down a little bit of the c_glib
>> development.
>>
>>
>> https://issues.apache.org/jira/browse/THRIFT-3370 Tracks a problem on the
>> android ndk compilation.
>> https://issues.apache.org/jira/browse/THRIFT-3369 Tries to manage TLS/SSL
>> development.
>>
>> I don't know if this (the second one mainly) can be reviewed for the next
>> version of thrift. As it's a good feature to have
>> around.
>>
>> I will implement meanwhile what's missing on that patch. Is it possible to
>> have access to the repo for writing? So I can
>> create a new branch to work on.
>>
>>
>> Best regards,
>>
Re: Bugs and SSL/TLS implementation
Posted by Randy Abernethy <ra...@gmail.com>.
Hello Gonzalo,
You can head over to https://github.com/apache/thrift and fork a copy of
the Thrift repo to work on. When you have your patch ready you can submit a
pull request to have it merged.
Info:
https://help.github.com/articles/fork-a-repo/
https://help.github.com/articles/creating-a-pull-request/
https://help.github.com/articles/using-pull-requests/
Best,
Randy
On Thu, Oct 8, 2015 at 3:23 AM, Gonzalo Aguilar Delgado <
gaguilar@aguilardelgado.com> wrote:
> Hi all,
>
> I just opened two issues to track down a little bit of the c_glib
> development.
>
>
> https://issues.apache.org/jira/browse/THRIFT-3370 Tracks a problem on the
> android ndk compilation.
> https://issues.apache.org/jira/browse/THRIFT-3369 Tries to manage TLS/SSL
> development.
>
> I don't know if this (the second one mainly) can be reviewed for the next
> version of thrift. As it's a good feature to have
> around.
>
> I will implement meanwhile what's missing on that patch. Is it possible to
> have access to the repo for writing? So I can
> create a new branch to work on.
>
>
> Best regards,
>