You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2007/08/15 03:40:31 UTC
DO NOT REPLY [Bug 43125] New: - Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
Summary: Support for non-bitmap pictures in
HSSFWorkbook.getAllPictures()
Product: POI
Version: 3.0
Platform: Other
OS/Version: other
Status: NEW
Severity: enhancement
Priority: P2
Component: HSSF
AssignedTo: dev@poi.apache.org
ReportedBy: trejkaz@trypticon.org
The support I provided for getting pictures was only getting out the bitmaps.
The following patch adds support for any kind of image stored in a BLIP.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
trejkaz@trypticon.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20663|0 |1
is obsolete| |
------- Additional Comments From trejkaz@trypticon.org 2007-08-14 20:27 -------
Created an attachment (id=20666)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20666&action=view)
Proposed patch, v2
Here's a better version, defines an EscherMetafileBlip class which properly
handles at least EMF.
I can't find the record IDs for WMF and PICT anywhere. If someone could create
a file with those types of BLIP inside, I would be grateful, but even if I put
a WMF into the document on my copy of Word, I seem to get an EMF.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
------- Additional Comments From trejkaz@trypticon.org 2007-08-14 18:48 -------
On second thought it looks like this will need a little more work. The binary
exposed is in itself not the picture data. I'll get a better patch in once I've
figured out how this F01A blip works.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
------- Additional Comments From dfisher@jmlafferty.com 2007-08-14 20:41 -------
I meant WMF, not EMF.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
------- Additional Comments From trejkaz@trypticon.org 2007-08-14 18:40 -------
Created an attachment (id=20663)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20663&action=view)
Proposed patch
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
------- Additional Comments From yegor@dinom.ru 2007-08-26 09:01 -------
I reviewed and committed the patch. The code works fine for EMF and WMF but
fails on PICT.
See how I read PICT in org.apache.poi.hslf.blip.PICT. The header is different
from WMF/EMF and you
should skip different number of bytes before inflating the data.
How did you test your code? Would you provide a unit test?
I provided two xls files:
src\testcases\org\apache\poi\hssf\data\SimpleWithImages.xls
Created on Windows. Contains JPEG, PNG, EMF and WMF.
src\testcases\org\apache\poi\hssf\data\SimpleWithImages-mac.xls
Created on MAC. Contains JPEG, PNG and PICT.
The point is that MS Office for MAC automatically converts WMF and EMF into
PICT and vise versa -
MS Office for Windows automatically stores PICT as WMF. So there are two test
files.
All the pictures can be found in
src\scratchpad\testcases\org\apache\poi\hslf\data\
src\testcases\org\apache\poi\hssf\usermodel\TestHSSFPictureData.java
Add your test logic in this file. It already contains tests for JPEG and PNG.
Regards,
Yegor
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
trejkaz@trypticon.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
Summary|Support for non-bitmap |[PATCH] Support for non-
|pictures in |bitmap pictures in
|HSSFWorkbook.getAllPictures(|HSSFWorkbook.getAllPictures(
|) |)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
------- Additional Comments From dfisher@jmlafferty.com 2007-08-14 20:40 -------
I'm pretty sure that Yegor will have a look at this patch some time next week,
he'll have an example of a PICT and maybe an EMF.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
------- Additional Comments From poi-support@buni.org 2007-09-11 08:01 -------
make sure this doesn't break the existing stuff for drawing Escher images in
Excel...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
DO NOT REPLY [Bug 43125] - [PATCH] Support for non-bitmap pictures in HSSFWorkbook.getAllPictures()
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43125>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=43125
------- Additional Comments From trejkaz@trypticon.org 2007-08-26 16:18 -------
I'll get onto writing that unit test as soon as I'm done with my current round
of changes. At the moment my own code is in disarray from working on another
feature.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org