You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/08/28 10:12:22 UTC

[jira] Created: (HARMONY-1292) [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel() is equal to memory hanlder's pushLevel.

[classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel()  is equal to memory hanlder's  pushLevel.
------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-1292
                 URL: http://issues.apache.org/jira/browse/HARMONY-1292
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Andrew Zhang


Following test reproduces the bug:
    public void test_publish() throws Exception {
        MockHandler handler = new MockHandler();
        MemoryHandler memoryHandler = new MemoryHandler(handler, 10, Level.FINE);
        LogRecord record = new LogRecord(Level.FINE, "record");
        memoryHandler.publish(record);
        assertTrue(handler.isPublished);
    }
    
    static class MockHandler extends Handler {
        private boolean isPublished = false;
        public void close() throws SecurityException {
            // empty
        }

        public void flush() {
            // empty
        }

        public void publish(LogRecord record) {
            isPublished = true;
        }

    }

The test passes against RI while fails against Harmony. 
I'll upload a patch to fix  this problem soon.

Best regards,
Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-1292) [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel() is equal to memory hanlder's pushLevel.

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1292?page=all ]

Paulex Yang resolved HARMONY-1292.
----------------------------------

    Resolution: Fixed

Andrew, patch applied at revision r437627, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.


> [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel()  is equal to memory hanlder's  pushLevel.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1292
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1292
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1292.diff
>
>
> Following test reproduces the bug:
>     public void test_publish() throws Exception {
>         MockHandler handler = new MockHandler();
>         MemoryHandler memoryHandler = new MemoryHandler(handler, 10, Level.FINE);
>         LogRecord record = new LogRecord(Level.FINE, "record");
>         memoryHandler.publish(record);
>         assertTrue(handler.isPublished);
>     }
>     
>     static class MockHandler extends Handler {
>         private boolean isPublished = false;
>         public void close() throws SecurityException {
>             // empty
>         }
>         public void flush() {
>             // empty
>         }
>         public void publish(LogRecord record) {
>             isPublished = true;
>         }
>     }
> The test passes against RI while fails against Harmony. 
> I'll upload a patch to fix  this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-1292) [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel() is equal to memory hanlder's pushLevel.

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-1292?page=comments#action_12431116 ] 
            
Andrew Zhang commented on HARMONY-1292:
---------------------------------------

Hi Paulex,

The fix looks fine, thanks!

Best regards,
Andrew

> [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel()  is equal to memory hanlder's  pushLevel.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1292
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1292
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1292.diff
>
>
> Following test reproduces the bug:
>     public void test_publish() throws Exception {
>         MockHandler handler = new MockHandler();
>         MemoryHandler memoryHandler = new MemoryHandler(handler, 10, Level.FINE);
>         LogRecord record = new LogRecord(Level.FINE, "record");
>         memoryHandler.publish(record);
>         assertTrue(handler.isPublished);
>     }
>     
>     static class MockHandler extends Handler {
>         private boolean isPublished = false;
>         public void close() throws SecurityException {
>             // empty
>         }
>         public void flush() {
>             // empty
>         }
>         public void publish(LogRecord record) {
>             isPublished = true;
>         }
>     }
> The test passes against RI while fails against Harmony. 
> I'll upload a patch to fix  this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-1292) [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel() is equal to memory hanlder's pushLevel.

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1292?page=all ]

Paulex Yang reassigned HARMONY-1292:
------------------------------------

    Assignee: Paulex Yang

> [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel()  is equal to memory hanlder's  pushLevel.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1292
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1292
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1292.diff
>
>
> Following test reproduces the bug:
>     public void test_publish() throws Exception {
>         MockHandler handler = new MockHandler();
>         MemoryHandler memoryHandler = new MemoryHandler(handler, 10, Level.FINE);
>         LogRecord record = new LogRecord(Level.FINE, "record");
>         memoryHandler.publish(record);
>         assertTrue(handler.isPublished);
>     }
>     
>     static class MockHandler extends Handler {
>         private boolean isPublished = false;
>         public void close() throws SecurityException {
>             // empty
>         }
>         public void flush() {
>             // empty
>         }
>         public void publish(LogRecord record) {
>             isPublished = true;
>         }
>     }
> The test passes against RI while fails against Harmony. 
> I'll upload a patch to fix  this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1292) [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel() is equal to memory hanlder's pushLevel.

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1292?page=all ]

Andrew Zhang updated HARMONY-1292:
----------------------------------

    Attachment: Harmony-1292.diff

Hi,

Would you please try my patch?

Thanks!

Best regards,
Andrew

> [classlib][logging] java.util.logging.MemoryHandler.publish(LogRecord record) doesn't push record when record.getLevel()  is equal to memory hanlder's  pushLevel.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1292
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1292
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Attachments: Harmony-1292.diff
>
>
> Following test reproduces the bug:
>     public void test_publish() throws Exception {
>         MockHandler handler = new MockHandler();
>         MemoryHandler memoryHandler = new MemoryHandler(handler, 10, Level.FINE);
>         LogRecord record = new LogRecord(Level.FINE, "record");
>         memoryHandler.publish(record);
>         assertTrue(handler.isPublished);
>     }
>     
>     static class MockHandler extends Handler {
>         private boolean isPublished = false;
>         public void close() throws SecurityException {
>             // empty
>         }
>         public void flush() {
>             // empty
>         }
>         public void publish(LogRecord record) {
>             isPublished = true;
>         }
>     }
> The test passes against RI while fails against Harmony. 
> I'll upload a patch to fix  this problem soon.
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira