You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Joel Richard (JIRA)" <ji...@apache.org> on 2015/06/12 14:46:01 UTC

[jira] [Updated] (SLING-4589) Performance: Read properties lazily in MergedValueMap

     [ https://issues.apache.org/jira/browse/SLING-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Richard updated SLING-4589:
--------------------------------
    Attachment: SLING-4589.txt

I have tried the attached patch, but unfortunately it didn't help at all because now the time is spent in get() instead of readAll(). For other use cases it could help though. Closing the issue for now because it isn't worth the added complexity.

> Performance: Read properties lazily in MergedValueMap
> -----------------------------------------------------
>
>                 Key: SLING-4589
>                 URL: https://issues.apache.org/jira/browse/SLING-4589
>             Project: Sling
>          Issue Type: Improvement
>          Components: ResourceResolver
>    Affects Versions: Resource Merger 1.2.8
>            Reporter: Joel Richard
>              Labels: performance
>         Attachments: SLING-4589.txt
>
>
> About 4% of the rendering time is spent in MergedValueMap in ValueMapDecorator.putAll because the JcrPropertyMap has to be read fully before it can be added. Therefore, I would suggest to lazily read the properties in get(key) and merge them there.
> By the way, in my case 202 of 252 times the MergedValueMap is created only with a single value map.
> Discussion: http://mail-archives.apache.org/mod_mbox/sling-dev/201504.mbox/%3C5524D90F.7030009%40apache.org%3E 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)