You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/11/23 13:34:33 UTC
[GitHub] [servicecomb-java-chassis] develpoerX opened a new pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
develpoerX opened a new pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644#discussion_r755786660
##########
File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
##########
@@ -65,7 +67,12 @@ protected String getCacheKey() {
f.onNext(FallbackPolicyManager.getFallbackResponse(type, cause, invocation));
f.onCompleted();
} catch (Exception e) {
- LOG.warn("fallback failed due to:" + e.getMessage());
+ if (DynamicPropertyFactory.getInstance().getBooleanProperty(Const.PRINT_SENSITIVE_ERROR_MESSAGE,
+ false).get()) {
+ LOG.warn("fallback failed due to:" + e);
Review comment:
LOG.warn("fallback failed due to:" , e);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644#discussion_r755787035
##########
File path: handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
##########
@@ -65,7 +67,12 @@ protected String getCacheKey() {
f.onNext(FallbackPolicyManager.getFallbackResponse(type, cause, invocation));
f.onCompleted();
} catch (Exception e) {
- LOG.warn("fallback failed due to:" + e.getMessage());
+ if (DynamicPropertyFactory.getInstance().getBooleanProperty(Const.PRINT_SENSITIVE_ERROR_MESSAGE,
+ false).get()) {
+ LOG.warn("fallback failed due to:" + e);
+ } else {
+ LOG.warn("fallback failed due to:" + e.getMessage());
Review comment:
LOG.warn("fallback failed due to {}", e.getMessage());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644#issuecomment-976581198
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2644](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ae7cc6) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/b2a1f64c8e154c125ff08846a05e9568c2176840?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2a1f64) will **decrease** coverage by `0.02%`.
> The diff coverage is `51.61%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2644 +/- ##
============================================
- Coverage 77.70% 77.68% -0.03%
Complexity 1429 1429
============================================
Files 1598 1598
Lines 42727 42740 +13
Branches 3602 3606 +4
============================================
+ Hits 33201 33202 +1
- Misses 8019 8027 +8
- Partials 1507 1511 +4
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/servicecomb/core/Const.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9Db25zdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...rvicecomb/core/ConfigurationSpringInitializer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9Db25maWd1cmF0aW9uU3ByaW5nSW5pdGlhbGl6ZXIuamF2YQ==) | `74.07% <36.36%> (-2.27%)` | :arrow_down: |
| [...apache/servicecomb/bizkeeper/BizkeeperCommand.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1iaXprZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2JpemtlZXBlci9CaXprZWVwZXJDb21tYW5kLmphdmE=) | `95.34% <50.00%> (-4.66%)` | :arrow_down: |
| [...comb/authentication/provider/AccessController.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vcHJvdmlkZXIvQWNjZXNzQ29udHJvbGxlci5qYXZh) | `85.05% <55.55%> (-1.85%)` | :arrow_down: |
| [...mb/core/handler/impl/ProducerOperationHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9oYW5kbGVyL2ltcGwvUHJvZHVjZXJPcGVyYXRpb25IYW5kbGVyLmphdmE=) | `51.28% <71.42%> (-0.72%)` | :arrow_down: |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2a1f64...3ae7cc6](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644#issuecomment-976581198
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2644](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f535baf) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/3286fa4e6235b14809b62e35becb1cbb49ca260d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3286fa4) will **decrease** coverage by `0.07%`.
> The diff coverage is `50.74%`.
> :exclamation: Current head f535baf differs from pull request most recent head 05bb38e. Consider uploading reports for the commit 05bb38e to get more accurate results
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2644 +/- ##
============================================
- Coverage 77.72% 77.64% -0.08%
Complexity 1429 1429
============================================
Files 1598 1599 +1
Lines 42652 42749 +97
Branches 3591 3610 +19
============================================
+ Hits 33151 33193 +42
- Misses 8000 8045 +45
- Partials 1501 1511 +10
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/servicecomb/config/kie/client/KieClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ervicecomb/config/kie/client/KieConfigManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ29uZmlnTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...comb/service/center/client/ServiceCenterWatch.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9zZXJ2aWNlLWNlbnRlci1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3NlcnZpY2UvY2VudGVyL2NsaWVudC9TZXJ2aWNlQ2VudGVyV2F0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/element/impl/ConfigurableDatetimeAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL0NvbmZpZ3VyYWJsZURhdGV0aW1lQWNjZXNzSXRlbS5qYXZh) | `94.73% <ø> (ø)` | |
| [...core/element/impl/InvocationContextAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL0ludm9jYXRpb25Db250ZXh0QWNjZXNzSXRlbS5qYXZh) | `100.00% <ø> (ø)` | |
| [...Log/core/element/impl/RequestHeaderAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL1JlcXVlc3RIZWFkZXJBY2Nlc3NJdGVtLmphdmE=) | `89.47% <ø> (ø)` | |
| [.../core/element/impl/UrlPathWithQueryAccessItem.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1hY2Nlc3MtbG9nL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vYWNjZXNzTG9nL2NvcmUvZWxlbWVudC9pbXBsL1VybFBhdGhXaXRoUXVlcnlBY2Nlc3NJdGVtLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../common/rest/codec/param/BodyProcessorCreator.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9jb2RlYy9wYXJhbS9Cb2R5UHJvY2Vzc29yQ3JlYXRvci5qYXZh) | `81.91% <ø> (ø)` | |
| [...cecomb/common/rest/locator/ServicePathManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbW1vbi1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb21tb24vcmVzdC9sb2NhdG9yL1NlcnZpY2VQYXRoTWFuYWdlci5qYXZh) | `98.18% <ø> (ø)` | |
| [...in/java/org/apache/servicecomb/core/SCBEngine.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9TQ0JFbmdpbmUuamF2YQ==) | `81.74% <ø> (ø)` | |
| ... and [47 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3286fa4...05bb38e](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644#issuecomment-976581198
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2644](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (504f15a) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/3286fa4e6235b14809b62e35becb1cbb49ca260d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3286fa4) will **decrease** coverage by `0.03%`.
> The diff coverage is `53.33%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2644 +/- ##
============================================
- Coverage 77.72% 77.68% -0.04%
Complexity 1429 1429
============================================
Files 1598 1598
Lines 42652 42740 +88
Branches 3591 3606 +15
============================================
+ Hits 33151 33203 +52
- Misses 8000 8026 +26
- Partials 1501 1511 +10
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/servicecomb/core/Const.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9Db25zdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...rvicecomb/core/ConfigurationSpringInitializer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9Db25maWd1cmF0aW9uU3ByaW5nSW5pdGlhbGl6ZXIuamF2YQ==) | `74.07% <40.00%> (-2.27%)` | :arrow_down: |
| [...apache/servicecomb/bizkeeper/BizkeeperCommand.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1iaXprZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2JpemtlZXBlci9CaXprZWVwZXJDb21tYW5kLmphdmE=) | `95.34% <50.00%> (-4.66%)` | :arrow_down: |
| [...comb/authentication/provider/AccessController.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vcHJvdmlkZXIvQWNjZXNzQ29udHJvbGxlci5qYXZh) | `85.05% <55.55%> (-1.85%)` | :arrow_down: |
| [...mb/core/handler/impl/ProducerOperationHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9oYW5kbGVyL2ltcGwvUHJvZHVjZXJPcGVyYXRpb25IYW5kbGVyLmphdmE=) | `51.28% <71.42%> (-0.72%)` | :arrow_down: |
| [...der/springmvc/reference/CseUriTemplateHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXNwcmluZ212Yy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcHJvdmlkZXIvc3ByaW5nbXZjL3JlZmVyZW5jZS9Dc2VVcmlUZW1wbGF0ZUhhbmRsZXIuamF2YQ==) | `66.17% <0.00%> (-26.42%)` | :arrow_down: |
| [...comb/core/definition/MicroserviceVersionsMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9kZWZpbml0aW9uL01pY3Jvc2VydmljZVZlcnNpb25zTWV0YS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| [...xrs/client/validation/ValidationServiceClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLWpheHJzL2pheHJzLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZGVtby9qYXhycy9jbGllbnQvdmFsaWRhdGlvbi9WYWxpZGF0aW9uU2VydmljZUNsaWVudC5qYXZh) | `72.41% <0.00%> (-3.20%)` | :arrow_down: |
| [...a/org/apache/servicecomb/swagger/SwaggerUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9Td2FnZ2VyVXRpbHMuamF2YQ==) | `92.30% <0.00%> (-1.18%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3286fa4...504f15a](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2644?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2644: SCB-2360 Provides a unified switch to control exception stack printing
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2644:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2644#discussion_r755788606
##########
File path: core/src/main/java/org/apache/servicecomb/core/ConfigurationSpringInitializer.java
##########
@@ -231,15 +232,21 @@ private static void addMappingToSpring(Environment environment) {
private void addDynamicConfigurationToSpring(Environment environment,
ConfigCenterConfigurationSource configCenterConfigurationSource) {
- if (environment instanceof ConfigurableEnvironment) {
- ConfigurableEnvironment ce = (ConfigurableEnvironment) environment;
- if (configCenterConfigurationSource != null) {
- try {
- ce.getPropertySources()
- .addFirst(new MapPropertySource("dynamic-source", dynamicData));
- } catch (Exception e) {
- LOGGER.warn("set up spring property source failed. msg: {}", e.getMessage());
- }
+ if (!(environment instanceof ConfigurableEnvironment)) {
+ return;
+ }
+ ConfigurableEnvironment ce = (ConfigurableEnvironment) environment;
+ if (configCenterConfigurationSource == null) {
+ return;
+ }
+ try {
+ ce.getPropertySources().addFirst(new MapPropertySource("dynamic-source", dynamicData));
+ } catch (Exception e) {
+ if (DynamicPropertyFactory.getInstance().getBooleanProperty(Const.PRINT_SENSITIVE_ERROR_MESSAGE,
+ false).get()) {
+ LOGGER.warn("set up spring property source failed. msg", e);
Review comment:
LOGGER.warn("set up spring property source failed. ", e);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org