You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2015/11/26 19:14:53 UTC
[12/12] git commit: [flex-asjs] [refs/heads/core_js_to_as] - remove
unneeded goog.bind calls. goog.bind is still needed in Language.closure and
MXMLDataInterpreter
remove unneeded goog.bind calls. goog.bind is still needed in Language.closure and MXMLDataInterpreter
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/443804dd
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/443804dd
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/443804dd
Branch: refs/heads/core_js_to_as
Commit: 443804dd333dc90b888bc76b7e773e3c2efa7a45
Parents: 9e2dbed
Author: Alex Harui <ah...@apache.org>
Authored: Thu Nov 26 09:53:05 2015 -0800
Committer: Alex Harui <ah...@apache.org>
Committed: Thu Nov 26 09:53:05 2015 -0800
----------------------------------------------------------------------
.../Core/as/src/org/apache/flex/core/BrowserResizeListener.as | 7 +------
.../Core/as/src/org/apache/flex/core/CallLaterBead.as | 7 +------
.../projects/Core/as/src/org/apache/flex/utils/EffectTimer.as | 6 ++----
.../projects/Core/as/src/org/apache/flex/utils/Timer.as | 7 +------
.../projects/HTML/as/src/org/apache/flex/html/ComboBox.as | 6 +++---
.../projects/HTML/as/src/org/apache/flex/html/Container.as | 4 ++--
.../projects/HTML/as/src/org/apache/flex/html/DropDownList.as | 2 +-
.../HTML/as/src/org/apache/flex/html/NumericStepper.as | 2 +-
.../projects/HTML/as/src/org/apache/flex/html/SimpleList.as | 2 +-
.../projects/HTML/as/src/org/apache/flex/html/TextInput.as | 4 ++--
.../HTML/as/src/org/apache/flex/html/beads/ImageView.as | 4 ++--
.../html/beads/controllers/ItemRendererMouseController.as | 3 +--
.../flex/html/beads/controllers/SpinnerMouseController.as | 4 ++--
13 files changed, 20 insertions(+), 38 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/Core/as/src/org/apache/flex/core/BrowserResizeListener.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/as/src/org/apache/flex/core/BrowserResizeListener.as b/frameworks/projects/Core/as/src/org/apache/flex/core/BrowserResizeListener.as
index f937dba..644528e 100644
--- a/frameworks/projects/Core/as/src/org/apache/flex/core/BrowserResizeListener.as
+++ b/frameworks/projects/Core/as/src/org/apache/flex/core/BrowserResizeListener.as
@@ -24,10 +24,6 @@ COMPILE::AS3
import flash.external.ExternalInterface;
import flash.utils.getQualifiedClassName;
}
-COMPILE::JS
-{
- import goog.bind;
-}
/**
* The BrowserResizeListener class listens for browser
@@ -37,7 +33,6 @@ COMPILE::JS
* @playerversion Flash 10.2
* @playerversion AIR 2.6
* @productversion FlexJS 0.0
- * @flexjsignoreimport goog.bind
*/
public class BrowserResizeListener implements IBead
{
@@ -105,7 +100,7 @@ COMPILE::JS
COMPILE::JS
{
window.addEventListener('resize',
- goog.bind(this.resizeHandler, this), false);
+ this.resizeHandler, false);
if (!isNaN(this.minWidth))
document.body.style.minWidth = this.minWidth.toString() + 'px';
if (!isNaN(this.minHeight))
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/Core/as/src/org/apache/flex/core/CallLaterBead.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/as/src/org/apache/flex/core/CallLaterBead.as b/frameworks/projects/Core/as/src/org/apache/flex/core/CallLaterBead.as
index 85c1195..64f5ea3 100644
--- a/frameworks/projects/Core/as/src/org/apache/flex/core/CallLaterBead.as
+++ b/frameworks/projects/Core/as/src/org/apache/flex/core/CallLaterBead.as
@@ -23,10 +23,6 @@ package org.apache.flex.core
import flash.display.DisplayObject;
import flash.events.Event;
}
- COMPILE::JS
- {
- import goog.bind;
- }
import org.apache.flex.core.IBead;
import org.apache.flex.core.IStrand;
@@ -40,7 +36,6 @@ package org.apache.flex.core
* @playerversion Flash 10.2
* @playerversion AIR 2.6
* @productversion FlexJS 0.0
- * @flexjsignoreimport goog.bind
*/
public class CallLaterBead implements IBead
{
@@ -105,7 +100,7 @@ package org.apache.flex.core
COMPILE::JS
{
- setTimeout(goog.bind(this.makeCalls, this), 0);
+ setTimeout(makeCalls, 0);
}
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/Core/as/src/org/apache/flex/utils/EffectTimer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/as/src/org/apache/flex/utils/EffectTimer.as b/frameworks/projects/Core/as/src/org/apache/flex/utils/EffectTimer.as
index 7accf42..3e557d6 100644
--- a/frameworks/projects/Core/as/src/org/apache/flex/utils/EffectTimer.as
+++ b/frameworks/projects/Core/as/src/org/apache/flex/utils/EffectTimer.as
@@ -27,7 +27,6 @@ COMPILE::AS3
}
COMPILE::JS
{
- import goog.bind;
import org.apache.flex.events.EventDispatcher;
}
import org.apache.flex.core.IEffectTimer;
@@ -57,7 +56,6 @@ import org.apache.flex.events.ValueEvent;
* @playerversion Flash 10.2
* @playerversion AIR 2.6
* @productversion FlexJS 0.0
- * @flexjsignoreimport goog.bind
*/
public class EffectTimer extends EventDispatcher implements IEffectTimer
{
@@ -102,7 +100,7 @@ public class EffectTimer extends EventDispatcher implements IEffectTimer
COMPILE::JS
{
timerInterval =
- setInterval(goog.bind(timerHandler, this), interval);
+ setInterval(timerHandler, interval);
var d:Date = new Date();
return d.getTime();
}
@@ -132,7 +130,7 @@ public class EffectTimer extends EventDispatcher implements IEffectTimer
private function timerHandler():void
{
var d:Date = new Date();
- dispatchEvent(new org.apache.flex.events.ValueEvent('update', d.getTime()));
+ dispatchEvent(new ValueEvent('update', false, false, d.getTime()));
}
}
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/Core/as/src/org/apache/flex/utils/Timer.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/as/src/org/apache/flex/utils/Timer.as b/frameworks/projects/Core/as/src/org/apache/flex/utils/Timer.as
index b99a4d8..582d884 100644
--- a/frameworks/projects/Core/as/src/org/apache/flex/utils/Timer.as
+++ b/frameworks/projects/Core/as/src/org/apache/flex/utils/Timer.as
@@ -23,10 +23,6 @@ COMPILE::AS3
import flash.events.TimerEvent;
import flash.utils.Timer;
}
-COMPILE::JS
-{
- import goog.bind;
-}
import org.apache.flex.events.Event;
@@ -58,7 +54,6 @@ COMPILE::JS
* @playerversion Flash 10.2
* @playerversion AIR 2.6
* @productversion FlexJS 0.0
- * @flexjsignoreimport goog.bind
*/
COMPILE::AS3
public class Timer extends flash.utils.Timer
@@ -136,7 +131,7 @@ public class Timer extends EventDispatcher
public function start():void
{
timerInterval =
- setInterval(goog.bind(timerHandler, this), delay);
+ setInterval(timerHandler, delay);
}
private function timerHandler():void
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/ComboBox.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/ComboBox.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/ComboBox.as
index 7852abf..fa91fec 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/ComboBox.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/ComboBox.as
@@ -142,7 +142,7 @@ package org.apache.flex.html
button.style.height = '20px';
button.style.margin = '0';
button.style.border = 'solid #609 1px';
- goog.events.listen(button, 'click', goog.bind(buttonClicked, this));
+ goog.events.listen(button, 'click', buttonClicked);
element.appendChild(button);
positioner = element;
@@ -151,7 +151,7 @@ package org.apache.flex.html
// add a click handler so that a click outside of the combo box can
// dismiss the pop-up should it be visible.
goog.events.listen(document, 'click',
- goog.bind(dismissPopup, this));
+ dismissPopup);
input.flexjs_wrapper = this;
@@ -248,7 +248,7 @@ package org.apache.flex.html
select = document.createElement('select') as HTMLSelectElement;
select.style.width = width.toString() + 'px';
- goog.events.listen(select, 'change', goog.bind(selectChanged, this));
+ goog.events.listen(select, 'change', selectChanged);
dp = dataProvider as Array;
n = dp.length;
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/Container.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/Container.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/Container.as
index 7ff1ddf..ee30b7f 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/Container.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/Container.as
@@ -98,9 +98,9 @@ package org.apache.flex.html
element.flexjs_wrapper = this;
/*addEventListener('childrenAdded',
- goog.bind(runLayoutHandler, this));
+ runLayoutHandler);
addEventListener('elementRemoved',
- goog.bind(runLayoutHandler, this));*/
+ runLayoutHandler);*/
return element;
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/DropDownList.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/DropDownList.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/DropDownList.as
index 0f1816c..f4d5cbb 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/DropDownList.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/DropDownList.as
@@ -203,7 +203,7 @@ package org.apache.flex.html
element = document.createElement('select') as WrappedHTMLElement;
(element as HTMLSelectElement).size = 1;
goog.events.listen(element, 'change',
- goog.bind(changeHandler, this));
+ changeHandler);
positioner = element;
positioner.style.position = 'relative';
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/NumericStepper.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/NumericStepper.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/NumericStepper.as
index b8d87aa..02120e7 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/NumericStepper.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/NumericStepper.as
@@ -187,7 +187,7 @@ package org.apache.flex.html
spinner.decrementButton.positioner.style.fontSize = '7px';
spinner.positioner.style.display = 'inline-block';
goog.events.listen(spinner, 'valueChange',
- goog.bind(spinnerChange, this));
+ spinnerChange);
element.flexjs_wrapper = this;
className = 'NumericStepper';
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/SimpleList.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/SimpleList.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/SimpleList.as
index 0bbfd69..9dcb348 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/SimpleList.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/SimpleList.as
@@ -59,7 +59,7 @@ package org.apache.flex.html
element = document.createElement('select') as WrappedHTMLElement;
(element as HTMLSelectElement).size = 5;
goog.events.listen(element, 'change',
- goog.bind(changeHandler, this));
+ changeHandler);
positioner = element;
positioner.style.position = 'relative';
className = 'SimpleList';
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/TextInput.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/TextInput.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/TextInput.as
index 04ab9b8..1861405 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/TextInput.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/TextInput.as
@@ -171,8 +171,8 @@ package org.apache.flex.html
typeNames = 'TextInput';
//attach input handler to dispatch flexjs change event when user write in textinput
- //goog.events.listen(element, 'change', goog.bind(killChangeHandler, this));
- goog.events.listen(element, 'input', goog.bind(textChangeHandler, this));
+ //goog.events.listen(element, 'change', killChangeHandler);
+ goog.events.listen(element, 'input', textChangeHandler);
positioner = element;
positioner.style.position = 'relative';
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ImageView.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ImageView.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ImageView.as
index dba31b4..042634a 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ImageView.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/ImageView.as
@@ -115,9 +115,9 @@ package org.apache.flex.html.beads
if (_model.source) {
var host:IUIBase = _strand as IUIBase;
host.element.addEventListener('load',
- goog.bind(loadHandler, this), false);
+ loadHandler, false);
host.addEventListener('sizeChanged',
- goog.bind(sizeChangedHandler, this));
+ sizeChangedHandler);
(host.element as HTMLImageElement).src = _model.source;
}
}
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/ItemRendererMouseController.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/ItemRendererMouseController.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/ItemRendererMouseController.as
index 952cca9..5e07458 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/ItemRendererMouseController.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/ItemRendererMouseController.as
@@ -31,7 +31,7 @@ COMPILE::JS {
import org.apache.flex.events.BrowserEvent;
import goog.events.Event;
import goog.events.EventType;
- import goog.bind;
+ import goog.events;
}
/**
@@ -44,7 +44,6 @@ COMPILE::JS {
* @playerversion AIR 2.6
* @productversion FlexJS 0.0
* @flexjsignoreimport goog.events.Event
- * @flexjsignoreimport goog.bind
*/
public class ItemRendererMouseController implements IBeadController
{
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/443804dd/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/SpinnerMouseController.as b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
index 6ad41bd..48088c4 100644
--- a/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
+++ b/frameworks/projects/HTML/as/src/org/apache/flex/html/beads/controllers/SpinnerMouseController.as
@@ -92,10 +92,10 @@ package org.apache.flex.html.beads.controllers
decrementButton = host.decrementButton;
goog.events.listen(incrementButton.element, goog.events.EventType.CLICK,
- goog.bind(incrementClickHandler, this));
+ incrementClickHandler);
goog.events.listen(decrementButton.element, goog.events.EventType.CLICK,
- goog.bind(decrementClickHandler, this));
+ decrementClickHandler);
}
}