You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (Created) (JIRA)" <ji...@apache.org> on 2011/11/18 00:57:54 UTC
[jira] [Created] (HBASE-4815) Disable online altering by default,
create a config for it
Disable online altering by default, create a config for it
----------------------------------------------------------
Key: HBASE-4815
URL: https://issues.apache.org/jira/browse/HBASE-4815
Project: HBase
Issue Type: Task
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Priority: Blocker
Fix For: 0.92.0
There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to disable to table to alter).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153367#comment-13153367 ]
Hudson commented on HBASE-4815:
-------------------------------
Integrated in HBase-0.92 #145 (See [https://builds.apache.org/job/HBase-0.92/145/])
HBASE-4815 Disable online altering by default, create a config for it
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* /hbase/branches/0.92/src/main/resources/hbase-default.xml
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153519#comment-13153519 ]
ramkrishna.s.vasudevan commented on HBASE-4815:
-----------------------------------------------
Thanks Ted and Stack. I did not observe the failure as i had left the office by that time..
Regarding the config update in hbase-default.xml i was not very clear if it was needed. Thanks Stack for taking care of it. :)
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153516#comment-13153516 ]
Ted Yu commented on HBASE-4815:
-------------------------------
TestAdmin passed in build 2461.
Addendum applied to 0.92 as well.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152886#comment-13152886 ]
ramkrishna.s.vasudevan commented on HBASE-4815:
-----------------------------------------------
Will upload a patch..shortly
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.92.0
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to disable to table to alter).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153551#comment-13153551 ]
stack commented on HBASE-4815:
------------------------------
Thanks Ted for coming along w/ the cleanup.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153065#comment-13153065 ]
Hadoop QA commented on HBASE-4815:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504234/4815.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 60 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.client.TestShell
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/294//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/294//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/294//console
This message is automatically generated.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4815:
--------------------------
Status: Patch Available (was: Open)
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4815:
-------------------------
Attachment: 4815-v2.txt
Here is Ram's patch plus adding below to hbase-default.xml:
<property>
+ <name>hbase.online.schema.update.enable</name>
+ <value>false</value>
+ <description>
+ Set true to enable online schema changes. This is an experimental feature.
+ There are known issues modifying table schemas at the same time a region
+ split is happening so your table needs to be quiescent or else you have to
+ be running with splits disabled.
+ </description>
+ </property>
I think its important to surface this new feature but w/ the caveats.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152485#comment-13152485 ]
Todd Lipcon commented on HBASE-4815:
------------------------------------
+1
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.92.0
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to disable to table to alter).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4815:
--------------------------
Description:
There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
was:
There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to disable to table to alter).
Assignee: ramkrishna.s.vasudevan
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4815:
------------------------------------------
Attachment: HBASE-4796.patch
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153072#comment-13153072 ]
stack commented on HBASE-4815:
------------------------------
This patch will do but should it also have a component in hbase-default.xml where we list the option and say this an experimental feature that only works for sure on tables where splitting is disabled?
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152684#comment-13152684 ]
ramkrishna.s.vasudevan commented on HBASE-4815:
-----------------------------------------------
+1. Digging more on HBASE-4729 we got many other issues...
Let me work on a patch for this.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.92.0
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to disable to table to alter).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4815:
------------------------------------------
Attachment: (was: HBASE-4796.patch)
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153460#comment-13153460 ]
Ted Yu commented on HBASE-4815:
-------------------------------
Addendum integrated to TRUNK.
Let's see if TestAdmin gets fixed.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153453#comment-13153453 ]
Ted Yu commented on HBASE-4815:
-------------------------------
I think HadoopQA reported TestAdmin failure earlier which wasn't given enough attention.
We need to set hbase.online.schema.update.enable to true for testDeleteEditUnknownColumnFamilyAndOrTable(). Otherwise the exception we got would be TableNotDisabledException, not InvalidFamilyOperationException.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153535#comment-13153535 ]
Hudson commented on HBASE-4815:
-------------------------------
Integrated in HBase-0.92 #147 (See [https://builds.apache.org/job/HBase-0.92/147/])
HBASE-4815 Addendum sets hbase.online.schema.update.enable to true for TestAdmin
tedyu :
Files :
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153721#comment-13153721 ]
Hudson commented on HBASE-4815:
-------------------------------
Integrated in HBase-0.92 #149 (See [https://builds.apache.org/job/HBase-0.92/149/])
HBASE-4828 Fix failing TestShell, needs same addendum as HBASE-4815 got
stack :
Files :
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestShell.java
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153405#comment-13153405 ]
Hudson commented on HBASE-4815:
-------------------------------
Integrated in HBase-TRUNK #2459 (See [https://builds.apache.org/job/HBase-TRUNK/2459/])
HBASE-4815 Disable online altering by default, create a config for it
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* /hbase/trunk/src/main/resources/hbase-default.xml
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4815:
--------------------------
Attachment: 4815.addendum
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153828#comment-13153828 ]
ramkrishna.s.vasudevan commented on HBASE-4815:
-----------------------------------------------
Thanks Stack. Should have completed the verification of all test cases..
Usually used to do it.. as it was friday i left office before it could get completed. Next time will be more careful..
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153634#comment-13153634 ]
Hudson commented on HBASE-4815:
-------------------------------
Integrated in HBase-TRUNK #2464 (See [https://builds.apache.org/job/HBase-TRUNK/2464/])
HBASE-4828 Fix failing TestShell, needs same addendum as HBASE-4815 got
stack :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestShell.java
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153486#comment-13153486 ]
Hudson commented on HBASE-4815:
-------------------------------
Integrated in HBase-TRUNK #2461 (See [https://builds.apache.org/job/HBase-TRUNK/2461/])
HBASE-4815 Addendum sets "hbase.online.schema.update.enable" to true
tedyu :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.addendum, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "Ted Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4815:
--------------------------
Attachment: 4815.patch
Patch from Ramkrishna
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4815) Disable online altering by default,
create a config for it
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4815:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Applied branch and trunk. Thanks for patch Ram.
> Disable online altering by default, create a config for it
> ----------------------------------------------------------
>
> Key: HBASE-4815
> URL: https://issues.apache.org/jira/browse/HBASE-4815
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.92.0
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: 4815-v2.txt, 4815.patch
>
>
> There's a whole class of bugs that we've been revealing from trying out online altering in conjunction with other operations like splitting. HBASE-4729, HBASE-4794, and HBASE-4814 are examples.
> It's not so much that the online altering code is buggy, but that it wasn't tested in an environment that permits splitting.
> I think we should mark online altering as experimental in 0.92 and add a config to enable it (so it would be disabled by default, requiring people to enable for altering table schema).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira