[allura] 04/04: [#8489] py3.8: fix warning about bufsize, switch to text mode

[br...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

brondsem pushed a commit to branch db/8489
in repository https://gitbox.apache.org/repos/asf/allura.git

commit 32b12db8d46b5529c9e1ddefd515a0414b392771
Author: Dave Brondsema <db...@slashdotmedia.com>
AuthorDate: Fri Jan 13 13:31:05 2023 -0500

    [#8489] py3.8: fix warning about bufsize, switch to text mode
---
 run_tests | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/run_tests b/run_tests
index 813314b20..28d2e0b3f 100755
--- a/run_tests
+++ b/run_tests
@@ -54,13 +54,14 @@ def run_one(cmd, **popen_kwargs):
     all_popen_kwargs = dict(shell=True, stderr=subprocess.STDOUT,
                             stdout=subprocess.PIPE,
                             bufsize=1,  # 1 == line-buffered
+                            text=True,
                             close_fds='posix' in sys.builtin_module_names)
     all_popen_kwargs.update(popen_kwargs)
     proc = subprocess.Popen(cmd, **all_popen_kwargs)
     while proc.poll() is None:
         line = proc.stdout.readline()
         sys.stdout.write(print_ensured(line))
-        if b'No data to combine' in line:
+        if 'No data to combine' in line:
             sys.stdout.write('^^ error from "coverage combine" command.  Make sure your package has a setup.cfg with coverage settings like other packages\n')
         sys.stdout.flush()
     # wait for completion and get remainder of output