modifications to the cli tools to check for tool presence/versioning

[Mike Reinstein <re...@gmail.com>]

Hey folks,

I'm wondering if it makes sense for us to add some checks to the various
command line tools to check for the presence of required tools, and also
check for proper versions. For example the debug script for ios has:

xcodebuild -project $PROJECT_NAME.xcodeproj -arch i386 -target
$PROJECT_NAME -configuration Debug -sdk $SDK clean build VALID_ARCHS="i386"
CONFIGURATION_BUILD_DIR="$PROJECT_PATH/build"

Do you think it's appropriate for us to add checks to see if xcodebuild is
even available, and if xcodebuild -version returns >= required_version
number?

This question came up as a result of work on the cordova-client project,
which wraps the lower level scripts that get packaged with each platform.
It seems like this should happen at the lower level, since it's already
encapsulating the build tools for each platform. Thoughts?

-Mike

Re: modifications to the cli tools to check for tool presence/versioning

[Brian LeRoux <b...@brian.io>]

Eh mike best route is to follow our wiki. [1] You can fork either the
ASF [2] repos or some find it easier to fork the mirrors on Github.
[3]

[1] http://wiki.apache.org/cordova/ContributorWorkflow
[2] http://git.cordova.io
[3] http://github.com/apache/ (search the page for 'cordova' ;)


On Mon, Sep 24, 2012 at 5:26 PM, Mike Reinstein
<re...@gmail.com> wrote:
> If I were to take a stab at fixing this, whats the right place to
> fork/branch code from?
>
> -Mike
>
> On Mon, Sep 24, 2012 at 10:27 AM, Andrew Grieve <ag...@chromium.org>wrote:
>
>> Sounds like a good idea to me. I've found our scripts fairly lacking in the
>> error messages department. I think more checks and error messages would go
>> a long way :)
>>
>>
>> On Mon, Sep 24, 2012 at 9:24 AM, Mike Reinstein <reinstein.mike@gmail.com
>> >wrote:
>>
>> > Hey folks,
>> >
>> > I'm wondering if it makes sense for us to add some checks to the various
>> > command line tools to check for the presence of required tools, and also
>> > check for proper versions. For example the debug script for ios has:
>> >
>> > xcodebuild -project $PROJECT_NAME.xcodeproj -arch i386 -target
>> > $PROJECT_NAME -configuration Debug -sdk $SDK clean build
>> VALID_ARCHS="i386"
>> > CONFIGURATION_BUILD_DIR="$PROJECT_PATH/build"
>> >
>> > Do you think it's appropriate for us to add checks to see if xcodebuild
>> is
>> > even available, and if xcodebuild -version returns >= required_version
>> > number?
>> >
>> > This question came up as a result of work on the cordova-client project,
>> > which wraps the lower level scripts that get packaged with each platform.
>> > It seems like this should happen at the lower level, since it's already
>> > encapsulating the build tools for each platform. Thoughts?
>> >
>> > -Mike
>> >
>>

Re: modifications to the cli tools to check for tool presence/versioning

[Anis KADRI <an...@gmail.com>]

There is some error checking happening but it might need more love. You can
just fork the current ios/android/blackberry/win7 repos and add those
checks and send pull requests.

On Mon, Sep 24, 2012 at 8:26 AM, Mike Reinstein <re...@gmail.com>wrote:

> If I were to take a stab at fixing this, whats the right place to
> fork/branch code from?
>
> -Mike
>
> On Mon, Sep 24, 2012 at 10:27 AM, Andrew Grieve <agrieve@chromium.org
> >wrote:
>
> > Sounds like a good idea to me. I've found our scripts fairly lacking in
> the
> > error messages department. I think more checks and error messages would
> go
> > a long way :)
> >
> >
> > On Mon, Sep 24, 2012 at 9:24 AM, Mike Reinstein <
> reinstein.mike@gmail.com
> > >wrote:
> >
> > > Hey folks,
> > >
> > > I'm wondering if it makes sense for us to add some checks to the
> various
> > > command line tools to check for the presence of required tools, and
> also
> > > check for proper versions. For example the debug script for ios has:
> > >
> > > xcodebuild -project $PROJECT_NAME.xcodeproj -arch i386 -target
> > > $PROJECT_NAME -configuration Debug -sdk $SDK clean build
> > VALID_ARCHS="i386"
> > > CONFIGURATION_BUILD_DIR="$PROJECT_PATH/build"
> > >
> > > Do you think it's appropriate for us to add checks to see if xcodebuild
> > is
> > > even available, and if xcodebuild -version returns >= required_version
> > > number?
> > >
> > > This question came up as a result of work on the cordova-client
> project,
> > > which wraps the lower level scripts that get packaged with each
> platform.
> > > It seems like this should happen at the lower level, since it's already
> > > encapsulating the build tools for each platform. Thoughts?
> > >
> > > -Mike
> > >
> >
>

Re: modifications to the cli tools to check for tool presence/versioning

[Mike Reinstein <re...@gmail.com>]

If I were to take a stab at fixing this, whats the right place to
fork/branch code from?

-Mike

On Mon, Sep 24, 2012 at 10:27 AM, Andrew Grieve <ag...@chromium.org>wrote:

> Sounds like a good idea to me. I've found our scripts fairly lacking in the
> error messages department. I think more checks and error messages would go
> a long way :)
>
>
> On Mon, Sep 24, 2012 at 9:24 AM, Mike Reinstein <reinstein.mike@gmail.com
> >wrote:
>
> > Hey folks,
> >
> > I'm wondering if it makes sense for us to add some checks to the various
> > command line tools to check for the presence of required tools, and also
> > check for proper versions. For example the debug script for ios has:
> >
> > xcodebuild -project $PROJECT_NAME.xcodeproj -arch i386 -target
> > $PROJECT_NAME -configuration Debug -sdk $SDK clean build
> VALID_ARCHS="i386"
> > CONFIGURATION_BUILD_DIR="$PROJECT_PATH/build"
> >
> > Do you think it's appropriate for us to add checks to see if xcodebuild
> is
> > even available, and if xcodebuild -version returns >= required_version
> > number?
> >
> > This question came up as a result of work on the cordova-client project,
> > which wraps the lower level scripts that get packaged with each platform.
> > It seems like this should happen at the lower level, since it's already
> > encapsulating the build tools for each platform. Thoughts?
> >
> > -Mike
> >
>

Re: modifications to the cli tools to check for tool presence/versioning

[Andrew Grieve <ag...@chromium.org>]

Sounds like a good idea to me. I've found our scripts fairly lacking in the
error messages department. I think more checks and error messages would go
a long way :)


On Mon, Sep 24, 2012 at 9:24 AM, Mike Reinstein <re...@gmail.com>wrote:

> Hey folks,
>
> I'm wondering if it makes sense for us to add some checks to the various
> command line tools to check for the presence of required tools, and also
> check for proper versions. For example the debug script for ios has:
>
> xcodebuild -project $PROJECT_NAME.xcodeproj -arch i386 -target
> $PROJECT_NAME -configuration Debug -sdk $SDK clean build VALID_ARCHS="i386"
> CONFIGURATION_BUILD_DIR="$PROJECT_PATH/build"
>
> Do you think it's appropriate for us to add checks to see if xcodebuild is
> even available, and if xcodebuild -version returns >= required_version
> number?
>
> This question came up as a result of work on the cordova-client project,
> which wraps the lower level scripts that get packaged with each platform.
> It seems like this should happen at the lower level, since it's already
> encapsulating the build tools for each platform. Thoughts?
>
> -Mike
>