You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by forrestc <gi...@git.apache.org> on 2015/03/11 17:59:16 UTC

[GitHub] thrift pull request: Update thrift.js

GitHub user forrestc opened a pull request:

    https://github.com/apache/thrift/pull/396

    Update thrift.js

    Error.message and stack are non-enumerable properties, which cannot be inherited by util.inherits. It is annoying that an Exception object doesn't contain a message, so it is a critical bug I think.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/forrestc/thrift patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #396
    
----
commit 8b8bc97ef58b322dd8335c707bcda24d080352ba
Author: Forrest Cao <fo...@factual.com>
Date:   2015-03-11T16:59:00Z

    Update thrift.js
    
    Error.message and stack are non-enumerable properties, which cannot be inherited by util.inherits. It is annoying that an Exception object doesn't contain a message, so it is a critical bug I think.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update thrift.js

Posted by RandyAbernethy <gi...@git.apache.org>.

Github user RandyAbernethy commented on the pull request:

    https://github.com/apache/thrift/pull/396#issuecomment-78527156
  
    Hello Forrest,
    
    The Thrift project accepts pull requests but they have to be attached to a Jira Issue. If you create a Jira Issue for this here:
    https://issues.apache.org/jira/browse/THRIFT/?selectedTab=com.atlassian.jira.jira-projects-plugin:issues-panel
    
    and attach the patch someone will review it.
    
    Best,
    Randy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update thrift.js

Posted by jfarrell <gi...@git.apache.org>.

Github user jfarrell commented on the pull request:

    https://github.com/apache/thrift/pull/396#issuecomment-93615711
  
    Thanks for your patch @forrestc, in order for us to accept a pull request we need to have a jira ticket associated with it. Please see our contributing guide at http://thrift.apache.org/docs/HowToContribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update thrift.js

Posted by jfarrell <gi...@git.apache.org>.

Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/396


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---