You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/02/23 22:25:27 UTC
Review Request 31319: DRILL-2283: Fixed: INFORMATION_SCHEMA strings
were VARCHAR(1), breaking comparison
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31319/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2283
https://issues.apache.org/jira/browse/DRILL-2283
Repository: drill-git
Description
-------
Fixed implementation string columns of INFORMATION SCHEMA tables from calling method that set type to VARCHAR(1) to setting type to VARCHAR(<some large-enough value>).
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaTable.java c343c5c
exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/Drill2283InfoSchemaVarchar1BugTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/31319/diff/
Testing
-------
Ran new specific unit tests and existing test suites.
Thanks,
Daniel Barclay
Re: Review Request 31319: DRILL-2283: Fixed: INFORMATION_SCHEMA
strings were VARCHAR(1), breaking comparison
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31319/#review73853
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On Feb. 23, 2015, 9:25 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31319/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2015, 9:25 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2283
> https://issues.apache.org/jira/browse/DRILL-2283
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Fixed implementation string columns of INFORMATION SCHEMA tables from calling method that set type to VARCHAR(1) to setting type to VARCHAR(<some large-enough value>).
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaTable.java c343c5c
> exec/java-exec/src/test/java/org/apache/drill/exec/store/ischema/Drill2283InfoSchemaVarchar1BugTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31319/diff/
>
>
> Testing
> -------
>
> Ran new specific unit tests and existing test suites.
>
>
> Thanks,
>
> Daniel Barclay
>
>