You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by caneGuy <gi...@git.apache.org> on 2018/04/23 10:49:59 UTC
[GitHub] spark pull request #21128: [SPARK-24053][CORE] Support add subdirectory name...
GitHub user caneGuy opened a pull request:
https://github.com/apache/spark/pull/21128
[SPARK-24053][CORE] Support add subdirectory named as user name on staging directory
## What changes were proposed in this pull request?
When we have multiple users on the same cluster,we can support add subdirectory which named as login user
## How was this patch tested?
Exist UT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caneGuy/spark zhoukang/support-userlevel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21128
----
commit b3190525367e750c26d56c1e61cfd3473e6a109a
Author: zhoukang <zh...@...>
Date: 2018-04-23T10:45:20Z
[SPARK] Support add subdirectory named as user name on staging directory
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/21128
@vanzin Thanks!
Since we set the common staging dir as
```
hdfs://xxx/spark/xxx/staging
```
This patch will give us a directory for given user like:
```
hdfs://xxx/spark/xxx/staging/u_zhoukang
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21128
See my last comment. You don't need code in Spark to achieve what you want to do.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21128
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21128
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21128
**[Test build #89715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89715/testReport)** for PR 21128 at commit [`b319052`](https://github.com/apache/spark/commit/b3190525367e750c26d56c1e61cfd3473e6a109a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21128: [SPARK-24053][CORE] Support add subdirectory name...
Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy closed the pull request at:
https://github.com/apache/spark/pull/21128
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21128
**[Test build #89715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89715/testReport)** for PR 21128 at commit [`b319052`](https://github.com/apache/spark/commit/b3190525367e750c26d56c1e61cfd3473e6a109a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21128
> When we have multiple users on the same cluster
Then the staging directory would be created under the respective user already (it's created under the user's home directory). I have no idea why you need this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by caneGuy <gi...@git.apache.org>.
Github user caneGuy commented on the issue:
https://github.com/apache/spark/pull/21128
Got it,thanks @vanzin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21128
Moreover, you can set `spark.yarn.stagingDir` to whatever you want, and may even reference env variables or system properties. e.g.
```
spark.yarn.stagingDir=/tmp/${system:user.name}
```
And the staging directory will be created under that location. So really you don't need to write any code for this, even if you have a weird deployment where users don't have their own home directory.
Please close this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21128: [SPARK-24053][CORE] Support add subdirectory named as us...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21128
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89715/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org