[jira] [Comment Edited] (KAFKA-9931) Kafka Connect should accept '-1' as a valid replication factor

["Randall Hauch (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094975#comment-17094975 ] 

Randall Hauch edited comment on KAFKA-9931 at 4/29/20, 1:51 AM:
----------------------------------------------------------------

We'll need a KIP for this change, but it should be relatively straightforward if we don't change the default or the config files, and merely accept values that are either 1 or >= 1.

However, I do think this is a good time for Connect's worker logic when creating internal topics to support other topic settings via worker config properties using the `config.storage.topic.*`, `offset.storage.topic.*`, and `status.storage.topic.*` prefixes.


was (Author: rhauch):
We'll need a KIP for this change, but it should be relatively straightforward if we don't change the default or the config files, and merely accept values that are either -1 or >= 1.

> Kafka Connect should accept '-1' as a valid replication factor
> --------------------------------------------------------------
>
>                 Key: KAFKA-9931
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9931
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>    Affects Versions: 2.5.0
>            Reporter: Randall Hauch
>            Assignee: Randall Hauch
>            Priority: Critical
>              Labels: needs-kip
>             Fix For: 2.6.0
>
>
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-464%3A+Defaults+for+AdminClient%23createTopic]
> As of KIP-464, the adminclient can use '-1' as the replication factor or partitions and the broker defaults. The Kafka Connect Frame work does not currently accept anything less than 1 as a valid replication factor. This should be changed so that Connect worker configurations can specify `-1` for the internal topic replication factors to default to use the broker's default replication factor for new topics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)