You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/06 14:15:51 UTC

[GitHub] [flink] GJL opened a new pull request #11032: [WIP][FLINK-15918]

GJL opened a new pull request #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032
 
 
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
     - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
     - *Deployments RPC transmits only the blob storage reference*
     - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582926187
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 354d125536b77dd5189f952919b3bbcd5be3284d (Thu Feb 06 14:19:08 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583112279
 
 
   ```
   2020-02-06 19:39:58,390 INFO  org.apache.flink.runtime.taskmanager.Task                     - Ensuring all FileSystem streams are closed for task Source: Custom Source (1/1) (e809b769c817e73fa009ec5055e883e2) [CANCELED]
   2020-02-06 19:39:58,394 WARN  org.apache.flink.streaming.runtime.tasks.StreamTask           - Error while canceling task.
   org.apache.flink.runtime.execution.CancelTaskException: Consumed partition PipelinedSubpartitionView(index: 0) of ResultPartition 20cd8853199f84e8a26339a17fe731e9@e809b769c817e73fa009ec5055e883e2 has been released.
   	at org.apache.flink.runtime.io.network.partition.consumer.LocalInputChannel.getNextBuffer(LocalInputChannel.java:190)
   	at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.waitAndGetNextData(SingleInputGate.java:509)
   	at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.getNextBufferOrEvent(SingleInputGate.java:487)
   	at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.pollNext(SingleInputGate.java:475)
   	at org.apache.flink.runtime.taskmanager.InputGateWithMetrics.pollNext(InputGateWithMetrics.java:75)
   	at org.apache.flink.streaming.runtime.io.CheckpointedInputGate.pollNext(CheckpointedInputGate.java:125)
   	at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.emitNext(StreamTaskNetworkInput.java:133)
   	at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:69)
   	at org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:311)
   	at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:187)
   	at org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:487)
   	at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:470)
   	at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:707)
   	at org.apache.flink.runtime.taskmanager.Task.run(Task.java:532)
   	at java.lang.Thread.run(Thread.java:748)
   2020-02-06 19:39:58,409 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Un-registering task and sending final execution state CANCELED to JobManager for task Source: Custom Source (1/1) e809b769c817e73fa009ec5055e883e2.
   2020-02-06 19:39:58,425 INFO  org.apache.flink.runtime.taskmanager.Task                     - Map -> Sink: Unnamed (1/1) (e2897fbac05b906ad242f5dd8e21fbbe) switched from CANCELING to CANCELED.
   2020-02-06 19:39:58,425 INFO  org.apache.flink.runtime.taskmanager.Task                     - Freeing task resources for Map -> Sink: Unnamed (1/1) (e2897fbac05b906ad242f5dd8e21fbbe).
   2020-02-06 19:39:58,426 INFO  org.apache.flink.runtime.taskmanager.Task                     - Ensuring all FileSystem streams are closed for task Map -> Sink: Unnamed (1/1) (e2897fbac05b906ad242f5dd8e21fbbe) [CANCELED]
   2020-02-06 19:39:58,427 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Un-registering task and sending final execution state CANCELED to JobManager for task Map -> Sink: Unnamed (1/1) e2897fbac05b906ad242f5dd8e21fbbe.
   2020-02-06 19:39:58,451 INFO  org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImpl  - Free slot TaskSlot(index:0, state:ACTIVE, resource profile: ResourceProfile{cpuCores=1.0000000000000000, taskHeapMemory=384.000mb (402653174 bytes), taskOffHeapMemory=0 bytes, managedMemory=512.000mb (536870920 bytes), networkMemory=128.000mb (134217730 bytes)}, allocationId: 0fd30c7ec2d4e14753fe9e4803721b73, jobId: b3cc3c987e7aa8f99f5814b05d0057fe).
   2020-02-06 19:39:58,452 INFO  org.apache.flink.runtime.taskexecutor.JobLeaderService        - Remove job b3cc3c987e7aa8f99f5814b05d0057fe from job leader monitoring.
   2020-02-06 19:39:58,452 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Close JobManager connection for job b3cc3c987e7aa8f99f5814b05d0057fe.
   2020-02-06 19:39:58,455 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Close JobManager connection for job b3cc3c987e7aa8f99f5814b05d0057fe.
   2020-02-06 19:39:58,455 INFO  org.apache.flink.runtime.taskexecutor.JobLeaderService        - Cannot reconnect to job b3cc3c987e7aa8f99f5814b05d0057fe because it is not registered.
   Checking for non-empty .out files...
   No non-empty .out files.
   
   [FAIL] 'State Migration end-to-end test from 1.6' failed after 0 minutes and 17 seconds! Test exited with exit code 0 but the logs contained errors, exceptions or non-empty .out files
   ```
   
   Shouldn't be related?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583268904
 
 
   I was just about to post that this is not a problem. It has been fixed on master but not on release-1.10. See https://issues.apache.org/jira/browse/FLINK-15751?focusedCommentId=17024366&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17024366

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147914634 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:681fd41a64f4bb158ed02bc0027016afeea77dc8 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:681fd41a64f4bb158ed02bc0027016afeea77dc8
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147914634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948) 
   * 681fd41a64f4bb158ed02bc0027016afeea77dc8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583266057
 
 
   > https://api.travis-ci.org/v3/job/646941244/log.txt
   
   Looks this is not an issue. Just that the upstream task was canceled earlier and triggered a CancelTaskException of the downstream task which is still processing data on the same TM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#discussion_r375876449
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
 ##########
 @@ -223,6 +232,11 @@ private Runnable restartTasks(final Set<ExecutionVertexVersion> executionVertexV
 		return () -> {
 			final Set<ExecutionVertexID> verticesToRestart = executionVertexVersioner.getUnmodifiedExecutionVertices(executionVertexVersions);
 
+			verticesWaitingForRestart.removeAll(verticesToRestart);
 
 Review comment:
   extract method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583282025
 
 
   https://travis-ci.com/flink-ci/flink/builds/147754663 seems to pass as well.
   
   Could we check whether we have a test ensuring that when we are in `RESTARTING` and calling `cancel` on the `ExecutionGraph` that we stop all tasks and eventually go into the state `CANCELED`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583074690
 
 
   Test failure rate is acceptable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147914634 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:681fd41a64f4bb158ed02bc0027016afeea77dc8 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147945058 TriggerType:PUSH TriggerID:681fd41a64f4bb158ed02bc0027016afeea77dc8
   Hash:681fd41a64f4bb158ed02bc0027016afeea77dc8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4967 TriggerType:PUSH TriggerID:681fd41a64f4bb158ed02bc0027016afeea77dc8
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147914634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948) 
   * 681fd41a64f4bb158ed02bc0027016afeea77dc8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147945058) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#discussion_r375915408
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
 ##########
 @@ -596,6 +599,43 @@ public void suspendJobWillIncrementVertexVersions() {
 		assertTrue(executionVertexVersioner.isModified(executionVertexVersion));
 	}
 
+	@Test
+	public void jobStatusIsRestartingIfOneVertexIsWaitingForRestart() {
+		final JobGraph jobGraph = singleJobVertexJobGraph(2);
+		final DefaultScheduler scheduler = createSchedulerAndStartScheduling(jobGraph);
+
+		final Iterator<ArchivedExecutionVertex> vertexIterator = scheduler.requestJob().getAllExecutionVertices().iterator();
+		final ExecutionAttemptID attemptId1 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+		final ExecutionAttemptID attemptId2 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobGraph.getJobID(), attemptId1, ExecutionState.FAILED, new RuntimeException("expected")));
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobGraph.getJobID(), attemptId2, ExecutionState.FAILED, new RuntimeException("expected")));
+
+		taskRestartExecutor.triggerNonPeriodicScheduledTask();
 
 Review comment:
   We could check that before we process the reset execution task the `JobStatus` is already `RESTARTING`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#discussion_r375876422
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
 ##########
 @@ -210,6 +216,9 @@ private void restartTasksWithDelay(final FailureHandlingResult failureHandlingRe
 		final Set<ExecutionVertexVersion> executionVertexVersions =
 			new HashSet<>(executionVertexVersioner.recordVertexModifications(verticesToRestart).values());
 
+		transitionExecutionGraphState(JobStatus.RUNNING, JobStatus.RESTARTING);
 
 Review comment:
   extract method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147914634 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147914634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582965697
 
 
   I've started a separate build on travis-ci.com. You can track the progress here: https://travis-ci.com/flink-ci/flink/builds/147751241

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147914634 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147914634) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147914634 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:681fd41a64f4bb158ed02bc0027016afeea77dc8 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147945058 TriggerType:PUSH TriggerID:681fd41a64f4bb158ed02bc0027016afeea77dc8
   Hash:681fd41a64f4bb158ed02bc0027016afeea77dc8 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4967 TriggerType:PUSH TriggerID:681fd41a64f4bb158ed02bc0027016afeea77dc8
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147914634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948) 
   * 681fd41a64f4bb158ed02bc0027016afeea77dc8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147945058) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL removed a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL removed a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583074690
 
 
   Test failure rate is acceptable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#discussion_r376348123
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
 ##########
 @@ -596,6 +599,66 @@ public void suspendJobWillIncrementVertexVersions() {
 		assertTrue(executionVertexVersioner.isModified(executionVertexVersion));
 	}
 
+	@Test
+	public void jobStatusIsRestartingIfOneVertexIsWaitingForRestart() {
+		final JobGraph jobGraph = singleJobVertexJobGraph(2);
+		final JobID jobId = jobGraph.getJobID();
+		final DefaultScheduler scheduler = createSchedulerAndStartScheduling(jobGraph);
+
+		final Iterator<ArchivedExecutionVertex> vertexIterator = scheduler.requestJob().getAllExecutionVertices().iterator();
+		final ExecutionAttemptID attemptId1 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+		final ExecutionAttemptID attemptId2 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobId, attemptId1, ExecutionState.FAILED, new RuntimeException("expected")));
+		final JobStatus jobStatusAfterFirstFailure = scheduler.requestJobStatus();
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobId, attemptId2, ExecutionState.FAILED, new RuntimeException("expected")));
+
+		taskRestartExecutor.triggerNonPeriodicScheduledTask();
+		final JobStatus jobStatusWithPendingRestarts = scheduler.requestJobStatus();
+		taskRestartExecutor.triggerNonPeriodicScheduledTask();
+		final JobStatus jobStatusAfterRestarts = scheduler.requestJobStatus();
+
+		assertThat(jobStatusAfterFirstFailure, equalTo(JobStatus.RESTARTING));
+		assertThat(jobStatusWithPendingRestarts, equalTo(JobStatus.RESTARTING));
+		assertThat(jobStatusAfterRestarts, equalTo(JobStatus.RUNNING));
+	}
+
+	@Test
+	public void cancelWhileRestartingShouldWaitForRunningTasks() {
+		final JobGraph jobGraph = singleJobVertexJobGraph(2);
+		final JobID jobid = jobGraph.getJobID();
+		final DefaultScheduler scheduler = createSchedulerAndStartScheduling(jobGraph);
+
+		final Iterator<ArchivedExecutionVertex> vertexIterator = scheduler.requestJob().getAllExecutionVertices().iterator();
+		final ExecutionAttemptID attemptId1 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+		final ExecutionAttemptID attemptId2 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobid, attemptId1, ExecutionState.FAILED, new RuntimeException("expected")));
+		scheduler.cancel();
 
 Review comment:
   We should check that this call changes `attemptId2` to go into the `CANCELLING` state in order to make sure that the cancel call is being sent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147914634 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147914634) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147755937 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:984e84bb63c7130affa8c4fca5baec9f2b0a7612 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918 TriggerType:PUSH TriggerID:984e84bb63c7130affa8c4fca5baec9f2b0a7612
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147761707 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923 TriggerType:PUSH TriggerID:c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147914634 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:4bb42e697005bacf9b499539039999bacecc2821 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948 TriggerType:PUSH TriggerID:4bb42e697005bacf9b499539039999bacecc2821
   Hash:681fd41a64f4bb158ed02bc0027016afeea77dc8 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147945058 TriggerType:PUSH TriggerID:681fd41a64f4bb158ed02bc0027016afeea77dc8
   Hash:681fd41a64f4bb158ed02bc0027016afeea77dc8 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4967 TriggerType:PUSH TriggerID:681fd41a64f4bb158ed02bc0027016afeea77dc8
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   * 984e84bb63c7130affa8c4fca5baec9f2b0a7612 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147755937) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4918) 
   * c5741f9eb0ae2ebdd6d5ef02b2220102f308e1bb Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147761707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4923) 
   * 4bb42e697005bacf9b499539039999bacecc2821 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147914634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4948) 
   * 681fd41a64f4bb158ed02bc0027016afeea77dc8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147945058) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-582936188
 
 
   <!--
   Meta data
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/147721181 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908 TriggerType:PUSH TriggerID:a1422e1cd859dcb5f9604f2ac34b68c752d5b380
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147743743 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   Hash:f97dfc49b5072da9d927eb31f9235e35311a83fc Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911 TriggerType:PUSH TriggerID:f97dfc49b5072da9d927eb31f9235e35311a83fc
   -->
   ## CI report:
   
   * a1422e1cd859dcb5f9604f2ac34b68c752d5b380 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/147721181) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4908) 
   * f97dfc49b5072da9d927eb31f9235e35311a83fc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147743743) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4911) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL edited a comment on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL edited a comment on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583112279
 
 
   https://api.travis-ci.org/v3/job/646941244/log.txt
   
   ```
   2020-02-06 19:39:58,390 INFO  org.apache.flink.runtime.taskmanager.Task                     - Ensuring all FileSystem streams are closed for task Source: Custom Source (1/1) (e809b769c817e73fa009ec5055e883e2) [CANCELED]
   2020-02-06 19:39:58,394 WARN  org.apache.flink.streaming.runtime.tasks.StreamTask           - Error while canceling task.
   org.apache.flink.runtime.execution.CancelTaskException: Consumed partition PipelinedSubpartitionView(index: 0) of ResultPartition 20cd8853199f84e8a26339a17fe731e9@e809b769c817e73fa009ec5055e883e2 has been released.
   	at org.apache.flink.runtime.io.network.partition.consumer.LocalInputChannel.getNextBuffer(LocalInputChannel.java:190)
   	at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.waitAndGetNextData(SingleInputGate.java:509)
   	at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.getNextBufferOrEvent(SingleInputGate.java:487)
   	at org.apache.flink.runtime.io.network.partition.consumer.SingleInputGate.pollNext(SingleInputGate.java:475)
   	at org.apache.flink.runtime.taskmanager.InputGateWithMetrics.pollNext(InputGateWithMetrics.java:75)
   	at org.apache.flink.streaming.runtime.io.CheckpointedInputGate.pollNext(CheckpointedInputGate.java:125)
   	at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.emitNext(StreamTaskNetworkInput.java:133)
   	at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:69)
   	at org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:311)
   	at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:187)
   	at org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:487)
   	at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:470)
   	at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:707)
   	at org.apache.flink.runtime.taskmanager.Task.run(Task.java:532)
   	at java.lang.Thread.run(Thread.java:748)
   2020-02-06 19:39:58,409 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Un-registering task and sending final execution state CANCELED to JobManager for task Source: Custom Source (1/1) e809b769c817e73fa009ec5055e883e2.
   2020-02-06 19:39:58,425 INFO  org.apache.flink.runtime.taskmanager.Task                     - Map -> Sink: Unnamed (1/1) (e2897fbac05b906ad242f5dd8e21fbbe) switched from CANCELING to CANCELED.
   2020-02-06 19:39:58,425 INFO  org.apache.flink.runtime.taskmanager.Task                     - Freeing task resources for Map -> Sink: Unnamed (1/1) (e2897fbac05b906ad242f5dd8e21fbbe).
   2020-02-06 19:39:58,426 INFO  org.apache.flink.runtime.taskmanager.Task                     - Ensuring all FileSystem streams are closed for task Map -> Sink: Unnamed (1/1) (e2897fbac05b906ad242f5dd8e21fbbe) [CANCELED]
   2020-02-06 19:39:58,427 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Un-registering task and sending final execution state CANCELED to JobManager for task Map -> Sink: Unnamed (1/1) e2897fbac05b906ad242f5dd8e21fbbe.
   2020-02-06 19:39:58,451 INFO  org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImpl  - Free slot TaskSlot(index:0, state:ACTIVE, resource profile: ResourceProfile{cpuCores=1.0000000000000000, taskHeapMemory=384.000mb (402653174 bytes), taskOffHeapMemory=0 bytes, managedMemory=512.000mb (536870920 bytes), networkMemory=128.000mb (134217730 bytes)}, allocationId: 0fd30c7ec2d4e14753fe9e4803721b73, jobId: b3cc3c987e7aa8f99f5814b05d0057fe).
   2020-02-06 19:39:58,452 INFO  org.apache.flink.runtime.taskexecutor.JobLeaderService        - Remove job b3cc3c987e7aa8f99f5814b05d0057fe from job leader monitoring.
   2020-02-06 19:39:58,452 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Close JobManager connection for job b3cc3c987e7aa8f99f5814b05d0057fe.
   2020-02-06 19:39:58,455 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutor            - Close JobManager connection for job b3cc3c987e7aa8f99f5814b05d0057fe.
   2020-02-06 19:39:58,455 INFO  org.apache.flink.runtime.taskexecutor.JobLeaderService        - Cannot reconnect to job b3cc3c987e7aa8f99f5814b05d0057fe because it is not registered.
   Checking for non-empty .out files...
   No non-empty .out files.
   
   [FAIL] 'State Migration end-to-end test from 1.6' failed after 0 minutes and 17 seconds! Test exited with exit code 0 but the logs contained errors, exceptions or non-empty .out files
   ```
   
   Shouldn't be related?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583268904
 
 
   I was just about to post that this is not a problem. See https://issues.apache.org/jira/browse/FLINK-15751?focusedCommentId=17024366&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17024366

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on issue #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#issuecomment-583283272
 
 
   @tillrohrmann  https://github.com/apache/flink/pull/11032/files#diff-71e4371a8ee17b6ce39a7022298ee228R627

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #11032: [WIP][FLINK-15918]

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11032: [WIP][FLINK-15918]
URL: https://github.com/apache/flink/pull/11032#discussion_r376394545
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java
 ##########
 @@ -596,6 +599,66 @@ public void suspendJobWillIncrementVertexVersions() {
 		assertTrue(executionVertexVersioner.isModified(executionVertexVersion));
 	}
 
+	@Test
+	public void jobStatusIsRestartingIfOneVertexIsWaitingForRestart() {
+		final JobGraph jobGraph = singleJobVertexJobGraph(2);
+		final JobID jobId = jobGraph.getJobID();
+		final DefaultScheduler scheduler = createSchedulerAndStartScheduling(jobGraph);
+
+		final Iterator<ArchivedExecutionVertex> vertexIterator = scheduler.requestJob().getAllExecutionVertices().iterator();
+		final ExecutionAttemptID attemptId1 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+		final ExecutionAttemptID attemptId2 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobId, attemptId1, ExecutionState.FAILED, new RuntimeException("expected")));
+		final JobStatus jobStatusAfterFirstFailure = scheduler.requestJobStatus();
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobId, attemptId2, ExecutionState.FAILED, new RuntimeException("expected")));
+
+		taskRestartExecutor.triggerNonPeriodicScheduledTask();
+		final JobStatus jobStatusWithPendingRestarts = scheduler.requestJobStatus();
+		taskRestartExecutor.triggerNonPeriodicScheduledTask();
+		final JobStatus jobStatusAfterRestarts = scheduler.requestJobStatus();
+
+		assertThat(jobStatusAfterFirstFailure, equalTo(JobStatus.RESTARTING));
+		assertThat(jobStatusWithPendingRestarts, equalTo(JobStatus.RESTARTING));
+		assertThat(jobStatusAfterRestarts, equalTo(JobStatus.RUNNING));
+	}
+
+	@Test
+	public void cancelWhileRestartingShouldWaitForRunningTasks() {
+		final JobGraph jobGraph = singleJobVertexJobGraph(2);
+		final JobID jobid = jobGraph.getJobID();
+		final DefaultScheduler scheduler = createSchedulerAndStartScheduling(jobGraph);
+
+		final Iterator<ArchivedExecutionVertex> vertexIterator = scheduler.requestJob().getAllExecutionVertices().iterator();
+		final ExecutionAttemptID attemptId1 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+		final ExecutionAttemptID attemptId2 = vertexIterator.next().getCurrentExecutionAttempt().getAttemptId();
+
+		scheduler.updateTaskExecutionState(new TaskExecutionState(jobid, attemptId1, ExecutionState.FAILED, new RuntimeException("expected")));
+		scheduler.cancel();
 
 Review comment:
   fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL closed pull request #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI

Posted by GitBox <gi...@apache.org>.
GJL closed pull request #11032: [FLINK-15918][FLINK-15917] Uptime Metric not reset on Job Restart / Root Exception not shown in Web UI
URL: https://github.com/apache/flink/pull/11032
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services