You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/26 22:45:53 UTC

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5318: GEODE-8313: Improve RedisData synchronization for toData

jdeppe-pivotal opened a new pull request #5318:
URL: https://github.com/apache/geode/pull/5318


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #5318: GEODE-8313: Improve RedisData synchronization for toData

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5318:
URL: https://github.com/apache/geode/pull/5318


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #5318: GEODE-8313: Improve RedisData synchronization for toData

Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on pull request #5318:
URL: https://github.com/apache/geode/pull/5318#issuecomment-650466512


   Looks like the new HashesAndCrashesDUnitTest needs some work so it can pass StressNewTest


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] lgtm-com[bot] commented on pull request #5318: GEODE-8313: Improve RedisData synchronization for toData

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5318:
URL: https://github.com/apache/geode/pull/5318#issuecomment-651330036


   This pull request **introduces 2 alerts** when merging 822952c8a258260b9cf6e5f533e427abaaddbcf0 into 4caa90beffe3321548b3364951287a6d9db314e5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-e4f02bcdca710759856a916106376dc10927b95c)
   
   **new alerts:**
   
   * 2 for Non\-synchronized override of synchronized method


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5318: GEODE-8313: Improve RedisData synchronization for toData

Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5318:
URL: https://github.com/apache/geode/pull/5318#discussion_r450521686



##########
File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/set/SetsAndCrashesDUnitTest.java
##########
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ *
+ */
+
+package org.apache.geode.redis.internal.executor.set;
+
+import static org.apache.geode.distributed.ConfigurationProperties.MAX_WAIT_TIME_RECONNECT;
+import static org.apache.geode.distributed.ConfigurationProperties.REDIS_BIND_ADDRESS;
+import static org.apache.geode.distributed.ConfigurationProperties.REDIS_ENABLED;
+import static org.apache.geode.distributed.ConfigurationProperties.REDIS_PORT;
+import static org.apache.geode.redis.internal.GeodeRedisServer.ENABLE_REDIS_UNSUPPORTED_COMMANDS_PARAM;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Properties;
+import java.util.concurrent.Future;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Consumer;
+
+import io.lettuce.core.ClientOptions;
+import io.lettuce.core.RedisClient;
+import io.lettuce.core.api.sync.RedisCommands;
+import io.lettuce.core.resource.ClientResources;
+import org.apache.logging.log4j.Logger;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.control.RebalanceFactory;
+import org.apache.geode.cache.control.RebalanceResults;
+import org.apache.geode.cache.control.ResourceManager;
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.logging.internal.log4j.api.LogService;
+import org.apache.geode.redis.session.springRedisTestApplication.config.DUnitSocketAddressResolver;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.rules.ExecutorServiceRule;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+
+public class SetsAndCrashesDUnitTest {

Review comment:
       The HashesAndCrashes test now tests hashes, sets, and strings. Do we still need SetsAndCrashesDUnitTest?
   Or should we change HashesAndCrashes to only test hashes and add another test for strings?
   I'm okay either way but we should probably do one or the other instead of both




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] lgtm-com[bot] commented on pull request #5318: GEODE-8313: Improve RedisData synchronization for toData

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #5318:
URL: https://github.com/apache/geode/pull/5318#issuecomment-650448574


   This pull request **introduces 2 alerts** when merging 01d526275c8ea3a6f384e0f8c0c0641393fc6da2 into f1a2c477f677ccf6b6f80b6bb16946654571f47c - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-0ddf87d9f253080b6323d9df875d6eb7d555950b)
   
   **new alerts:**
   
   * 2 for Non\-synchronized override of synchronized method


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org